From: Mark Brown <broonie@kernel.org>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Sangbeom Kim <sbkim73@samsung.com>,
Vinod Koul <vinod.koul@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Padmavathi Venna <padma.v@samsung.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>, Kukjin Kim <kgene.kim@samsung.com>,
Dan Williams <djbw@fb.com>, Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled
Date: Mon, 12 Aug 2013 11:07:28 +0100 [thread overview]
Message-ID: <20130812100728.GL6427@sirena.org.uk> (raw)
In-Reply-To: <2033369.1oHkX7kdGa@flatron>
[-- Attachment #1.1: Type: text/plain, Size: 730 bytes --]
On Mon, Aug 12, 2013 at 01:03:19AM +0200, Tomasz Figa wrote:
> On Sunday 11 of August 2013 20:11:40 Mark Brown wrote:
> > Do we need the select here (or should we have other selects for the
> > Exynos SoCs)?
> The driver would build fine without this symbol selected, but since it
> relies on availability of DMA, it doesn't make too much sense to build it
> this way. This kind of selects makes kernel configuration more user
> friendly IMHO.
> Possibly adding appropriate selects (PL330) for s5p* and exynos could make
> sense.
Right. On these SoCs it's probably worth doing it in the arch/arm code
rather than for every device using the controller though, it's the same
DMA controller for everything.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled
Date: Mon, 12 Aug 2013 11:07:28 +0100 [thread overview]
Message-ID: <20130812100728.GL6427@sirena.org.uk> (raw)
In-Reply-To: <2033369.1oHkX7kdGa@flatron>
On Mon, Aug 12, 2013 at 01:03:19AM +0200, Tomasz Figa wrote:
> On Sunday 11 of August 2013 20:11:40 Mark Brown wrote:
> > Do we need the select here (or should we have other selects for the
> > Exynos SoCs)?
> The driver would build fine without this symbol selected, but since it
> relies on availability of DMA, it doesn't make too much sense to build it
> this way. This kind of selects makes kernel configuration more user
> friendly IMHO.
> Possibly adding appropriate selects (PL330) for s5p* and exynos could make
> sense.
Right. On these SoCs it's probably worth doing it in the arch/arm code
rather than for every device using the controller though, it's the same
DMA controller for everything.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130812/881733fb/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, Dan Williams <djbw@fb.com>,
Jaroslav Kysela <perex@perex.cz>,
Kukjin Kim <kgene.kim@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mike Turquette <mturquette@linaro.org>,
Padmavathi Venna <padma.v@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Sangbeom Kim <sbkim73@samsung.com>, Takashi Iwai <tiwai@suse.de>,
Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled
Date: Mon, 12 Aug 2013 11:07:28 +0100 [thread overview]
Message-ID: <20130812100728.GL6427@sirena.org.uk> (raw)
In-Reply-To: <2033369.1oHkX7kdGa@flatron>
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On Mon, Aug 12, 2013 at 01:03:19AM +0200, Tomasz Figa wrote:
> On Sunday 11 of August 2013 20:11:40 Mark Brown wrote:
> > Do we need the select here (or should we have other selects for the
> > Exynos SoCs)?
> The driver would build fine without this symbol selected, but since it
> relies on availability of DMA, it doesn't make too much sense to build it
> this way. This kind of selects makes kernel configuration more user
> friendly IMHO.
> Possibly adding appropriate selects (PL330) for s5p* and exynos could make
> sense.
Right. On these SoCs it's probably worth doing it in the arch/arm code
rather than for every device using the controller though, it's the same
DMA controller for everything.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-12 10:07 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 17:59 [PATCH 00/18] ARM: s3c64xx: Let amba-pl08x driver handle DMA Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 17:59 ` [PATCH 01/18] dmaengine: PL08x: Refactor pl08x_getbytes_chan() to lower indentation Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 17:59 ` [PATCH 02/18] dmaengine: PL08x: Add support for different offset of CONFIG register Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 17:59 ` [PATCH 03/18] dmaengine: PL08x: Rework LLI handling to be less fragile Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-28 6:49 ` Linus Walleij
2013-08-28 6:49 ` Linus Walleij
2013-08-11 17:59 ` [PATCH 04/18] dmaengine: PL08x: Move LLI dumping code into separate function Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-28 6:50 ` Linus Walleij
2013-08-28 6:50 ` Linus Walleij
2013-08-11 17:59 ` [PATCH 05/18] dmaengine: PL08x: Add support for PL080S variant Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 17:59 ` [PATCH 06/18] dmaengine: PL08x: Add support for different maximum transfer size Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 17:59 ` [PATCH 07/18] dmaengine: PL08x: Fix reading the byte count in cctl Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 17:59 ` [PATCH 08/18] dmaengine: PL08x: Add cyclic transfer support Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 17:59 ` [PATCH 09/18] ASoC: Samsung: Do not queue cyclic buffers multiple times Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-28 7:06 ` Linus Walleij
2013-08-28 7:06 ` Linus Walleij
2013-08-28 8:23 ` Tomasz Figa
2013-08-28 8:23 ` Tomasz Figa
2013-08-28 9:53 ` Mark Brown
2013-08-28 9:53 ` Mark Brown
2013-08-29 16:36 ` Mark Brown
2013-08-29 16:36 ` [alsa-devel] " Mark Brown
2013-08-29 16:36 ` Mark Brown
2013-08-29 17:36 ` Linus Walleij
2013-08-29 17:36 ` Linus Walleij
2013-08-11 17:59 ` [PATCH 10/18] spi: s3c64xx: Do not require legacy DMA API in case of S3C64XX Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-12 23:36 ` Mark Brown
2013-08-12 23:36 ` Mark Brown
2013-08-12 23:49 ` Tomasz Figa
2013-08-12 23:49 ` Tomasz Figa
2013-08-13 12:02 ` Mark Brown
2013-08-13 12:02 ` Mark Brown
2013-08-13 12:02 ` Mark Brown
2013-08-13 18:55 ` Mark Brown
2013-08-13 18:55 ` Mark Brown
2013-08-13 20:18 ` Mark Brown
2013-08-13 20:18 ` Mark Brown
2013-08-13 20:20 ` Tomasz Figa
2013-08-13 20:20 ` Tomasz Figa
2013-08-13 20:20 ` Tomasz Figa
2013-08-13 20:29 ` Mark Brown
2013-08-13 20:29 ` Mark Brown
2013-08-13 20:29 ` Mark Brown
2013-08-11 17:59 ` [PATCH 11/18] ASoC: Samsung: " Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 17:59 ` [PATCH 12/18] ARM: s3c64xx: Add support for DMA using generic amba-pl08x driver Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-13 17:52 ` Mark Brown
2013-08-13 17:52 ` Mark Brown
2013-08-13 20:10 ` Tomasz Figa
2013-08-13 20:10 ` Tomasz Figa
2013-08-13 20:35 ` Mark Brown
2013-08-13 20:35 ` Mark Brown
2013-08-13 20:35 ` Mark Brown
2013-08-13 21:11 ` Tomasz Figa
2013-08-13 21:11 ` Tomasz Figa
2013-08-24 0:17 ` [PATCH v2 " Tomasz Figa
2013-08-24 0:17 ` Tomasz Figa
2013-08-11 17:59 ` [PATCH 13/18] ARM: s3c64xx: clock: Add clkdev lookup for DMA clocks Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 17:59 ` [PATCH 14/18] clk: samsung: s3c64xx: Add aliases " Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-12 19:45 ` Mike Turquette
2013-08-12 19:45 ` Mike Turquette
2013-08-12 19:45 ` Mike Turquette
2013-08-11 17:59 ` [PATCH 15/18] ARM: s3c64xx: Remove legacy DMA driver Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 17:59 ` [PATCH 16/18] clk: samsung: s3c64xx: Remove clock aliases of old " Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-12 19:45 ` Mike Turquette
2013-08-12 19:45 ` Mike Turquette
2013-08-12 19:45 ` Mike Turquette
2013-08-11 17:59 ` [PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-11 19:11 ` Mark Brown
2013-08-11 19:11 ` Mark Brown
2013-08-11 19:11 ` Mark Brown
2013-08-11 23:03 ` Tomasz Figa
2013-08-11 23:03 ` Tomasz Figa
2013-08-11 23:03 ` Tomasz Figa
2013-08-12 10:07 ` Mark Brown [this message]
2013-08-12 10:07 ` Mark Brown
2013-08-12 10:07 ` Mark Brown
2013-08-11 17:59 ` [PATCH 18/18] ASoC: Samsung: " Tomasz Figa
2013-08-11 17:59 ` Tomasz Figa
2013-08-15 11:50 ` [PATCH 00/18] ARM: s3c64xx: Let amba-pl08x driver handle DMA Tomasz Figa
2013-08-15 11:50 ` Tomasz Figa
2013-09-02 6:16 ` Vinod Koul
2013-09-02 6:16 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812100728.GL6427@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=djbw@fb.com \
--cc=kgene.kim@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=padma.v@samsung.com \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.de \
--cc=tomasz.figa@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.