All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] USB: EHCI: make ehci-w90X900 a separate driver
Date: Mon, 12 Aug 2013 13:17:10 -0700	[thread overview]
Message-ID: <20130812201710.GA26239@kroah.com> (raw)
In-Reply-To: <1376120073-30502-1-git-send-email-manjunath.goudar@linaro.org>

On Sat, Aug 10, 2013 at 01:04:33PM +0530, Manjunath Goudar wrote:
> Separate the W90X900(W90P910) on-chip host controller driver from
> ehci-hcd host code so that it can be built as a separate driver module.
> This work is part of enabling multi-platform kernels on ARM;
> however, note that other changes are still needed before W90X900(W90P910)
> can be booted with a multi-platform kernel
> 
> and an ehci driver that only works on one of them.
> 
> With the infrastructure added by Alan Stern in patch 3e0232039
> "USB: EHCI: prepare to make ehci-hcd a library module", we can
> avoid this problem by turning a bus glue into a separate
> module, as we do here for the w90X900 bus glue.
> 
> Signed-off-by: Manjunath Goudar <manjunath.goudar@linaro.org>
> Signed-off-by: Deepak Saxena <dsaxena@linaro.org>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Wan ZongShun <mcuos.com@gmail.com>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> Cc: Greg KH <greg@kroah.com>
> Cc: linux-usb at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> 
> V2:
> -Arranged  #include's in alphabetical order.
> -Replaced "w90p910" by "w90x900" because it is supports
>  all series of w90x900.
> 
>  drivers/usb/host/Kconfig        |    2 +-
>  drivers/usb/host/Makefile       |    1 +
>  drivers/usb/host/ehci-hcd.c     |    5 ---
>  drivers/usb/host/ehci-w90x900.c |   85 ++++++++++++++++-----------------------
>  4 files changed, 37 insertions(+), 56 deletions(-)

This patch fails to apply:

checking file drivers/usb/host/Kconfig
Hunk #1 succeeded at 236 with fuzz 1 (offset -8 lines).
checking file drivers/usb/host/Makefile
Hunk #1 FAILED at 35.
1 out of 1 hunk FAILED
checking file drivers/usb/host/ehci-hcd.c
Hunk #1 succeeded at 1246 (offset -3 lines).
checking file drivers/usb/host/ehci-w90x900.c
Hunk #2 FAILED at 114.
1 out of 3 hunks FAILED

Please redo it against the latest usb-next branch and resend.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Manjunath Goudar <manjunath.goudar@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, patches@linaro.org,
	arnd@linaro.org, dsaxena@linaro.org,
	linaro-kernel@lists.linaro.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] USB: EHCI: make ehci-w90X900 a separate driver
Date: Mon, 12 Aug 2013 13:17:10 -0700	[thread overview]
Message-ID: <20130812201710.GA26239@kroah.com> (raw)
In-Reply-To: <1376120073-30502-1-git-send-email-manjunath.goudar@linaro.org>

On Sat, Aug 10, 2013 at 01:04:33PM +0530, Manjunath Goudar wrote:
> Separate the W90X900(W90P910) on-chip host controller driver from
> ehci-hcd host code so that it can be built as a separate driver module.
> This work is part of enabling multi-platform kernels on ARM;
> however, note that other changes are still needed before W90X900(W90P910)
> can be booted with a multi-platform kernel
> 
> and an ehci driver that only works on one of them.
> 
> With the infrastructure added by Alan Stern in patch 3e0232039
> "USB: EHCI: prepare to make ehci-hcd a library module", we can
> avoid this problem by turning a bus glue into a separate
> module, as we do here for the w90X900 bus glue.
> 
> Signed-off-by: Manjunath Goudar <manjunath.goudar@linaro.org>
> Signed-off-by: Deepak Saxena <dsaxena@linaro.org>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Wan ZongShun <mcuos.com@gmail.com>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> Cc: Greg KH <greg@kroah.com>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> 
> V2:
> -Arranged  #include's in alphabetical order.
> -Replaced "w90p910" by "w90x900" because it is supports
>  all series of w90x900.
> 
>  drivers/usb/host/Kconfig        |    2 +-
>  drivers/usb/host/Makefile       |    1 +
>  drivers/usb/host/ehci-hcd.c     |    5 ---
>  drivers/usb/host/ehci-w90x900.c |   85 ++++++++++++++++-----------------------
>  4 files changed, 37 insertions(+), 56 deletions(-)

This patch fails to apply:

checking file drivers/usb/host/Kconfig
Hunk #1 succeeded at 236 with fuzz 1 (offset -8 lines).
checking file drivers/usb/host/Makefile
Hunk #1 FAILED at 35.
1 out of 1 hunk FAILED
checking file drivers/usb/host/ehci-hcd.c
Hunk #1 succeeded at 1246 (offset -3 lines).
checking file drivers/usb/host/ehci-w90x900.c
Hunk #2 FAILED at 114.
1 out of 3 hunks FAILED

Please redo it against the latest usb-next branch and resend.

thanks,

greg k-h

  reply	other threads:[~2013-08-12 20:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 15:31 [PATCH] USB: EHCI: make ehci-w90X900 a separate driver Manjunath Goudar
2013-06-27 15:31 ` Manjunath Goudar
2013-06-27 18:09 ` Alan Stern
2013-06-27 18:09   ` Alan Stern
2013-07-22 10:19 ` [PATCH V2] " Manjunath Goudar
2013-07-22 10:19   ` Manjunath Goudar
2013-07-23  2:05   ` Wan ZongShun
2013-07-23  2:05     ` Wan ZongShun
2013-07-23 18:53   ` Alan Stern
2013-07-23 18:53     ` Alan Stern
2013-07-31 10:05 ` Manjunath Goudar
2013-07-31 10:05   ` Manjunath Goudar
2013-08-10  7:34 ` Manjunath Goudar
2013-08-10  7:34   ` Manjunath Goudar
2013-08-12 20:17   ` Greg KH [this message]
2013-08-12 20:17     ` Greg KH
2013-09-13 12:33 ` Manjunath Goudar
2013-09-13 12:33   ` Manjunath Goudar
2013-09-21 11:14 ` Manjunath Goudar
2013-09-21 11:14   ` Manjunath Goudar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130812201710.GA26239@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.