From: Felipe Balbi <balbi@ti.com>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: balbi@ti.com, Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: linux-next: build failure after merge of the final tree (usb-gadget tree related)
Date: Tue, 13 Aug 2013 14:56:38 -0500 [thread overview]
Message-ID: <20130813195638.GD11075@radagast> (raw)
In-Reply-To: <CA+icZUUse7BHLQWZYAq1znr8XbiiFyxrCN1YxiR+z=cUH+D6jQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
On Tue, Aug 13, 2013 at 09:52:53PM +0200, Sedat Dilek wrote:
> On Tue, Aug 13, 2013 at 9:51 PM, Felipe Balbi <balbi@ti.com> wrote:
> > On Tue, Aug 13, 2013 at 02:48:03PM -0500, Felipe Balbi wrote:
> >> Hi,
> >>
> >> On Tue, Aug 13, 2013 at 06:17:19PM +1000, Stephen Rothwell wrote:
> >> > Hi all,
> >> >
> >> > After merging the final tree, today's linux-next build (powerpc allyesconfig)
> >> > failed like this:
> >> >
> >> > drivers/usb/phy/phy-am335x-control.c: In function 'am335x_control_usb_probe':
> >> > drivers/usb/phy/phy-am335x-control.c:117:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> >> > if (IS_ERR(ctrl_usb->phy_reg))
> >> > ^
> >> > drivers/usb/phy/phy-am335x-control.c:118:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
> >> > return PTR_ERR(ctrl_usb->phy_reg);
> >> > ^
> >> >
> >> > Caused by commit 3bb869c8b3f1 ("usb: phy: Add AM335x PHY driver") from
> >> > the usb-gadget tree. Forgot to include linux/err.h.
> >> >
> >> > I have reverted that commit for today.
> >>
> >> damn, I didn't catch that. Sebastian, can you send a patch ?
> >
> > nevermind already patched it myself.
> >
>
> Sebastian sent some hours ago this one:
>
> [PATCH] usb: phy: am335x: include linux/err.h
will replace with that.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: <balbi@ti.com>, Stephen Rothwell <sfr@canb.auug.org.au>,
<linux-next@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: linux-next: build failure after merge of the final tree (usb-gadget tree related)
Date: Tue, 13 Aug 2013 14:56:38 -0500 [thread overview]
Message-ID: <20130813195638.GD11075@radagast> (raw)
In-Reply-To: <CA+icZUUse7BHLQWZYAq1znr8XbiiFyxrCN1YxiR+z=cUH+D6jQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
On Tue, Aug 13, 2013 at 09:52:53PM +0200, Sedat Dilek wrote:
> On Tue, Aug 13, 2013 at 9:51 PM, Felipe Balbi <balbi@ti.com> wrote:
> > On Tue, Aug 13, 2013 at 02:48:03PM -0500, Felipe Balbi wrote:
> >> Hi,
> >>
> >> On Tue, Aug 13, 2013 at 06:17:19PM +1000, Stephen Rothwell wrote:
> >> > Hi all,
> >> >
> >> > After merging the final tree, today's linux-next build (powerpc allyesconfig)
> >> > failed like this:
> >> >
> >> > drivers/usb/phy/phy-am335x-control.c: In function 'am335x_control_usb_probe':
> >> > drivers/usb/phy/phy-am335x-control.c:117:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> >> > if (IS_ERR(ctrl_usb->phy_reg))
> >> > ^
> >> > drivers/usb/phy/phy-am335x-control.c:118:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
> >> > return PTR_ERR(ctrl_usb->phy_reg);
> >> > ^
> >> >
> >> > Caused by commit 3bb869c8b3f1 ("usb: phy: Add AM335x PHY driver") from
> >> > the usb-gadget tree. Forgot to include linux/err.h.
> >> >
> >> > I have reverted that commit for today.
> >>
> >> damn, I didn't catch that. Sebastian, can you send a patch ?
> >
> > nevermind already patched it myself.
> >
>
> Sebastian sent some hours ago this one:
>
> [PATCH] usb: phy: am335x: include linux/err.h
will replace with that.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-13 19:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 8:17 linux-next: build failure after merge of the final tree (usb-gadget tree related) Stephen Rothwell
2013-08-13 8:57 ` [PATCH] usb: phy: am335x: include linux/err.h Sebastian Andrzej Siewior
2013-08-13 19:48 ` linux-next: build failure after merge of the final tree (usb-gadget tree related) Felipe Balbi
2013-08-13 19:48 ` Felipe Balbi
2013-08-13 19:51 ` Felipe Balbi
2013-08-13 19:51 ` Felipe Balbi
2013-08-13 19:52 ` Sedat Dilek
2013-08-13 19:56 ` Felipe Balbi [this message]
2013-08-13 19:56 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813195638.GD11075@radagast \
--to=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.