All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Shuah Khan <shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org,
	fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org,
	tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	shuahkhan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	andreas.herrmann-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
	joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org,
	Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org
Subject: Re: [PATCH v2] iommu: Add event tracing feature to iommu
Date: Wed, 14 Aug 2013 16:17:58 +0200	[thread overview]
Message-ID: <20130814141758.GN28811@8bytes.org> (raw)
In-Reply-To: <1375196229-2784-1-git-send-email-shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Hi Shuah,

thanks for doing this. I have a few suggestions for improvements.

On Tue, Jul 30, 2013 at 08:57:09AM -0600, Shuah Khan wrote:
> iommu:add_device_to_group
> iommu:remove_device_from_group
> iommu:attach_device_to_domain
> iommu:detach_device_from_domain
> iommu:unmap
> iommu:map

Please send these events as seperate patches.

> iommu:amd_event

This needs some more thought. For now I would prefer an event in the
generic report_iommu_fault() routine to report page-faults from all IOMMUs
that support this.

Thanks,

	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Shuah Khan <shuah.kh@samsung.com>
Cc: alex.williamson@redhat.com, Varun.Sethi@freescale.com,
	aik@ozlabs.ru, joe@perches.com, rostedt@goodmis.org,
	fweisbec@gmail.com, mingo@redhat.com, tony@atomide.com,
	ohad@wizery.com, andreas.herrmann@calxeda.com,
	will.deacon@arm.com, linux-kernel@vger.kernel.org,
	iommu@lists.linux-foundation.org, shuahkhan@gmail.com
Subject: Re: [PATCH v2] iommu: Add event tracing feature to iommu
Date: Wed, 14 Aug 2013 16:17:58 +0200	[thread overview]
Message-ID: <20130814141758.GN28811@8bytes.org> (raw)
In-Reply-To: <1375196229-2784-1-git-send-email-shuah.kh@samsung.com>

Hi Shuah,

thanks for doing this. I have a few suggestions for improvements.

On Tue, Jul 30, 2013 at 08:57:09AM -0600, Shuah Khan wrote:
> iommu:add_device_to_group
> iommu:remove_device_from_group
> iommu:attach_device_to_domain
> iommu:detach_device_from_domain
> iommu:unmap
> iommu:map

Please send these events as seperate patches.

> iommu:amd_event

This needs some more thought. For now I would prefer an event in the
generic report_iommu_fault() routine to report page-faults from all IOMMUs
that support this.

Thanks,

	Joerg



  parent reply	other threads:[~2013-08-14 14:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30 14:57 [PATCH v2] iommu: Add event tracing feature to iommu Shuah Khan
2013-08-09 16:41 ` Shuah Khan
2013-08-09 16:41   ` Shuah Khan
     [not found] ` <1375196229-2784-1-git-send-email-shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-08-14 14:17   ` Joerg Roedel [this message]
2013-08-14 14:17     ` Joerg Roedel
     [not found]     ` <20130814141758.GN28811-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-08-14 16:06       ` Shuah Khan
2013-08-14 16:06         ` Shuah Khan
     [not found]         ` <520BAAF0.8000509-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-08-14 16:17           ` Joerg Roedel
2013-08-14 16:17             ` Joerg Roedel
  -- strict thread matches above, loose matches on Subject: below --
2013-07-30  1:22 Shuah Khan
2013-07-30  1:24 ` Shuah Khan
     [not found] ` <1375147366-2922-1-git-send-email-shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-07-30  1:29   ` Joe Perches
2013-07-30  1:29     ` Joe Perches
2013-07-30 14:18     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130814141758.GN28811@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org \
    --cc=andreas.herrmann-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org \
    --cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
    --cc=shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=shuahkhan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.