All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Xishi Qiu <qiuxishi@huawei.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	riel@redhat.com, aquini@redhat.com, linux-mm@kvack.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: skip the page buddy block instead of one page
Date: Thu, 15 Aug 2013 23:16:53 +0900	[thread overview]
Message-ID: <20130815141652.GE8437@gmail.com> (raw)
In-Reply-To: <20130815134209.GW2296@suse.de>

On Thu, Aug 15, 2013 at 02:42:09PM +0100, Mel Gorman wrote:
> On Thu, Aug 15, 2013 at 10:19:35PM +0900, Minchan Kim wrote:
> > > 
> > > Why? We're looking for pages to migrate. If the page is free and at the
> > > maximum order then there is no point searching in the middle of a free
> > > page.
> > 
> > isolate_migratepages_range API works with [low_pfn, end_pfn)
> > and we can't guarantee page_order in normal compaction path
> > so I'd like to limit the skipping by end_pfn conservatively.
> > 
> 
> Fine
> 
> s/MAX_ORDER_NR_PAGES/pageblock_nr_pages/
> 
> and take the min of it and
> 
> low_pfn = min(low_pfn, end_pfn - 1)

True. That was really what I suggested to Xishi.
Only thing we need it is just number to justify for proving the benefit.

Thanks.

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Xishi Qiu <qiuxishi@huawei.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	riel@redhat.com, aquini@redhat.com, linux-mm@kvack.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: skip the page buddy block instead of one page
Date: Thu, 15 Aug 2013 23:16:53 +0900	[thread overview]
Message-ID: <20130815141652.GE8437@gmail.com> (raw)
In-Reply-To: <20130815134209.GW2296@suse.de>

On Thu, Aug 15, 2013 at 02:42:09PM +0100, Mel Gorman wrote:
> On Thu, Aug 15, 2013 at 10:19:35PM +0900, Minchan Kim wrote:
> > > 
> > > Why? We're looking for pages to migrate. If the page is free and at the
> > > maximum order then there is no point searching in the middle of a free
> > > page.
> > 
> > isolate_migratepages_range API works with [low_pfn, end_pfn)
> > and we can't guarantee page_order in normal compaction path
> > so I'd like to limit the skipping by end_pfn conservatively.
> > 
> 
> Fine
> 
> s/MAX_ORDER_NR_PAGES/pageblock_nr_pages/
> 
> and take the min of it and
> 
> low_pfn = min(low_pfn, end_pfn - 1)

True. That was really what I suggested to Xishi.
Only thing we need it is just number to justify for proving the benefit.

Thanks.

-- 
Kind regards,
Minchan Kim

  reply	other threads:[~2013-08-15 14:17 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14  4:45 [PATCH] mm: skip the page buddy block instead of one page Xishi Qiu
2013-08-14  4:45 ` Xishi Qiu
2013-08-14  7:07 ` Minchan Kim
2013-08-14  7:07   ` Minchan Kim
2013-08-14  8:57 ` Mel Gorman
2013-08-14  8:57   ` Mel Gorman
2013-08-14  9:14   ` Xishi Qiu
2013-08-14  9:14     ` Xishi Qiu
2013-08-14 15:52   ` Minchan Kim
2013-08-14 15:52     ` Minchan Kim
2013-08-14 16:16     ` Mel Gorman
2013-08-14 16:16       ` Mel Gorman
2013-08-14 16:39       ` Minchan Kim
2013-08-14 16:39         ` Minchan Kim
2013-08-14 18:00         ` Mel Gorman
2013-08-14 18:00           ` Mel Gorman
2013-08-14 19:11           ` Minchan Kim
2013-08-14 19:11             ` Minchan Kim
2013-08-15  2:32           ` Xishi Qiu
2013-08-15  2:32             ` Xishi Qiu
2013-08-15  2:44             ` Minchan Kim
2013-08-15  2:44               ` Minchan Kim
2013-08-15  3:46               ` Xishi Qiu
2013-08-15  3:46                 ` Xishi Qiu
2013-08-15  3:59                 ` Wanpeng Li
2013-08-15  3:59                 ` Wanpeng Li
2013-08-15  4:17                 ` Minchan Kim
2013-08-15  4:17                   ` Minchan Kim
2013-08-15  4:24                   ` Minchan Kim
2013-08-15  4:24                     ` Minchan Kim
2013-08-15  7:45                     ` Xishi Qiu
2013-08-15  7:45                       ` Xishi Qiu
2013-08-15  9:51                       ` Wanpeng Li
2013-08-15  9:51                       ` Wanpeng Li
2013-08-15 11:15                         ` Xishi Qiu
2013-08-15 11:15                           ` Xishi Qiu
2013-08-15 11:23                           ` Wanpeng Li
2013-08-15 11:23                           ` Wanpeng Li
2013-08-15 11:17                         ` Xishi Qiu
2013-08-15 11:17                           ` Xishi Qiu
2013-08-15  6:38                   ` Xishi Qiu
2013-08-15  6:38                     ` Xishi Qiu
2013-08-15 11:30                   ` Mel Gorman
2013-08-15 11:30                     ` Mel Gorman
2013-08-15 13:19                     ` Minchan Kim
2013-08-15 13:19                       ` Minchan Kim
2013-08-15 13:42                       ` Mel Gorman
2013-08-15 13:42                         ` Mel Gorman
2013-08-15 14:16                         ` Minchan Kim [this message]
2013-08-15 14:16                           ` Minchan Kim
2013-08-14 20:26     ` Andrew Morton
2013-08-14 20:26       ` Andrew Morton
2013-08-14 22:22       ` Mel Gorman
2013-08-14 22:22         ` Mel Gorman
2014-01-17 14:32         ` [PATCH] mm: Improve documentation of page_order Mel Gorman
2014-01-17 14:32           ` Mel Gorman
2014-01-17 18:40           ` Rafael Aquini
2014-01-17 18:40             ` Rafael Aquini
2014-01-17 18:53           ` Laura Abbott
2014-01-17 18:53             ` Laura Abbott
2014-01-17 19:59             ` Mel Gorman
2014-01-17 19:59               ` Mel Gorman
2014-01-21 11:05               ` [PATCH] mm: Improve documentation of page_order v2 Mel Gorman
2014-01-21 11:05                 ` Mel Gorman
2014-01-20  6:12           ` [PATCH] mm: Improve documentation of page_order Minchan Kim
2014-01-20  6:12             ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130815141652.GE8437@gmail.com \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=aquini@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=qiuxishi@huawei.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.