All of lore.kernel.org
 help / color / mirror / Atom feed
From: konrad.wilk@oracle.com (Konrad Rzeszutek Wilk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 02/10] swiotlb-xen: replace dma_length with sg_dma_len() macro
Date: Thu, 15 Aug 2013 15:45:57 -0400	[thread overview]
Message-ID: <20130815194557.GB5337@konrad-lan.dumpdata.com> (raw)
In-Reply-To: <1376565054-24153-2-git-send-email-stefano.stabellini@eu.citrix.com>

On Thu, Aug 15, 2013 at 12:10:46PM +0100, Stefano Stabellini wrote:
> swiotlb-xen has an implicit dependency on CONFIG_NEED_SG_DMA_LENGTH.
> Remove it by replacing dma_length with sg_dma_len.
> 

Ditto. Already took that one.
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
>  drivers/xen/swiotlb-xen.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index aadffcf..1b2277c 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -506,13 +506,13 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl,
>  				   to do proper error handling. */
>  				xen_swiotlb_unmap_sg_attrs(hwdev, sgl, i, dir,
>  							   attrs);
> -				sgl[0].dma_length = 0;
> +				sg_dma_len(sgl) = 0;
>  				return DMA_ERROR_CODE;
>  			}
>  			sg->dma_address = xen_phys_to_bus(map);
>  		} else
>  			sg->dma_address = dev_addr;
> -		sg->dma_length = sg->length;
> +		sg_dma_len(sg) = sg->length;
>  	}
>  	return nelems;
>  }
> @@ -533,7 +533,7 @@ xen_swiotlb_unmap_sg_attrs(struct device *hwdev, struct scatterlist *sgl,
>  	BUG_ON(dir == DMA_NONE);
>  
>  	for_each_sg(sgl, sg, nelems, i)
> -		xen_unmap_single(hwdev, sg->dma_address, sg->dma_length, dir);
> +		xen_unmap_single(hwdev, sg->dma_address, sg_dma_len(sg), dir);
>  
>  }
>  EXPORT_SYMBOL_GPL(xen_swiotlb_unmap_sg_attrs);
> @@ -555,7 +555,7 @@ xen_swiotlb_sync_sg(struct device *hwdev, struct scatterlist *sgl,
>  
>  	for_each_sg(sgl, sg, nelems, i)
>  		xen_swiotlb_sync_single(hwdev, sg->dma_address,
> -					sg->dma_length, dir, target);
> +					sg_dma_len(sg), dir, target);
>  }
>  
>  void
> -- 
> 1.7.2.5
> 

WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Ian.Campbell@citrix.com
Subject: Re: [PATCH v4 02/10] swiotlb-xen: replace dma_length with sg_dma_len() macro
Date: Thu, 15 Aug 2013 15:45:57 -0400	[thread overview]
Message-ID: <20130815194557.GB5337@konrad-lan.dumpdata.com> (raw)
In-Reply-To: <1376565054-24153-2-git-send-email-stefano.stabellini@eu.citrix.com>

On Thu, Aug 15, 2013 at 12:10:46PM +0100, Stefano Stabellini wrote:
> swiotlb-xen has an implicit dependency on CONFIG_NEED_SG_DMA_LENGTH.
> Remove it by replacing dma_length with sg_dma_len.
> 

Ditto. Already took that one.
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
>  drivers/xen/swiotlb-xen.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index aadffcf..1b2277c 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -506,13 +506,13 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl,
>  				   to do proper error handling. */
>  				xen_swiotlb_unmap_sg_attrs(hwdev, sgl, i, dir,
>  							   attrs);
> -				sgl[0].dma_length = 0;
> +				sg_dma_len(sgl) = 0;
>  				return DMA_ERROR_CODE;
>  			}
>  			sg->dma_address = xen_phys_to_bus(map);
>  		} else
>  			sg->dma_address = dev_addr;
> -		sg->dma_length = sg->length;
> +		sg_dma_len(sg) = sg->length;
>  	}
>  	return nelems;
>  }
> @@ -533,7 +533,7 @@ xen_swiotlb_unmap_sg_attrs(struct device *hwdev, struct scatterlist *sgl,
>  	BUG_ON(dir == DMA_NONE);
>  
>  	for_each_sg(sgl, sg, nelems, i)
> -		xen_unmap_single(hwdev, sg->dma_address, sg->dma_length, dir);
> +		xen_unmap_single(hwdev, sg->dma_address, sg_dma_len(sg), dir);
>  
>  }
>  EXPORT_SYMBOL_GPL(xen_swiotlb_unmap_sg_attrs);
> @@ -555,7 +555,7 @@ xen_swiotlb_sync_sg(struct device *hwdev, struct scatterlist *sgl,
>  
>  	for_each_sg(sgl, sg, nelems, i)
>  		xen_swiotlb_sync_single(hwdev, sg->dma_address,
> -					sg->dma_length, dir, target);
> +					sg_dma_len(sg), dir, target);
>  }
>  
>  void
> -- 
> 1.7.2.5
> 

  reply	other threads:[~2013-08-15 19:45 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15 11:10 [PATCH v4 0/10] enable swiotlb-xen on arm and arm64 Stefano Stabellini
2013-08-15 11:10 ` Stefano Stabellini
2013-08-15 11:10 ` Stefano Stabellini
2013-08-15 11:10 ` [PATCH v4 01/10] swiotlb: replace dma_length with sg_dma_len() macro Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 19:45   ` Konrad Rzeszutek Wilk
2013-08-15 19:45     ` Konrad Rzeszutek Wilk
2013-08-15 19:45     ` Konrad Rzeszutek Wilk
2013-08-15 11:10 ` [PATCH v4 02/10] swiotlb-xen: " Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 19:45   ` Konrad Rzeszutek Wilk [this message]
2013-08-15 19:45     ` Konrad Rzeszutek Wilk
2013-08-15 11:10 ` [PATCH v4 03/10] arm: make SWIOTLB available Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10 ` [PATCH v4 04/10] arm: introduce a global dma_ops pointer Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10 ` [PATCH v4 05/10] arm64: do not initialize arm64_swiotlb if dma_ops is already set Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-19 16:55   ` Catalin Marinas
2013-08-19 16:55     ` Catalin Marinas
2013-08-19 16:55     ` Catalin Marinas
2013-08-15 11:10 ` [PATCH v4 06/10] xen/arm,arm64: move Xen initialization earlier Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-19 16:55   ` Catalin Marinas
2013-08-19 16:55     ` Catalin Marinas
2013-08-19 16:55     ` Catalin Marinas
2013-08-28 19:52     ` Stefano Stabellini
2013-08-28 19:52       ` Stefano Stabellini
2013-08-15 11:10 ` [PATCH v4 07/10] xen: introduce XENMEM_exchange_and_pin and XENMEM_unpin Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 19:50   ` Konrad Rzeszutek Wilk
2013-08-15 19:50     ` Konrad Rzeszutek Wilk
2013-08-29 15:54     ` Stefano Stabellini
2013-08-29 15:54       ` Stefano Stabellini
2013-08-29 15:54       ` Stefano Stabellini
2013-08-15 11:10 ` [PATCH v4 08/10] xen: make xen_create_contiguous_region return the dma address Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10 ` [PATCH v4 09/10] swiotlb-xen: support autotranslate guests Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 20:07   ` Konrad Rzeszutek Wilk
2013-08-15 20:07     ` Konrad Rzeszutek Wilk
2013-08-29 16:05     ` Stefano Stabellini
2013-08-29 16:05       ` Stefano Stabellini
2013-08-29 16:05       ` Stefano Stabellini
2013-08-30 13:23       ` Konrad Rzeszutek Wilk
2013-08-30 13:23         ` Konrad Rzeszutek Wilk
2013-08-15 11:10 ` [PATCH v4 10/10] xen/arm,arm64: enable SWIOTLB_XEN Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 11:10   ` Stefano Stabellini
2013-08-15 20:58   ` Ian Campbell
2013-08-15 20:58     ` Ian Campbell
2013-08-15 20:58     ` Ian Campbell
2013-08-28 20:07     ` Stefano Stabellini
2013-08-28 20:07       ` Stefano Stabellini
2013-08-28 20:07       ` Stefano Stabellini
2013-08-29  8:40       ` Ian Campbell
2013-08-29  8:40         ` Ian Campbell
2013-08-29  8:40         ` Ian Campbell
2013-08-29 15:38         ` Stefano Stabellini
2013-08-29 15:38           ` Stefano Stabellini
2013-08-29 15:38           ` Stefano Stabellini
2013-08-30 13:22           ` Konrad Rzeszutek Wilk
2013-08-30 13:22             ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130815194557.GB5337@konrad-lan.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.