From: Nicolin Chen <b42378@freescale.com>
To: Bhushan Bharat-R65777 <R65777@freescale.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"timur@tabi.org" <timur@tabi.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"tomasz.figa@gmail.com" <tomasz.figa@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"festevam@gmail.com" <festevam@gmail.com>
Subject: Re: [PATCH v6 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver
Date: Mon, 19 Aug 2013 14:44:41 +0800 [thread overview]
Message-ID: <20130819064440.GA10950@MrMyself> (raw)
In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D07116CDE@039-SN2MPN1-013.039d.mgd.msft.net>
On Mon, Aug 19, 2013 at 02:31:47PM +0800, Bhushan Bharat-R65777 wrote:
> > > > We here suppose the reset bit would be cleared -- "The software
> > > > reset will last
> > > > 8 cycles." from RM, so if this happened to be a failure, the whole
> > > > IP module won't be normally working as well.
> > >
> > > Also add a comment describing this against why cycle = 1000 is selected.
> >
> > If it is done in 8 cycles, 1000-cycle will be surely a safe value for it.
> > As long as it finished in 8 cycles, it would quit anyway. Why against?
>
> I am not against, I am saying why it was not 200 or 50 or 20 etc. I am saying that write a comment saying this much is sufficient as per specification and so keep 1000/etc as preservative.
I did't mean that. The 'against' is from
"Also add a comment describing this 'against' why cycle = 1000 is selected."
Well, if you insist this extra comment for easy-understand, I'll add them
Thank you.
Nicolin Chen
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <b42378@freescale.com>
To: Bhushan Bharat-R65777 <R65777@freescale.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"timur@tabi.org" <timur@tabi.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"tomasz.figa@gmail.com" <tomasz.figa@gmail.com>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v6 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver
Date: Mon, 19 Aug 2013 14:44:41 +0800 [thread overview]
Message-ID: <20130819064440.GA10950@MrMyself> (raw)
In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D07116CDE@039-SN2MPN1-013.039d.mgd.msft.net>
On Mon, Aug 19, 2013 at 02:31:47PM +0800, Bhushan Bharat-R65777 wrote:
> > > > We here suppose the reset bit would be cleared -- "The software
> > > > reset will last
> > > > 8 cycles." from RM, so if this happened to be a failure, the whole
> > > > IP module won't be normally working as well.
> > >
> > > Also add a comment describing this against why cycle = 1000 is selected.
> >
> > If it is done in 8 cycles, 1000-cycle will be surely a safe value for it.
> > As long as it finished in 8 cycles, it would quit anyway. Why against?
>
> I am not against, I am saying why it was not 200 or 50 or 20 etc. I am saying that write a comment saying this much is sufficient as per specification and so keep 1000/etc as preservative.
I did't mean that. The 'against' is from
"Also add a comment describing this 'against' why cycle = 1000 is selected."
Well, if you insist this extra comment for easy-understand, I'll add them
Thank you.
Nicolin Chen
next prev parent reply other threads:[~2013-08-19 6:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 12:56 [PATCH v6 0/2] Add freescale S/PDIF CPU DAI and machine drivers Nicolin Chen
2013-08-16 12:56 ` Nicolin Chen
2013-08-16 12:56 ` [PATCH v6 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Nicolin Chen
2013-08-16 12:56 ` Nicolin Chen
2013-08-16 18:24 ` Bhushan Bharat-R65777
2013-08-16 18:24 ` Bhushan Bharat-R65777
2013-08-19 3:07 ` Nicolin Chen
2013-08-19 3:07 ` Nicolin Chen
2013-08-19 4:38 ` Bhushan Bharat-R65777
2013-08-19 4:38 ` Bhushan Bharat-R65777
2013-08-19 4:38 ` Bhushan Bharat-R65777
2013-08-19 6:24 ` Nicolin Chen
2013-08-19 6:24 ` Nicolin Chen
2013-08-19 6:31 ` Bhushan Bharat-R65777
2013-08-19 6:31 ` Bhushan Bharat-R65777
2013-08-19 6:31 ` Bhushan Bharat-R65777
2013-08-19 6:44 ` Nicolin Chen [this message]
2013-08-19 6:44 ` Nicolin Chen
2013-08-16 12:56 ` [PATCH v6 2/2] ASoC: fsl: Add S/PDIF machine driver Nicolin Chen
2013-08-16 12:56 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819064440.GA10950@MrMyself \
--to=b42378@freescale.com \
--cc=R65777@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=lars@metafoo.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=rob.herring@calxeda.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=timur@tabi.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.