* [patch] drm/i915: use _safe version of list_for_each
@ 2013-08-19 6:53 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-08-19 6:53 UTC (permalink / raw)
To: Daniel Vetter; +Cc: David Airlie, intel-gfx, dri-devel, kernel-janitors
We sometimes call i915_vma_unbind() inside the loop and that can free
the vma.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static checker stuff. Untested.
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index 9b3b5f8..5249735 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -524,7 +524,7 @@ i915_gem_execbuffer_reserve(struct intel_ring_buffer *ring,
bool *need_relocs)
{
struct drm_i915_gem_object *obj;
- struct i915_vma *vma;
+ struct i915_vma *vma, *n;
struct list_head ordered_vmas;
bool has_fenced_gpu_access = INTEL_INFO(ring->dev)->gen < 4;
int retry;
@@ -572,7 +572,7 @@ i915_gem_execbuffer_reserve(struct intel_ring_buffer *ring,
int ret = 0;
/* Unbind any ill-fitting objects or pin. */
- list_for_each_entry(vma, vmas, exec_list) {
+ list_for_each_entry_safe(vma, n, vmas, exec_list) {
struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
bool need_fence, need_mappable;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] drm/i915: use _safe version of list_for_each
@ 2013-08-19 6:53 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-08-19 6:53 UTC (permalink / raw)
To: Daniel Vetter; +Cc: David Airlie, intel-gfx, dri-devel, kernel-janitors
We sometimes call i915_vma_unbind() inside the loop and that can free
the vma.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static checker stuff. Untested.
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index 9b3b5f8..5249735 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -524,7 +524,7 @@ i915_gem_execbuffer_reserve(struct intel_ring_buffer *ring,
bool *need_relocs)
{
struct drm_i915_gem_object *obj;
- struct i915_vma *vma;
+ struct i915_vma *vma, *n;
struct list_head ordered_vmas;
bool has_fenced_gpu_access = INTEL_INFO(ring->dev)->gen < 4;
int retry;
@@ -572,7 +572,7 @@ i915_gem_execbuffer_reserve(struct intel_ring_buffer *ring,
int ret = 0;
/* Unbind any ill-fitting objects or pin. */
- list_for_each_entry(vma, vmas, exec_list) {
+ list_for_each_entry_safe(vma, n, vmas, exec_list) {
struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
bool need_fence, need_mappable;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] drm/i915: use _safe version of list_for_each
2013-08-19 6:53 ` Dan Carpenter
@ 2013-08-19 7:40 ` Chris Wilson
-1 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2013-08-19 7:40 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Daniel Vetter, intel-gfx, kernel-janitors, dri-devel
On Mon, Aug 19, 2013 at 09:53:23AM +0300, Dan Carpenter wrote:
> We sometimes call i915_vma_unbind() inside the loop and that can free
> the vma.
Oh. That is bad. The vma needs to be pinned here to prevent it being freed as
otherwise we lose track of it during the execbuffer.
Ben?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] drm/i915: use _safe version of list_for_each
@ 2013-08-19 7:40 ` Chris Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2013-08-19 7:40 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Daniel Vetter, intel-gfx, kernel-janitors, dri-devel
On Mon, Aug 19, 2013 at 09:53:23AM +0300, Dan Carpenter wrote:
> We sometimes call i915_vma_unbind() inside the loop and that can free
> the vma.
Oh. That is bad. The vma needs to be pinned here to prevent it being freed as
otherwise we lose track of it during the execbuffer.
Ben?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-19 7:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-19 6:53 [patch] drm/i915: use _safe version of list_for_each Dan Carpenter
2013-08-19 6:53 ` Dan Carpenter
2013-08-19 7:40 ` Chris Wilson
2013-08-19 7:40 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.