From: Felipe Balbi <balbi@ti.com>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: balbi@ti.com, broonie@kernel.org,
spi-devel-general@lists.sourceforge.net, grant.likely@linaro.org,
rnayak@ti.com, linux-omap@vger.kernel.org
Subject: Re: [PATCHv9 1/2] drivers: spi: Add qspi flash controller
Date: Mon, 19 Aug 2013 13:55:01 -0500 [thread overview]
Message-ID: <20130819185501.GL26587@radagast> (raw)
In-Reply-To: <521244DC.9080600@ti.com>
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
Hi,
On Mon, Aug 19, 2013 at 09:46:28PM +0530, Sourav Poddar wrote:
> >>+ } else if (wlen == 32) {
> >if else if else if else if .... this looks like a switch to me. I know
> >someone else commented that switch wasn't the best construct, but to my
> >eyes, switch looks a lot cleaner.
> >
> My previous switch implementation was implemented as a seperate
> function, as a result of which there was the need to pass pointers, other
> variables, then collect it as a double pointer, making things a bit untidy.
>
> What I can do is to convert these portion into switch here itself,
> which will
> make the code a lot more cleaner. ?
perhaps, at least to me it looks cleaner.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: <balbi@ti.com>, <broonie@kernel.org>,
<spi-devel-general@lists.sourceforge.net>,
<grant.likely@linaro.org>, <rnayak@ti.com>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCHv9 1/2] drivers: spi: Add qspi flash controller
Date: Mon, 19 Aug 2013 13:55:01 -0500 [thread overview]
Message-ID: <20130819185501.GL26587@radagast> (raw)
In-Reply-To: <521244DC.9080600@ti.com>
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
Hi,
On Mon, Aug 19, 2013 at 09:46:28PM +0530, Sourav Poddar wrote:
> >>+ } else if (wlen == 32) {
> >if else if else if else if .... this looks like a switch to me. I know
> >someone else commented that switch wasn't the best construct, but to my
> >eyes, switch looks a lot cleaner.
> >
> My previous switch implementation was implemented as a seperate
> function, as a result of which there was the need to pass pointers, other
> variables, then collect it as a double pointer, making things a bit untidy.
>
> What I can do is to convert these portion into switch here itself,
> which will
> make the code a lot more cleaner. ?
perhaps, at least to me it looks cleaner.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-19 18:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-04 8:58 [PATCHv9 0/2] Add ti qspi controller Sourav Poddar
2013-08-04 8:58 ` Sourav Poddar
[not found] ` <1375606690-834-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-08-04 8:58 ` [PATCHv9 1/2] drivers: spi: Add qspi flash controller Sourav Poddar
2013-08-04 8:58 ` Sourav Poddar
2013-08-06 14:05 ` Sourav Poddar
2013-08-06 14:05 ` Sourav Poddar
2013-08-13 15:26 ` Felipe Balbi
2013-08-13 15:26 ` Felipe Balbi
2013-08-19 16:16 ` Sourav Poddar
2013-08-19 16:16 ` Sourav Poddar
2013-08-19 18:55 ` Felipe Balbi [this message]
2013-08-19 18:55 ` Felipe Balbi
2013-08-04 8:58 ` [RFC/PATCH 2/2] driver: spi: Add quad spi read support Sourav Poddar
2013-08-04 8:58 ` Sourav Poddar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819185501.GL26587@radagast \
--to=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=sourav.poddar@ti.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.