All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
	Theodore Ts'o <tytso@mit.edu>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	xfs@oss.sgi.com, Jan Kara <jack@suse.cz>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v3 5/5] ext4: Defer mmap cmtime update until writeback
Date: Tue, 20 Aug 2013 12:38:49 +1000	[thread overview]
Message-ID: <20130820023849.GF6023@dastard> (raw)
In-Reply-To: <d59d6c9790bd3c36b93343ed91be5e0cda7e5f09.1376679411.git.luto@amacapital.net>

On Fri, Aug 16, 2013 at 04:22:12PM -0700, Andy Lutomirski wrote:
> A fancier implementation could probably avoid an extra journal
> transaction by adding a mapping_test_clear_cmtime call in
> ext4_writepages, but this should already be a considerable
> improvement -- we'll start one transaction per writepages call
> instead of one per page.

I'd like to see more than just an ext4 implementation - btrfs and
XFS are the other main filesystems that should behave identically.

Also, it's worthwhile to write a generic xfstest to ensure that they
all update the timestamp appropriately - if its' in xfstests, then
we can basically guarantee that it won't get randomly regressed in
future, and other filesystems can be easily verified as well sa
their implement this.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Jan Kara <jack@suse.cz>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	Christoph Hellwig <hch@infradead.org>,
	Theodore Ts'o <tytso@mit.edu>,
	linux-ext4@vger.kernel.org, Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [PATCH v3 5/5] ext4: Defer mmap cmtime update until writeback
Date: Tue, 20 Aug 2013 12:38:49 +1000	[thread overview]
Message-ID: <20130820023849.GF6023@dastard> (raw)
In-Reply-To: <d59d6c9790bd3c36b93343ed91be5e0cda7e5f09.1376679411.git.luto@amacapital.net>

On Fri, Aug 16, 2013 at 04:22:12PM -0700, Andy Lutomirski wrote:
> A fancier implementation could probably avoid an extra journal
> transaction by adding a mapping_test_clear_cmtime call in
> ext4_writepages, but this should already be a considerable
> improvement -- we'll start one transaction per writepages call
> instead of one per page.

I'd like to see more than just an ext4 implementation - btrfs and
XFS are the other main filesystems that should behave identically.

Also, it's worthwhile to write a generic xfstest to ensure that they
all update the timestamp appropriately - if its' in xfstests, then
we can basically guarantee that it won't get randomly regressed in
future, and other filesystems can be easily verified as well sa
their implement this.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-08-20  2:38 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16 23:22 [PATCH v3 0/5] Rework mtime and ctime updates on mmaped Andy Lutomirski
2013-08-16 23:22 ` Andy Lutomirski
2013-08-16 23:22 ` [PATCH v3 1/5] mm: Track mappings that have been written via ptes Andy Lutomirski
2013-08-16 23:22   ` Andy Lutomirski
2013-08-16 23:22 ` [PATCH v3 2/5] fs: Add inode_update_time_writable Andy Lutomirski
2013-08-16 23:22   ` Andy Lutomirski
2013-08-20  2:28   ` Dave Chinner
2013-08-20  2:28     ` Dave Chinner
2013-08-20  3:20     ` Andy Lutomirski
2013-08-20  3:20       ` Andy Lutomirski
2013-08-20  3:33       ` Dave Chinner
2013-08-20  3:33         ` Dave Chinner
2013-08-20  4:07         ` Andy Lutomirski
2013-08-20  4:07           ` Andy Lutomirski
2013-08-20 16:10           ` Jan Kara
2013-08-20 16:10             ` Jan Kara
2013-08-16 23:22 ` [PATCH v3 3/5] mm: Notify filesystems when it's time to apply a deferred cmtime update Andy Lutomirski
2013-08-16 23:22   ` Andy Lutomirski
2013-08-20  2:36   ` Dave Chinner
2013-08-20  2:36     ` Dave Chinner
2013-08-20  3:28     ` Andy Lutomirski
2013-08-20  3:28       ` Andy Lutomirski
2013-08-20  4:08       ` Dave Chinner
2013-08-20  4:08         ` Dave Chinner
2013-08-20  4:14         ` Andy Lutomirski
2013-08-20  4:14           ` Andy Lutomirski
2013-08-20 16:00           ` Jan Kara
2013-08-20 16:00             ` Jan Kara
2013-08-20 16:42             ` Andy Lutomirski
2013-08-20 16:42               ` Andy Lutomirski
2013-08-20 19:27               ` Andy Lutomirski
2013-08-20 19:27                 ` Andy Lutomirski
2013-08-20 21:48               ` Dave Chinner
2013-08-20 21:48                 ` Dave Chinner
2013-08-20 21:54                 ` Andy Lutomirski
2013-08-20 21:54                   ` Andy Lutomirski
2013-08-20 22:43                   ` Dave Chinner
2013-08-20 22:43                     ` Dave Chinner
2013-08-21  0:47                     ` Andy Lutomirski
2013-08-21  0:47                       ` Andy Lutomirski
2013-08-21  1:33                       ` Dave Chinner
2013-08-21  1:33                         ` Dave Chinner
2013-08-16 23:22 ` [PATCH v3 4/5] mm: Scan for dirty ptes and update cmtime on MS_ASYNC Andy Lutomirski
2013-08-16 23:22   ` Andy Lutomirski
2013-08-16 23:22 ` [PATCH v3 5/5] ext4: Defer mmap cmtime update until writeback Andy Lutomirski
2013-08-16 23:22   ` Andy Lutomirski
2013-08-20  2:38   ` Dave Chinner [this message]
2013-08-20  2:38     ` Dave Chinner
2013-08-20  3:30     ` Andy Lutomirski
2013-08-20  3:30       ` Andy Lutomirski
2013-08-20  4:08       ` Dave Chinner
2013-08-20  4:08         ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130820023849.GF6023@dastard \
    --to=david@fromorbit.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=tim.c.chen@linux.intel.com \
    --cc=tytso@mit.edu \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.