* [PATCH] ARM: OMAP: dma: fix error return code in omap_system_dma_probe()
@ 2013-07-16 12:10 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2013-07-16 12:10 UTC (permalink / raw)
To: tony, linux; +Cc: yongjun_wei, linux-arm-kernel, linux-omap
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
arch/arm/plat-omap/dma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index 4d463ca..0376606 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -2083,6 +2083,7 @@ static int omap_system_dma_probe(struct platform_device *pdev)
dma_irq = platform_get_irq_byname(pdev, irq_name);
if (dma_irq < 0) {
dev_err(&pdev->dev, "failed: request IRQ %d", dma_irq);
+ ret = dma_irq;
goto exit_dma_lch_fail;
}
ret = setup_irq(dma_irq, &omap24xx_dma_irq);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: OMAP: dma: fix error return code in omap_system_dma_probe()
@ 2013-07-16 12:10 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2013-07-16 12:10 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
arch/arm/plat-omap/dma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index 4d463ca..0376606 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -2083,6 +2083,7 @@ static int omap_system_dma_probe(struct platform_device *pdev)
dma_irq = platform_get_irq_byname(pdev, irq_name);
if (dma_irq < 0) {
dev_err(&pdev->dev, "failed: request IRQ %d", dma_irq);
+ ret = dma_irq;
goto exit_dma_lch_fail;
}
ret = setup_irq(dma_irq, &omap24xx_dma_irq);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: OMAP: dma: fix error return code in omap_system_dma_probe()
2013-07-16 12:10 ` Wei Yongjun
@ 2013-08-21 8:08 ` Tony Lindgren
-1 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2013-08-21 8:08 UTC (permalink / raw)
To: Wei Yongjun; +Cc: yongjun_wei, linux-omap, linux, linux-arm-kernel
* Wei Yongjun <weiyj.lk@gmail.com> [130716 05:17]:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
Thanks applying into omap-for-v3.12/fixes-non-critical.
Tony
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> arch/arm/plat-omap/dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
> index 4d463ca..0376606 100644
> --- a/arch/arm/plat-omap/dma.c
> +++ b/arch/arm/plat-omap/dma.c
> @@ -2083,6 +2083,7 @@ static int omap_system_dma_probe(struct platform_device *pdev)
> dma_irq = platform_get_irq_byname(pdev, irq_name);
> if (dma_irq < 0) {
> dev_err(&pdev->dev, "failed: request IRQ %d", dma_irq);
> + ret = dma_irq;
> goto exit_dma_lch_fail;
> }
> ret = setup_irq(dma_irq, &omap24xx_dma_irq);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: OMAP: dma: fix error return code in omap_system_dma_probe()
@ 2013-08-21 8:08 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2013-08-21 8:08 UTC (permalink / raw)
To: linux-arm-kernel
* Wei Yongjun <weiyj.lk@gmail.com> [130716 05:17]:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
Thanks applying into omap-for-v3.12/fixes-non-critical.
Tony
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> arch/arm/plat-omap/dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
> index 4d463ca..0376606 100644
> --- a/arch/arm/plat-omap/dma.c
> +++ b/arch/arm/plat-omap/dma.c
> @@ -2083,6 +2083,7 @@ static int omap_system_dma_probe(struct platform_device *pdev)
> dma_irq = platform_get_irq_byname(pdev, irq_name);
> if (dma_irq < 0) {
> dev_err(&pdev->dev, "failed: request IRQ %d", dma_irq);
> + ret = dma_irq;
> goto exit_dma_lch_fail;
> }
> ret = setup_irq(dma_irq, &omap24xx_dma_irq);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-21 8:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-16 12:10 [PATCH] ARM: OMAP: dma: fix error return code in omap_system_dma_probe() Wei Yongjun
2013-07-16 12:10 ` Wei Yongjun
2013-08-21 8:08 ` Tony Lindgren
2013-08-21 8:08 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.