* [PATCH 1/2] of: add vendor prefix for Mentor Graphics @ 2013-08-20 16:40 Sebastian Andrzej Siewior 2013-08-20 16:40 ` [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding Sebastian Andrzej Siewior 2013-08-20 19:03 ` [PATCH 1/2] of: add vendor prefix for Mentor Graphics Stephen Warren 0 siblings, 2 replies; 7+ messages in thread From: Sebastian Andrzej Siewior @ 2013-08-20 16:40 UTC (permalink / raw) To: devicetree Cc: Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren, Ian Campbell, Lee Jones, Sebastian Andrzej Siewior This prefix is currently used for the musb driver. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 366ce9b..3065e79 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -36,6 +36,7 @@ linux Linux-specific binding lsi LSI Corp. (LSI Logic) marvell Marvell Technology Group Ltd. maxim Maxim Integrated Products +mentor Mentor Graphics mosaixtech Mosaix Technologies, Inc. national National Semiconductor nintendo Nintendo -- 1.8.4.rc2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding 2013-08-20 16:40 [PATCH 1/2] of: add vendor prefix for Mentor Graphics Sebastian Andrzej Siewior @ 2013-08-20 16:40 ` Sebastian Andrzej Siewior 2013-08-21 8:31 ` Lee Jones 2013-08-21 22:49 ` Linus Walleij 2013-08-20 19:03 ` [PATCH 1/2] of: add vendor prefix for Mentor Graphics Stephen Warren 1 sibling, 2 replies; 7+ messages in thread From: Sebastian Andrzej Siewior @ 2013-08-20 16:40 UTC (permalink / raw) To: devicetree Cc: Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren, Ian Campbell, Lee Jones, Sebastian Andrzej Siewior The "mentor,musb" binding isn't documented so I was about to document it. The node is missing a few properties for configuration like "multipoint", "dyn_fifo", "num_eps" or "ram_bits". However I am not sure "missing" is the right word here because some of those informations might be obtained from the chip itself but it is not done (yet). Further the ePARP 2.3.1 says the matching goes from left to right taking the fist match. Right now there is jus a driver for "stericsson,db8500-musb" and none for "mentor,musb". I'm not 100% that it is simply possible to have a generic since even for DMA we have ifdefs in the driver between "generic mentor dma" and "ux500 dma" and I mean within musb and not the dma code. For that reason (that I am not sure a generic musb binding is possible and how its binding / required properties will look like) and the reason that we have here a minor binding without a driver to look at I suggest to remove that binding. If the majority of people prefer to keep this binding I'm curious how the documentation of the binding should look like. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- Documentation/devicetree/bindings/usb/ux500-usb.txt | 2 +- arch/arm/boot/dts/dbx5x0.dtsi | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/ux500-usb.txt b/Documentation/devicetree/bindings/usb/ux500-usb.txt index 330d6ec..439a41c 100644 --- a/Documentation/devicetree/bindings/usb/ux500-usb.txt +++ b/Documentation/devicetree/bindings/usb/ux500-usb.txt @@ -15,7 +15,7 @@ Ux500 MUSB Example: usb_per5@a03e0000 { - compatible = "stericsson,db8500-musb", "mentor,musb"; + compatible = "stericsson,db8500-musb"; reg = <0xa03e0000 0x10000>; interrupts = <0 23 0x4>; interrupt-names = "mc"; diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi index a152945..4522aff8 100644 --- a/arch/arm/boot/dts/dbx5x0.dtsi +++ b/arch/arm/boot/dts/dbx5x0.dtsi @@ -177,8 +177,7 @@ }; usb_per5@a03e0000 { - compatible = "stericsson,db8500-musb", - "mentor,musb"; + compatible = "stericsson,db8500-musb"; reg = <0xa03e0000 0x10000>; interrupts = <0 23 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "mc"; -- 1.8.4.rc2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding 2013-08-20 16:40 ` [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding Sebastian Andrzej Siewior @ 2013-08-21 8:31 ` Lee Jones 2013-08-21 8:41 ` Sebastian Andrzej Siewior 2013-08-21 22:49 ` Linus Walleij 1 sibling, 1 reply; 7+ messages in thread From: Lee Jones @ 2013-08-21 8:31 UTC (permalink / raw) To: Sebastian Andrzej Siewior Cc: devicetree, Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren, Ian Campbell, linus.walleij > The "mentor,musb" binding isn't documented so I was about to document > it. > The node is missing a few properties for configuration like > "multipoint", "dyn_fifo", "num_eps" or "ram_bits". However I am not sure > "missing" is the right word here because some of those informations > might be obtained from the chip itself but it is not done (yet). > Further the ePARP 2.3.1 says the matching goes from left to right taking > the fist match. Right now there is jus a driver for > "stericsson,db8500-musb" and none for "mentor,musb". I'm not 100% that > it is simply possible to have a generic since even for DMA we have > ifdefs in the driver between "generic mentor dma" and "ux500 dma" and I > mean within musb and not the dma code. > > For that reason (that I am not sure a generic musb binding is possible and > how its binding / required properties will look like) and the reason that > we have here a minor binding without a driver to look at I suggest to > remove that binding. > If the majority of people prefer to keep this binding I'm curious how > the documentation of the binding should look like. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > Documentation/devicetree/bindings/usb/ux500-usb.txt | 2 +- > arch/arm/boot/dts/dbx5x0.dtsi | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/ux500-usb.txt b/Documentation/devicetree/bindings/usb/ux500-usb.txt > index 330d6ec..439a41c 100644 > --- a/Documentation/devicetree/bindings/usb/ux500-usb.txt > +++ b/Documentation/devicetree/bindings/usb/ux500-usb.txt > @@ -15,7 +15,7 @@ Ux500 MUSB > Example: > > usb_per5@a03e0000 { > - compatible = "stericsson,db8500-musb", "mentor,musb"; > + compatible = "stericsson,db8500-musb"; > reg = <0xa03e0000 0x10000>; > interrupts = <0 23 0x4>; > interrupt-names = "mc"; > diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi > index a152945..4522aff8 100644 > --- a/arch/arm/boot/dts/dbx5x0.dtsi > +++ b/arch/arm/boot/dts/dbx5x0.dtsi > @@ -177,8 +177,7 @@ > }; > > usb_per5@a03e0000 { > - compatible = "stericsson,db8500-musb", > - "mentor,musb"; > + compatible = "stericsson,db8500-musb"; > reg = <0xa03e0000 0x10000>; > interrupts = <0 23 IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "mc"; > -- > 1.8.4.rc2 > Patch looks fine to me, but you probably want to CC the maintainer. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding 2013-08-21 8:31 ` Lee Jones @ 2013-08-21 8:41 ` Sebastian Andrzej Siewior 2013-08-21 9:59 ` Lee Jones 0 siblings, 1 reply; 7+ messages in thread From: Sebastian Andrzej Siewior @ 2013-08-21 8:41 UTC (permalink / raw) To: Lee Jones Cc: devicetree, Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren, Ian Campbell, linus.walleij On 08/21/2013 10:31 AM, Lee Jones wrote: > Patch looks fine to me, but you probably want to CC the maintainer. Who do you have in mind? Sebastian ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding 2013-08-21 8:41 ` Sebastian Andrzej Siewior @ 2013-08-21 9:59 ` Lee Jones 0 siblings, 0 replies; 7+ messages in thread From: Lee Jones @ 2013-08-21 9:59 UTC (permalink / raw) To: Sebastian Andrzej Siewior Cc: devicetree, Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren, Ian Campbell, linus.walleij On Wed, 21 Aug 2013, Sebastian Andrzej Siewior wrote: > On 08/21/2013 10:31 AM, Lee Jones wrote: > > Patch looks fine to me, but you probably want to CC the maintainer. > > Who do you have in mind? Linus Walleij. I already CC'ed him. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding 2013-08-20 16:40 ` [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding Sebastian Andrzej Siewior 2013-08-21 8:31 ` Lee Jones @ 2013-08-21 22:49 ` Linus Walleij 1 sibling, 0 replies; 7+ messages in thread From: Linus Walleij @ 2013-08-21 22:49 UTC (permalink / raw) To: Sebastian Andrzej Siewior Cc: devicetree@vger.kernel.org, Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren, Ian Campbell, Lee Jones On Tue, Aug 20, 2013 at 6:40 PM, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > The "mentor,musb" binding isn't documented so I was about to document > it. > The node is missing a few properties for configuration like > "multipoint", "dyn_fifo", "num_eps" or "ram_bits". However I am not sure > "missing" is the right word here because some of those informations > might be obtained from the chip itself but it is not done (yet). > Further the ePARP 2.3.1 says the matching goes from left to right taking > the fist match. Right now there is jus a driver for > "stericsson,db8500-musb" and none for "mentor,musb". I'm not 100% that > it is simply possible to have a generic since even for DMA we have > ifdefs in the driver between "generic mentor dma" and "ux500 dma" and I > mean within musb and not the dma code. > > For that reason (that I am not sure a generic musb binding is possible and > how its binding / required properties will look like) and the reason that > we have here a minor binding without a driver to look at I suggest to > remove that binding. > If the majority of people prefer to keep this binding I'm curious how > the documentation of the binding should look like. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Patch applied to my ux500-devicetree branch. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] of: add vendor prefix for Mentor Graphics 2013-08-20 16:40 [PATCH 1/2] of: add vendor prefix for Mentor Graphics Sebastian Andrzej Siewior 2013-08-20 16:40 ` [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding Sebastian Andrzej Siewior @ 2013-08-20 19:03 ` Stephen Warren 1 sibling, 0 replies; 7+ messages in thread From: Stephen Warren @ 2013-08-20 19:03 UTC (permalink / raw) To: Sebastian Andrzej Siewior Cc: devicetree, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Lee Jones On 08/20/2013 10:40 AM, Sebastian Andrzej Siewior wrote: > This prefix is currently used for the musb driver. The series, Acked-by: Stephen Warren <swarren@nvidia.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-08-21 22:49 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-08-20 16:40 [PATCH 1/2] of: add vendor prefix for Mentor Graphics Sebastian Andrzej Siewior 2013-08-20 16:40 ` [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding Sebastian Andrzej Siewior 2013-08-21 8:31 ` Lee Jones 2013-08-21 8:41 ` Sebastian Andrzej Siewior 2013-08-21 9:59 ` Lee Jones 2013-08-21 22:49 ` Linus Walleij 2013-08-20 19:03 ` [PATCH 1/2] of: add vendor prefix for Mentor Graphics Stephen Warren
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.