From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Chris Ball <cjb@laptop.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Christian Daudt <csd@broadcom.com>, Arnd Bergmann <arnd@arndb.de>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] mmc: sdhci-bcm-kona: '|' vs '&' typo
Date: Wed, 21 Aug 2013 09:14:07 +0000 [thread overview]
Message-ID: <20130821091407.GX4713@mwanda> (raw)
In-Reply-To: <52148115.3050703@bfs.de>
On Wed, Aug 21, 2013 at 10:57:57AM +0200, walter harms wrote:
>
>
> Am 21.08.2013 10:24, schrieb Dan Carpenter:
> > The intent was to test if a flag was set. In the current code the
> > conditions are always true.
>
> I guess that it worked before ...
> That leaves the Question: are the tests needed at all ?
It's flagging everything as broken, and I presume that isn't good.
But on the other hand, these changes do occasionally break things
because now a lot of new untested code is used. It really is a good
idea for someone to test this.
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Static checker stuff. Untested.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Chris Ball <cjb@laptop.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Christian Daudt <csd@broadcom.com>, Arnd Bergmann <arnd@arndb.de>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] mmc: sdhci-bcm-kona: '|' vs '&' typo
Date: Wed, 21 Aug 2013 12:14:07 +0300 [thread overview]
Message-ID: <20130821091407.GX4713@mwanda> (raw)
In-Reply-To: <52148115.3050703@bfs.de>
On Wed, Aug 21, 2013 at 10:57:57AM +0200, walter harms wrote:
>
>
> Am 21.08.2013 10:24, schrieb Dan Carpenter:
> > The intent was to test if a flag was set. In the current code the
> > conditions are always true.
>
> I guess that it worked before ...
> That leaves the Question: are the tests needed at all ?
It's flagging everything as broken, and I presume that isn't good.
But on the other hand, these changes do occasionally break things
because now a lot of new untested code is used. It really is a good
idea for someone to test this.
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Static checker stuff. Untested.
regards,
dan carpenter
next prev parent reply other threads:[~2013-08-21 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 8:24 [patch] mmc: sdhci-bcm-kona: '|' vs '&' typo Dan Carpenter
2013-08-21 8:24 ` Dan Carpenter
2013-08-21 8:57 ` walter harms
2013-08-21 8:57 ` walter harms
2013-08-21 9:14 ` Dan Carpenter [this message]
2013-08-21 9:14 ` Dan Carpenter
2013-08-21 14:30 ` Christian Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821091407.GX4713@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=csd@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.