From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: linux-fbdev@vger.kernel.org, linaro-kernel@lists.linaro.org,
dri-devel@lists.freedesktop.org, kyungmin.park@samsung.com,
myungjoo.ham@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] [RFC PATCH v6] dmabuf-sync: Add a buffer synchronization framework
Date: Wed, 21 Aug 2013 14:27:24 +0000 [thread overview]
Message-ID: <20130821142724.GF2593@phenom.dumpdata.com> (raw)
In-Reply-To: <008201ce9e4a$08d1d1a0$1a7574e0$%dae@samsung.com>
> > > +EXPORT_SYMBOL(is_dmabuf_sync_supported);
> >
> > _GPL ?
> >
> > I would also prefix it with 'dmabuf_is_sync_supported' just to make
> > all of the libraries call start with 'dmabuf'
> >
>
> Seems better. Will change it to dmabuf_is_sync_supported, and use
> EXPORT_SYMBOL_GPL.
One thing thought - while I suggest that you use GPL variant
I think you should check who the consumers are. As in, if nvidia
wants to use it it might make their lawyers unhappy - and in turn
means that their engineers won't be able to use these symbols.
So - if there is a strong argument to not have it GPL - then please
say so.
WARNING: multiple messages have this Message-ID (diff)
From: konrad.wilk@oracle.com (Konrad Rzeszutek Wilk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] [RFC PATCH v6] dmabuf-sync: Add a buffer synchronization framework
Date: Wed, 21 Aug 2013 10:27:24 -0400 [thread overview]
Message-ID: <20130821142724.GF2593@phenom.dumpdata.com> (raw)
In-Reply-To: <008201ce9e4a$08d1d1a0$1a7574e0$%dae@samsung.com>
> > > +EXPORT_SYMBOL(is_dmabuf_sync_supported);
> >
> > _GPL ?
> >
> > I would also prefix it with 'dmabuf_is_sync_supported' just to make
> > all of the libraries call start with 'dmabuf'
> >
>
> Seems better. Will change it to dmabuf_is_sync_supported, and use
> EXPORT_SYMBOL_GPL.
One thing thought - while I suggest that you use GPL variant
I think you should check who the consumers are. As in, if nvidia
wants to use it it might make their lawyers unhappy - and in turn
means that their engineers won't be able to use these symbols.
So - if there is a strong argument to not have it GPL - then please
say so.
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: linux-fbdev@vger.kernel.org, linaro-kernel@lists.linaro.org,
dri-devel@lists.freedesktop.org, kyungmin.park@samsung.com,
myungjoo.ham@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] [RFC PATCH v6] dmabuf-sync: Add a buffer synchronization framework
Date: Wed, 21 Aug 2013 10:27:24 -0400 [thread overview]
Message-ID: <20130821142724.GF2593@phenom.dumpdata.com> (raw)
In-Reply-To: <008201ce9e4a$08d1d1a0$1a7574e0$%dae@samsung.com>
> > > +EXPORT_SYMBOL(is_dmabuf_sync_supported);
> >
> > _GPL ?
> >
> > I would also prefix it with 'dmabuf_is_sync_supported' just to make
> > all of the libraries call start with 'dmabuf'
> >
>
> Seems better. Will change it to dmabuf_is_sync_supported, and use
> EXPORT_SYMBOL_GPL.
One thing thought - while I suggest that you use GPL variant
I think you should check who the consumers are. As in, if nvidia
wants to use it it might make their lawyers unhappy - and in turn
means that their engineers won't be able to use these symbols.
So - if there is a strong argument to not have it GPL - then please
say so.
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linaro-kernel@lists.linaro.org,
kyungmin.park@samsung.com, myungjoo.ham@samsung.com
Subject: Re: [PATCH 1/2] [RFC PATCH v6] dmabuf-sync: Add a buffer synchronization framework
Date: Wed, 21 Aug 2013 10:27:24 -0400 [thread overview]
Message-ID: <20130821142724.GF2593@phenom.dumpdata.com> (raw)
In-Reply-To: <008201ce9e4a$08d1d1a0$1a7574e0$%dae@samsung.com>
> > > +EXPORT_SYMBOL(is_dmabuf_sync_supported);
> >
> > _GPL ?
> >
> > I would also prefix it with 'dmabuf_is_sync_supported' just to make
> > all of the libraries call start with 'dmabuf'
> >
>
> Seems better. Will change it to dmabuf_is_sync_supported, and use
> EXPORT_SYMBOL_GPL.
One thing thought - while I suggest that you use GPL variant
I think you should check who the consumers are. As in, if nvidia
wants to use it it might make their lawyers unhappy - and in turn
means that their engineers won't be able to use these symbols.
So - if there is a strong argument to not have it GPL - then please
say so.
next prev parent reply other threads:[~2013-08-21 14:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 9:19 [RFC PATCH v6 0/2] Introduce buffer synchronization framework Inki Dae
2013-08-13 9:19 ` Inki Dae
2013-08-13 9:19 ` Inki Dae
2013-08-13 9:19 ` [PATCH 1/2] [RFC PATCH v6] dmabuf-sync: Add a " Inki Dae
2013-08-13 9:19 ` Inki Dae
2013-08-13 9:19 ` Inki Dae
2013-08-20 19:22 ` Konrad Rzeszutek Wilk
2013-08-20 19:22 ` Konrad Rzeszutek Wilk
2013-08-20 19:22 ` Konrad Rzeszutek Wilk
2013-08-20 19:22 ` Konrad Rzeszutek Wilk
2013-08-21 8:40 ` Inki Dae
2013-08-21 8:40 ` Inki Dae
2013-08-21 8:40 ` Inki Dae
2013-08-21 14:27 ` Konrad Rzeszutek Wilk [this message]
2013-08-21 14:27 ` Konrad Rzeszutek Wilk
2013-08-21 14:27 ` Konrad Rzeszutek Wilk
2013-08-21 14:27 ` Konrad Rzeszutek Wilk
2013-08-13 9:19 ` [PATCH 2/2] [RFC PATCH v2] dma-buf: Add user interfaces for dmabuf sync support Inki Dae
2013-08-13 9:19 ` Inki Dae
2013-08-13 9:19 ` Inki Dae
2013-08-13 12:56 ` [Resend][RFC PATCH v6 0/2] Introduce buffer synchronization framework Inki Dae
2013-08-13 12:56 ` Inki Dae
2013-08-13 12:56 ` Inki Dae
2013-08-13 12:56 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821142724.GF2593@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.