From: Ben Myers <bpm@sgi.com>
To: Richard Weinberger <richard@nod.at>
Cc: elder@kernel.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Register hotcpu notifier after initialization
Date: Thu, 22 Aug 2013 14:11:17 -0500 [thread overview]
Message-ID: <20130822191117.GQ5262@sgi.com> (raw)
In-Reply-To: <20130819222129.GA5262@sgi.com>
On Mon, Aug 19, 2013 at 05:21:29PM -0500, Ben Myers wrote:
> On Mon, Aug 19, 2013 at 10:56:44PM +0200, Richard Weinberger wrote:
> > Currently the code initializizes mp->m_icsb_mutex and other things
> > _after_ register_hotcpu_notifier().
> > As the notifier takes mp->m_icsb_mutex it can happen
> > that it takes the lock before it's initialization.
> >
> > Signed-off-by: Richard Weinberger <richard@nod.at>
>
> Looks good. Thanks Richard.
>
> Reviewed-by: Ben Myers <bpm@sgi.com>
Applied. Thanks Richard.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Ben Myers <bpm@sgi.com>
To: Richard Weinberger <richard@nod.at>
Cc: elder@kernel.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Register hotcpu notifier after initialization
Date: Thu, 22 Aug 2013 14:11:17 -0500 [thread overview]
Message-ID: <20130822191117.GQ5262@sgi.com> (raw)
In-Reply-To: <20130819222129.GA5262@sgi.com>
On Mon, Aug 19, 2013 at 05:21:29PM -0500, Ben Myers wrote:
> On Mon, Aug 19, 2013 at 10:56:44PM +0200, Richard Weinberger wrote:
> > Currently the code initializizes mp->m_icsb_mutex and other things
> > _after_ register_hotcpu_notifier().
> > As the notifier takes mp->m_icsb_mutex it can happen
> > that it takes the lock before it's initialization.
> >
> > Signed-off-by: Richard Weinberger <richard@nod.at>
>
> Looks good. Thanks Richard.
>
> Reviewed-by: Ben Myers <bpm@sgi.com>
Applied. Thanks Richard.
next prev parent reply other threads:[~2013-08-22 19:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 20:56 [PATCH] xfs: Register hotcpu notifier after initialization Richard Weinberger
2013-08-19 20:56 ` Richard Weinberger
2013-08-19 22:21 ` Ben Myers
2013-08-19 22:21 ` Ben Myers
2013-08-22 19:11 ` Ben Myers [this message]
2013-08-22 19:11 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822191117.GQ5262@sgi.com \
--to=bpm@sgi.com \
--cc=elder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.