Re: [meta-fsl-arm-extra][PATCH 1/4] barebox: add a recipe to support mainline 2013.08.0

["Eric Bénard" <eric@eukrea.com>]

Hi Alexandre,

Le Fri, 23 Aug 2013 01:06:14 +0200,
Alexandre Belloni <alexandre.belloni@free-electrons.com> a écrit :

> On 22/08/2013 20:00, Otavio Salvador wrote:
> > On Thu, Aug 22, 2013 at 2:14 PM, Eric Bénard <eric@eukrea.com> wrote:
> >> Hi Alexandre,
> >>
> >> Le Thu, 22 Aug 2013 16:51:14 +0200,
> >> Alexandre Belloni <alexandre.belloni@free-electrons.com> a écrit :
> >>
> >>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >>> ---
> >>>  recipes-bsp/barebox/barebox_2013.08.0.bb | 26 ++++++++++++++++++++++++++
> >>>  1 file changed, 26 insertions(+)
> >>>  create mode 100644 recipes-bsp/barebox/barebox_2013.08.0.bb
> >>>
> >>> diff --git a/recipes-bsp/barebox/barebox_2013.08.0.bb b/recipes-bsp/barebox/barebox_2013.08.0.bb
> >>> new file mode 100644
> >>> index 0000000..2f6118b
> >>> --- /dev/null
> >>> +++ b/recipes-bsp/barebox/barebox_2013.08.0.bb
> >>> @@ -0,0 +1,26 @@
> >>> +require recipes-bsp/barebox/barebox.inc
> >>> +
> >>> +PR = "r1"
> >>> +
> >>> +SRC_URI = "http://barebox.org/download/${PN}-${PV}.tar.bz2"
> >>> +
> >>> +SRC_URI[md5sum] = "a61b97a2fedebc808d4b182c2ca18a0c"
> >>> +SRC_URI[sha256sum] = "d9e46dd3c68b04ab4cbc37135dc34907dbebef393da4b3e54abb203c295c1620"
> >>> +
> >>> +python () {
> >>> +     if not d.getVar("BAREBOX_MACHINE", True):
> >>> +             PN = d.getVar("PN", True)
> >>> +             FILE = os.path.basename(d.getVar("FILE", True))
> >>> +             bb.debug(1, "To build %s, see %s for instructions on \
> >>> +                          setting up your machine config" % (PN, FILE))
> >>> +             raise bb.parse.SkipPackage("BAREBOX_MACHINE is not set in the %s machine configuration." % d.getVar("MACHINE", True))
> >>> +}
> >>> +
> >> if you plan to create a generic barebox recipe and as barebox is using
> >> Kconfig like Linux does, I would recommend to include the defconfig for
> >> your board here as done on the kernel side instead of using the
> >> defconfig which may exist into barebox's mainline sources (that makes
> >> customization easier especially when using SOM).
> >>
> >> If you don't plan do create the generic barebox recipe, that's still on
> >> my todo list but with a very low priority :-)
> > Agreed.
> >
> I'm actually wondering about that. The defconfig included in the barebox
> mainline is perfectly fine. And people wanting to change it will have to
> write a bbappend anyway or am I missing something ?

a bbappend will be needed but in that case the python () which skips the
package if BAREBOX_MACHINE is not set shouldn't go in the default
barebox recipe else every machine using barebox will have to set
BAREBOX_MACHINE and then to hack the defconfig after pre_configure.

Eric