All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/4] gst-plugins-bad: Remove with-plugins from configuration
@ 2013-08-22 22:10 Franklin S. Cooper Jr
  2013-08-22 22:10 ` [PATCH 2/4] sourceipk: Add ability to preserve Git repository Franklin S. Cooper Jr
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Franklin S. Cooper Jr @ 2013-08-22 22:10 UTC (permalink / raw)
  To: meta-arago; +Cc: Franklin S. Cooper Jr

* The with-plugins option restricts gst-plugins-bad from building any plugin
  beyond those specified.
* Remove this option to allow as many plugins as possible to be built.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
 .../gstreamer/gst-plugins-bad_0.10.23.bbappend     |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
index 8ae8050..a13dd54 100644
--- a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
+++ b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
@@ -1,4 +1,4 @@
-PR_append = "-arago3"
+PR_append = "-arago4"
 
 # look for files in this layer first
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
@@ -9,7 +9,7 @@ EXTRA_OECONF += "--disable-rsvg"
 
 # Remove the restriction of which plugins are built. Previously fbdevsink
 # was not built which is needed by the gstreamer demos included in the SDK.
-EXTRA_OECONF := "${@oe_filter_out('--with-plugins=musicbrainz,wavpack,ivorbis,mpegvideoparse','${EXTRA_OECONF}', d)}"
+EXTRA_OECONF := "${@oe_filter_out('--with-plugins=wavpack,mpegvideoparse','${EXTRA_OECONF}', d)}"
 
 SRC_URI += "file://0001-gstfbdevsink-Fix-depth-value-for-GST_VIDEO_CAPS_RGB_.patch"
 
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 2/4] sourceipk: Add ability to preserve Git repository
  2013-08-22 22:10 [PATCH 1/4] gst-plugins-bad: Remove with-plugins from configuration Franklin S. Cooper Jr
@ 2013-08-22 22:10 ` Franklin S. Cooper Jr
  2013-08-23 14:25   ` Maupin, Chase
  2013-08-22 22:10 ` [PATCH 3/4] board-port-labs: Use new SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass Franklin S. Cooper Jr
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 11+ messages in thread
From: Franklin S. Cooper Jr @ 2013-08-22 22:10 UTC (permalink / raw)
  To: meta-arago; +Cc: Franklin S. Cooper Jr

* When a git repository is unpacked the repository located in the WORKDIR is
  cloned from the git repository located in the downloads directory.
* Various references and settings are set within the repo which makes it
  impossible for the git repository packaged by sourceipk to be useable on any
  computer other than the original computer that the sourceipk was created in.
* This patche allows the git repository to be preserved and fixed up to become
  a fully functional portable git repository.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
 meta-arago-distro/classes/sourceipk.bbclass |   34 +++++++++++++++++++++++---
 1 files changed, 30 insertions(+), 4 deletions(-)

diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago-distro/classes/sourceipk.bbclass
index 1844ff3..0f0c633 100644
--- a/meta-arago-distro/classes/sourceipk.bbclass
+++ b/meta-arago-distro/classes/sourceipk.bbclass
@@ -59,17 +59,43 @@ SRCIPK_SECTION ?= "${SECTION}"
 # Default SRCIPK_INCLUDE_EXTRAFILES is to include the extra files
 SRCIPK_INCLUDE_EXTRAFILES ?= "1"
 
+SRCIPK_PRESERVE_GIT ?= "false"
+
 # Remove git repositories before packaging up the sources
-clear_git() {
+adjust_git() {
+
+    orig_dir="$PWD"
 
     cd ${S}
 
     if [ -d ".git" ]
     then
-        rm -rf .git
+
+        # Grab path to cloned local repository
+        old=`git remote -v | grep "(fetch)" | cut -d ' ' -f 1   | cut -c 7- | tr -d ' '`
+
+        if [ -d $old -a "${SRCIPK_PRESERVE_GIT}" = "true" ]
+        then
+            cd $old
+
+            # Grab actual url used to create the repository
+            orig=`git remote -v | grep "(fetch)" | cut -d ' ' -f 1   | cut -c 7- | tr -d ' '`
+
+            cd -
+
+            git remote set-url origin $orig $old
+
+            # Repackage the repository so its a proper clone of the original (remote) git repository
+            git repack -a -d
+            rm .git/objects/info/alternates
+
+        else
+            rm -rf .git
+        fi
+
     fi
 
-    cd -
+    cd $orig_dir
 
 }
 
@@ -97,7 +123,7 @@ sourceipk_do_create_srcipk() {
     if [ ${CREATE_SRCIPK} != "0" ]
     then
 
-        clear_git
+        adjust_git
 
         tmp_dir="${WORKDIR}/sourceipk-tmp"
         srcipk_dir="${WORKDIR}/sourceipk-data"
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 3/4] board-port-labs: Use new SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass
  2013-08-22 22:10 [PATCH 1/4] gst-plugins-bad: Remove with-plugins from configuration Franklin S. Cooper Jr
  2013-08-22 22:10 ` [PATCH 2/4] sourceipk: Add ability to preserve Git repository Franklin S. Cooper Jr
@ 2013-08-22 22:10 ` Franklin S. Cooper Jr
  2013-08-23 14:36   ` Maupin, Chase
  2013-08-22 22:10 ` [PATCH 4/4] packagegroup-arago-tisdk-amsdk-sdk-host: Use new board-port-labs recipe Franklin S. Cooper Jr
  2013-08-23 20:31 ` [PATCH 1/4] gst-plugins-bad: Remove with-plugins from configuration Denys Dmytriyenko
  3 siblings, 1 reply; 11+ messages in thread
From: Franklin S. Cooper Jr @ 2013-08-22 22:10 UTC (permalink / raw)
  To: meta-arago; +Cc: Franklin S. Cooper Jr

* Do to the inability to keep the git repository intact the board port labs
  recipe manually ran git clone which took a very long time every time the
  recipe was built.
* Using the new SRCIPK_PRESERVE_GIT feature in sourceipk.bbclass the
  repositories can now be treated like any other recipe and allow OE to handle
  the cloning and unpacking.
* This will significantly shorten the amount of time required to rebuild this
  recipe.
* Separate board-port-labs recipes into two.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
 meta-arago-distro/classes/sourceipk.bbclass        |    1 -
 .../board-port-labs/board-port-labs-linux_git.bb   |   36 ++++++++++++++++++++
 .../board-port-labs/board-port-labs-u-boot_git.bb  |   36 ++++++++++++++++++++
 .../recipes-tisdk/board-port-labs/files/LICENSE    |   16 +++++++++
 4 files changed, 88 insertions(+), 1 deletions(-)
 create mode 100644 meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
 create mode 100644 meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-u-boot_git.bb
 create mode 100644 meta-arago-distro/recipes-tisdk/board-port-labs/files/LICENSE

diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago-distro/classes/sourceipk.bbclass
index 0f0c633..1ea0577 100644
--- a/meta-arago-distro/classes/sourceipk.bbclass
+++ b/meta-arago-distro/classes/sourceipk.bbclass
@@ -61,7 +61,6 @@ SRCIPK_INCLUDE_EXTRAFILES ?= "1"
 
 SRCIPK_PRESERVE_GIT ?= "false"
 
-# Remove git repositories before packaging up the sources
 adjust_git() {
 
     orig_dir="$PWD"
diff --git a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
new file mode 100644
index 0000000..a105128
--- /dev/null
+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
@@ -0,0 +1,36 @@
+DESCRIPTION = "Git repositories containing sample board port code"
+HOMEPAGE = "https://gitorious.org/sitara-board-port"
+LICENSE = "GPLv2"
+
+LIC_FILES_CHKSUM = "file://../LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"
+
+inherit allarch
+
+CREATE_SRCIPK = "1"
+SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-port-linux"
+SRCIPK_PRESERVE_GIT = "true"
+
+PR = "r0"
+
+BRANCH = "master"
+SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-port-linux.git;protocol=git;branch=${BRANCH} \
+           file://LICENSE"
+
+SRCREV = "${AUTOREV}"
+
+S = "${WORKDIR}/git"
+
+adjust_git_prepend() {
+
+    # Checkout a specific branch instead of a commit that is used by default
+    git checkout ${BRANCH}
+}
+
+do_configure() {
+    :
+}
+
+do_compile() {
+    :
+}
+
diff --git a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-u-boot_git.bb b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-u-boot_git.bb
new file mode 100644
index 0000000..a66eaa4
--- /dev/null
+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-u-boot_git.bb
@@ -0,0 +1,36 @@
+DESCRIPTION = "Git repositories containing sample board port code"
+HOMEPAGE = "https://gitorious.org/sitara-board-port"
+LICENSE = "GPLv2"
+
+LIC_FILES_CHKSUM = "file://../LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"
+
+inherit allarch
+
+CREATE_SRCIPK = "1"
+SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-port-u-boot"
+SRCIPK_PRESERVE_GIT = "true"
+
+PR = "r0"
+
+BRANCH = "master"
+SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-port-uboot.git;protocol=git;branch=${BRANCH} \
+           file://LICENSE"
+
+SRCREV = "${AUTOREV}"
+
+S = "${WORKDIR}/git"
+
+adjust_git_prepend() {
+
+    # Checkout a specific branch instead of a commit that is used by default
+    git checkout ${BRANCH}
+}
+
+do_configure() {
+    :
+}
+
+do_compile() {
+    :
+}
+
diff --git a/meta-arago-distro/recipes-tisdk/board-port-labs/files/LICENSE b/meta-arago-distro/recipes-tisdk/board-port-labs/files/LICENSE
new file mode 100644
index 0000000..738cb23
--- /dev/null
+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/files/LICENSE
@@ -0,0 +1,16 @@
+The trees found within this directory are git trees for the Linux
+kernel and u-boot.  These trees are based on the AM335x part and
+are meant to serve as a reference for general tasks involved in a board
+port.  These trees go along with the training available at:
+
+http://processors.wiki.ti.com/index.php/Sitara_Linux_Training
+
+Inside of each directory is a full git repository.  These repositories
+have tags that make isolating the changes for each functionality easier.
+You can view the tag using the "git tag" command and use "gitk --all"
+to better view the git tree contents.
+
+The individual trees are licensed under the same license as the Linux
+kernel and u-boot sources which is the GPLv2 license. A copy of license
+for the kernel and u-boot can be found in a file called COPYING within
+each of the respective git repositories.
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 4/4] packagegroup-arago-tisdk-amsdk-sdk-host: Use new board-port-labs recipe
  2013-08-22 22:10 [PATCH 1/4] gst-plugins-bad: Remove with-plugins from configuration Franklin S. Cooper Jr
  2013-08-22 22:10 ` [PATCH 2/4] sourceipk: Add ability to preserve Git repository Franklin S. Cooper Jr
  2013-08-22 22:10 ` [PATCH 3/4] board-port-labs: Use new SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass Franklin S. Cooper Jr
@ 2013-08-22 22:10 ` Franklin S. Cooper Jr
  2013-08-23 14:39   ` Maupin, Chase
  2013-08-23 20:31 ` [PATCH 1/4] gst-plugins-bad: Remove with-plugins from configuration Denys Dmytriyenko
  3 siblings, 1 reply; 11+ messages in thread
From: Franklin S. Cooper Jr @ 2013-08-22 22:10 UTC (permalink / raw)
  To: meta-arago; +Cc: Franklin S. Cooper Jr

* Switch from using the old board-port-labs recipe to the new recipes.
* Delete old recipe.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
 .../packagegroup-arago-tisdk-amsdk-sdk-host.bb     |    5 ++-
 .../board-port-labs/board-port-labs/LICENSE        |   16 ----------
 .../board-port-labs/board-port-labs_git.bb         |   32 --------------------
 3 files changed, 3 insertions(+), 50 deletions(-)
 delete mode 100644 meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs/LICENSE
 delete mode 100644 meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs_git.bb

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
index 70f767d..94d8288 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
@@ -1,6 +1,6 @@
 DESCRIPTION = "Task to install additional scripts and applications into the SDK"
 LICENSE = "MIT"
-PR = "r11"
+PR = "r12"
 
 inherit packagegroup
 
@@ -24,7 +24,8 @@ RDEPENDS_${PN} = "\
     ${TOOLS} \
     ti-tisdk-setup \
     ${EXTRA_FILES} \
-    board-port-labs-src \
+    board-port-labs-u-boot-src \
+    board-port-labs-linux-src \
     ti-tisdk-makefile \
     ${U-BOOT_SRC} \
     ${KERNEL_SRC} \
diff --git a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs/LICENSE b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs/LICENSE
deleted file mode 100644
index 738cb23..0000000
--- a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs/LICENSE
+++ /dev/null
@@ -1,16 +0,0 @@
-The trees found within this directory are git trees for the Linux
-kernel and u-boot.  These trees are based on the AM335x part and
-are meant to serve as a reference for general tasks involved in a board
-port.  These trees go along with the training available at:
-
-http://processors.wiki.ti.com/index.php/Sitara_Linux_Training
-
-Inside of each directory is a full git repository.  These repositories
-have tags that make isolating the changes for each functionality easier.
-You can view the tag using the "git tag" command and use "gitk --all"
-to better view the git tree contents.
-
-The individual trees are licensed under the same license as the Linux
-kernel and u-boot sources which is the GPLv2 license. A copy of license
-for the kernel and u-boot can be found in a file called COPYING within
-each of the respective git repositories.
diff --git a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs_git.bb b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs_git.bb
deleted file mode 100644
index b7f7d29..0000000
--- a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs_git.bb
+++ /dev/null
@@ -1,32 +0,0 @@
-DESCRIPTION = "Git repositories containing sample board port code"
-HOMEPAGE = "https://gitorious.org/sitara-board-port"
-LICENSE = "GPLv2"
-DEPENDS += "git-native"
-
-SRC_URI = "file://LICENSE"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"
-
-inherit allarch
-
-CREATE_SRCIPK = "1"
-SRCIPK_INSTALL_DIR = "board-support/board-port-labs"
-
-PR = "r5"
-
-REPOS ?= "git://gitorious.org/sitara-board-port/sitara-board-port-linux.git \
-          git://gitorious.org/sitara-board-port/sitara-board-port-uboot.git \
-         "
-
-S = "${WORKDIR}"
-
-# Checkout the REPOS before the do_patch task so that it will be done prior
-# to the srcipk being made.
-do_repos_checkout() {
-    cd ${S}
-    for r in ${REPOS}
-    do
-        git clone $r
-    done
-}
-
-addtask repos_checkout after do_fetch before do_patch
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/4] sourceipk: Add ability to preserve Git repository
  2013-08-22 22:10 ` [PATCH 2/4] sourceipk: Add ability to preserve Git repository Franklin S. Cooper Jr
@ 2013-08-23 14:25   ` Maupin, Chase
  0 siblings, 0 replies; 11+ messages in thread
From: Maupin, Chase @ 2013-08-23 14:25 UTC (permalink / raw)
  To: Cooper Jr., Franklin, meta-arago@arago-project.org

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>Sent: Thursday, August 22, 2013 5:11 PM
>To: meta-arago@arago-project.org
>Cc: Cooper Jr., Franklin
>Subject: [meta-arago] [PATCH 2/4] sourceipk: Add ability to
>preserve Git repository
>
>* When a git repository is unpacked the repository located in the
>WORKDIR is
>  cloned from the git repository located in the downloads
>directory.
>* Various references and settings are set within the repo which
>makes it
>  impossible for the git repository packaged by sourceipk to be
>useable on any
>  computer other than the original computer that the sourceipk was
>created in.
>* This patche allows the git repository to be preserved and fixed
>up to become
>  a fully functional portable git repository.

Small typo "patche -> patch"

>
>Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>---
> meta-arago-distro/classes/sourceipk.bbclass |   34
>+++++++++++++++++++++++---
> 1 files changed, 30 insertions(+), 4 deletions(-)
>
>diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-
>arago-distro/classes/sourceipk.bbclass
>index 1844ff3..0f0c633 100644
>--- a/meta-arago-distro/classes/sourceipk.bbclass
>+++ b/meta-arago-distro/classes/sourceipk.bbclass
>@@ -59,17 +59,43 @@ SRCIPK_SECTION ?= "${SECTION}"
> # Default SRCIPK_INCLUDE_EXTRAFILES is to include the extra files
> SRCIPK_INCLUDE_EXTRAFILES ?= "1"
>
>+SRCIPK_PRESERVE_GIT ?= "false"
>+
> # Remove git repositories before packaging up the sources
>-clear_git() {
>+adjust_git() {
>+
>+    orig_dir="$PWD"
>
>     cd ${S}
>
>     if [ -d ".git" ]
>     then
>-        rm -rf .git
>+
>+        # Grab path to cloned local repository
>+        old=`git remote -v | grep "(fetch)" | cut -d ' ' -f 1   |
>cut -c 7- | tr -d ' '`
>+
>+        if [ -d $old -a "${SRCIPK_PRESERVE_GIT}" = "true" ]
>+        then
>+            cd $old
>+
>+            # Grab actual url used to create the repository
>+            orig=`git remote -v | grep "(fetch)" | cut -d ' ' -f
>1   | cut -c 7- | tr -d ' '`
>+
>+            cd -
>+
>+            git remote set-url origin $orig $old
>+
>+            # Repackage the repository so its a proper clone of
>the original (remote) git repository
>+            git repack -a -d
>+            rm .git/objects/info/alternates
>+
>+        else
>+            rm -rf .git
>+        fi
>+
>     fi
>
>-    cd -
>+    cd $orig_dir
>
> }
>
>@@ -97,7 +123,7 @@ sourceipk_do_create_srcipk() {
>     if [ ${CREATE_SRCIPK} != "0" ]
>     then
>
>-        clear_git
>+        adjust_git
>
>         tmp_dir="${WORKDIR}/sourceipk-tmp"
>         srcipk_dir="${WORKDIR}/sourceipk-data"
>--
>1.7.0.4
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 3/4] board-port-labs: Use new SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass
  2013-08-22 22:10 ` [PATCH 3/4] board-port-labs: Use new SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass Franklin S. Cooper Jr
@ 2013-08-23 14:36   ` Maupin, Chase
  2013-08-23 15:04     ` Cooper Jr., Franklin
  2013-08-23 15:16     ` Tom Rini
  0 siblings, 2 replies; 11+ messages in thread
From: Maupin, Chase @ 2013-08-23 14:36 UTC (permalink / raw)
  To: Cooper Jr., Franklin, meta-arago@arago-project.org, Rini, Tom

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>Sent: Thursday, August 22, 2013 5:11 PM
>To: meta-arago@arago-project.org
>Cc: Cooper Jr., Franklin
>Subject: [meta-arago] [PATCH 3/4] board-port-labs: Use new
>SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass
>
>* Do to the inability to keep the git repository intact the board
>port labs
>  recipe manually ran git clone which took a very long time every
>time the
>  recipe was built.
>* Using the new SRCIPK_PRESERVE_GIT feature in sourceipk.bbclass
>the
>  repositories can now be treated like any other recipe and allow
>OE to handle
>  the cloning and unpacking.
>* This will significantly shorten the amount of time required to
>rebuild this
>  recipe.
>* Separate board-port-labs recipes into two.
>
>Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>---
> meta-arago-distro/classes/sourceipk.bbclass        |    1 -
> .../board-port-labs/board-port-labs-linux_git.bb   |   36
>++++++++++++++++++++
> .../board-port-labs/board-port-labs-u-boot_git.bb  |   36
>++++++++++++++++++++
> .../recipes-tisdk/board-port-labs/files/LICENSE    |   16
>+++++++++
> 4 files changed, 88 insertions(+), 1 deletions(-)
> create mode 100644 meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs-linux_git.bb
> create mode 100644 meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs-u-boot_git.bb
> create mode 100644 meta-arago-distro/recipes-tisdk/board-port-
>labs/files/LICENSE
>
>diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-
>arago-distro/classes/sourceipk.bbclass
>index 0f0c633..1ea0577 100644
>--- a/meta-arago-distro/classes/sourceipk.bbclass
>+++ b/meta-arago-distro/classes/sourceipk.bbclass
>@@ -61,7 +61,6 @@ SRCIPK_INCLUDE_EXTRAFILES ?= "1"
>
> SRCIPK_PRESERVE_GIT ?= "false"
>
>-# Remove git repositories before packaging up the sources
> adjust_git() {

This hunk should be part of the previous patch.

>
>     orig_dir="$PWD"
>diff --git a/meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs-linux_git.bb b/meta-arago-distro/recipes-
>tisdk/board-port-labs/board-port-labs-linux_git.bb
>new file mode 100644
>index 0000000..a105128
>--- /dev/null
>+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-
>labs-linux_git.bb
>@@ -0,0 +1,36 @@
>+DESCRIPTION = "Git repositories containing sample board port
>code"
>+HOMEPAGE = "https://gitorious.org/sitara-board-port"
>+LICENSE = "GPLv2"
>+
>+LIC_FILES_CHKSUM =
>"file://../LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"

Why not point to the COPYING file in the kernel sources?

>+
>+inherit allarch
>+
>+CREATE_SRCIPK = "1"
>+SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-
>port-linux"
>+SRCIPK_PRESERVE_GIT = "true"
>+
>+PR = "r0"
>+
>+BRANCH = "master"
>+SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-
>port-linux.git;protocol=git;branch=${BRANCH} \
>+           file://LICENSE"
>+
>+SRCREV = "${AUTOREV}"
>+
>+S = "${WORKDIR}/git"
>+
>+adjust_git_prepend() {
>+
>+    # Checkout a specific branch instead of a commit that is used
>by default
>+    git checkout ${BRANCH}
>+}

Any reason this couldn't actually be part of the adjust_git function by default?  If a BRANCH is defined do this?

>+
>+do_configure() {
>+    :
>+}
>+
>+do_compile() {
>+    :
>+}
>+
>diff --git a/meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs-u-boot_git.bb b/meta-arago-distro/recipes-
>tisdk/board-port-labs/board-port-labs-u-boot_git.bb
>new file mode 100644
>index 0000000..a66eaa4
>--- /dev/null
>+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-
>labs-u-boot_git.bb
>@@ -0,0 +1,36 @@
>+DESCRIPTION = "Git repositories containing sample board port
>code"
>+HOMEPAGE = "https://gitorious.org/sitara-board-port"
>+LICENSE = "GPLv2"

U-Boot license in the base recipes are GPLv2+ so this probably needs to match.

>+
>+LIC_FILES_CHKSUM =
>"file://../LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"

Why not use the file in the sources at Licenses/gpl-2.0.txt?

Tom, with all the licenses in that directory would you stay u-boot is still GPLv2+?  It seems those other licenses are for the stand alone apps, but for source distribution should this license be updated to include the other licenses?

>+
>+inherit allarch
>+
>+CREATE_SRCIPK = "1"
>+SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-
>port-u-boot"
>+SRCIPK_PRESERVE_GIT = "true"
>+
>+PR = "r0"
>+
>+BRANCH = "master"
>+SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-
>port-uboot.git;protocol=git;branch=${BRANCH} \
>+           file://LICENSE"
>+
>+SRCREV = "${AUTOREV}"
>+
>+S = "${WORKDIR}/git"
>+
>+adjust_git_prepend() {
>+
>+    # Checkout a specific branch instead of a commit that is used
>by default
>+    git checkout ${BRANCH}
>+}

Same comment as the kernel

>+
>+do_configure() {
>+    :
>+}
>+
>+do_compile() {
>+    :
>+}
>+
>diff --git a/meta-arago-distro/recipes-tisdk/board-port-
>labs/files/LICENSE b/meta-arago-distro/recipes-tisdk/board-port-
>labs/files/LICENSE
>new file mode 100644
>index 0000000..738cb23
>--- /dev/null
>+++ b/meta-arago-distro/recipes-tisdk/board-port-
>labs/files/LICENSE
>@@ -0,0 +1,16 @@
>+The trees found within this directory are git trees for the Linux
>+kernel and u-boot.  These trees are based on the AM335x part and
>+are meant to serve as a reference for general tasks involved in a
>board
>+port.  These trees go along with the training available at:
>+
>+http://processors.wiki.ti.com/index.php/Sitara_Linux_Training
>+
>+Inside of each directory is a full git repository.  These
>repositories
>+have tags that make isolating the changes for each functionality
>easier.
>+You can view the tag using the "git tag" command and use "gitk --
>all"
>+to better view the git tree contents.
>+
>+The individual trees are licensed under the same license as the
>Linux
>+kernel and u-boot sources which is the GPLv2 license. A copy of
>license
>+for the kernel and u-boot can be found in a file called COPYING
>within
>+each of the respective git repositories.

U-boot doesn't have COPYING.

>--
>1.7.0.4
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 4/4] packagegroup-arago-tisdk-amsdk-sdk-host: Use new board-port-labs recipe
  2013-08-22 22:10 ` [PATCH 4/4] packagegroup-arago-tisdk-amsdk-sdk-host: Use new board-port-labs recipe Franklin S. Cooper Jr
@ 2013-08-23 14:39   ` Maupin, Chase
  0 siblings, 0 replies; 11+ messages in thread
From: Maupin, Chase @ 2013-08-23 14:39 UTC (permalink / raw)
  To: Cooper Jr., Franklin, meta-arago@arago-project.org

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>Sent: Thursday, August 22, 2013 5:11 PM
>To: meta-arago@arago-project.org
>Cc: Cooper Jr., Franklin
>Subject: [meta-arago] [PATCH 4/4] packagegroup-arago-tisdk-amsdk-
>sdk-host: Use new board-port-labs recipe
>
>* Switch from using the old board-port-labs recipe to the new
>recipes.
>* Delete old recipe.
>
>Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>---
> .../packagegroup-arago-tisdk-amsdk-sdk-host.bb     |    5 ++-
> .../board-port-labs/board-port-labs/LICENSE        |   16 -------
>---
> .../board-port-labs/board-port-labs_git.bb         |   32 -------


I would have split this into two patches.  One to update which recipe to use in the package group and one to remove the old recipe.  That way if someone ever wanted to resurrect the old recipe they can do that easier.

>-------------
> 3 files changed, 3 insertions(+), 50 deletions(-)
> delete mode 100644 meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs/LICENSE
> delete mode 100644 meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs_git.bb
>
>diff --git a/meta-arago-distro/recipes-
>core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
>b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
>tisdk-amsdk-sdk-host.bb
>index 70f767d..94d8288 100644
>--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
>arago-tisdk-amsdk-sdk-host.bb
>+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
>arago-tisdk-amsdk-sdk-host.bb
>@@ -1,6 +1,6 @@
> DESCRIPTION = "Task to install additional scripts and
>applications into the SDK"
> LICENSE = "MIT"
>-PR = "r11"
>+PR = "r12"
>
> inherit packagegroup
>
>@@ -24,7 +24,8 @@ RDEPENDS_${PN} = "\
>     ${TOOLS} \
>     ti-tisdk-setup \
>     ${EXTRA_FILES} \
>-    board-port-labs-src \
>+    board-port-labs-u-boot-src \
>+    board-port-labs-linux-src \
>     ti-tisdk-makefile \
>     ${U-BOOT_SRC} \
>     ${KERNEL_SRC} \
>diff --git a/meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs/LICENSE b/meta-arago-distro/recipes-
>tisdk/board-port-labs/board-port-labs/LICENSE
>deleted file mode 100644
>index 738cb23..0000000
>--- a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-
>labs/LICENSE
>+++ /dev/null
>@@ -1,16 +0,0 @@
>-The trees found within this directory are git trees for the Linux
>-kernel and u-boot.  These trees are based on the AM335x part and
>-are meant to serve as a reference for general tasks involved in a
>board
>-port.  These trees go along with the training available at:
>-
>-http://processors.wiki.ti.com/index.php/Sitara_Linux_Training
>-
>-Inside of each directory is a full git repository.  These
>repositories
>-have tags that make isolating the changes for each functionality
>easier.
>-You can view the tag using the "git tag" command and use "gitk --
>all"
>-to better view the git tree contents.
>-
>-The individual trees are licensed under the same license as the
>Linux
>-kernel and u-boot sources which is the GPLv2 license. A copy of
>license
>-for the kernel and u-boot can be found in a file called COPYING
>within
>-each of the respective git repositories.
>diff --git a/meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs_git.bb b/meta-arago-distro/recipes-
>tisdk/board-port-labs/board-port-labs_git.bb
>deleted file mode 100644
>index b7f7d29..0000000
>--- a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-
>labs_git.bb
>+++ /dev/null
>@@ -1,32 +0,0 @@
>-DESCRIPTION = "Git repositories containing sample board port
>code"
>-HOMEPAGE = "https://gitorious.org/sitara-board-port"
>-LICENSE = "GPLv2"
>-DEPENDS += "git-native"
>-
>-SRC_URI = "file://LICENSE"
>-LIC_FILES_CHKSUM =
>"file://LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"
>-
>-inherit allarch
>-
>-CREATE_SRCIPK = "1"
>-SRCIPK_INSTALL_DIR = "board-support/board-port-labs"
>-
>-PR = "r5"
>-
>-REPOS ?= "git://gitorious.org/sitara-board-port/sitara-board-
>port-linux.git \
>-          git://gitorious.org/sitara-board-port/sitara-board-
>port-uboot.git \
>-         "
>-
>-S = "${WORKDIR}"
>-
>-# Checkout the REPOS before the do_patch task so that it will be
>done prior
>-# to the srcipk being made.
>-do_repos_checkout() {
>-    cd ${S}
>-    for r in ${REPOS}
>-    do
>-        git clone $r
>-    done
>-}
>-
>-addtask repos_checkout after do_fetch before do_patch
>--
>1.7.0.4
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 3/4] board-port-labs: Use new SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass
  2013-08-23 14:36   ` Maupin, Chase
@ 2013-08-23 15:04     ` Cooper Jr., Franklin
  2013-08-23 15:25       ` Maupin, Chase
  2013-08-23 15:16     ` Tom Rini
  1 sibling, 1 reply; 11+ messages in thread
From: Cooper Jr., Franklin @ 2013-08-23 15:04 UTC (permalink / raw)
  To: Maupin, Chase, meta-arago@arago-project.org, Rini, Tom



> -----Original Message-----
> From: Maupin, Chase
> Sent: Friday, August 23, 2013 9:36 AM
> To: Cooper Jr., Franklin; meta-arago@arago-project.org; Rini, Tom
> Subject: RE: [meta-arago] [PATCH 3/4] board-port-labs: Use new
> SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass
> 
> >-----Original Message-----
> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
> >Sent: Thursday, August 22, 2013 5:11 PM
> >To: meta-arago@arago-project.org
> >Cc: Cooper Jr., Franklin
> >Subject: [meta-arago] [PATCH 3/4] board-port-labs: Use new
> >SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass
> >
> >* Do to the inability to keep the git repository intact the board port
> >labs
> >  recipe manually ran git clone which took a very long time every time
> >the
> >  recipe was built.
> >* Using the new SRCIPK_PRESERVE_GIT feature in sourceipk.bbclass the
> >  repositories can now be treated like any other recipe and allow OE to
> >handle
> >  the cloning and unpacking.
> >* This will significantly shorten the amount of time required to
> >rebuild this
> >  recipe.
> >* Separate board-port-labs recipes into two.
> >
> >Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> >---
> > meta-arago-distro/classes/sourceipk.bbclass        |    1 -
> > .../board-port-labs/board-port-labs-linux_git.bb   |   36
> >++++++++++++++++++++
> > .../board-port-labs/board-port-labs-u-boot_git.bb  |   36
> >++++++++++++++++++++
> > .../recipes-tisdk/board-port-labs/files/LICENSE    |   16
> >+++++++++
> > 4 files changed, 88 insertions(+), 1 deletions(-)  create mode 100644
> >meta-arago-distro/recipes-tisdk/board-port-
> >labs/board-port-labs-linux_git.bb
> > create mode 100644 meta-arago-distro/recipes-tisdk/board-port-
> >labs/board-port-labs-u-boot_git.bb
> > create mode 100644 meta-arago-distro/recipes-tisdk/board-port-
> >labs/files/LICENSE
> >
> >diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-
> >arago-distro/classes/sourceipk.bbclass
> >index 0f0c633..1ea0577 100644
> >--- a/meta-arago-distro/classes/sourceipk.bbclass
> >+++ b/meta-arago-distro/classes/sourceipk.bbclass
> >@@ -61,7 +61,6 @@ SRCIPK_INCLUDE_EXTRAFILES ?= "1"
> >
> > SRCIPK_PRESERVE_GIT ?= "false"
> >
> >-# Remove git repositories before packaging up the sources
> > adjust_git() {
> 
> This hunk should be part of the previous patch.
> 
> >
> >     orig_dir="$PWD"
> >diff --git a/meta-arago-distro/recipes-tisdk/board-port-
> >labs/board-port-labs-linux_git.bb b/meta-arago-distro/recipes-
> >tisdk/board-port-labs/board-port-labs-linux_git.bb
> >new file mode 100644
> >index 0000000..a105128
> >--- /dev/null
> >+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-
> >labs-linux_git.bb
> >@@ -0,0 +1,36 @@
> >+DESCRIPTION = "Git repositories containing sample board port
> >code"
> >+HOMEPAGE = "https://gitorious.org/sitara-board-port"
> >+LICENSE = "GPLv2"
> >+
> >+LIC_FILES_CHKSUM =
> >"file://../LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"
> 
> Why not point to the COPYING file in the kernel sources?
[Franklin] I don't know why we didn't do it in the first place now that you mention it. I can use the license from both the kernel and u-boot sources.
> 
> >+
> >+inherit allarch
> >+
> >+CREATE_SRCIPK = "1"
> >+SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-
> >port-linux"
> >+SRCIPK_PRESERVE_GIT = "true"
> >+
> >+PR = "r0"
> >+
> >+BRANCH = "master"
> >+SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-
> >port-linux.git;protocol=git;branch=${BRANCH} \
> >+           file://LICENSE"
> >+
> >+SRCREV = "${AUTOREV}"
> >+
> >+S = "${WORKDIR}/git"
> >+
> >+adjust_git_prepend() {
> >+
> >+    # Checkout a specific branch instead of a commit that is used
> >by default
> >+    git checkout ${BRANCH}
> >+}
> 
> Any reason this couldn't actually be part of the adjust_git function by default?  If
> a BRANCH is defined do this?
[Franklin] So the branch option is weird. Bitbake doesn't checkout a branch it does a checkout of a commit id. So I don't understand the point of the branch variable since a commit id (SRC_REV) can come from multiple branches. I assume that specifying branch is only useful if you use AUTOREV. 

For board port labs assumptions can be made since what I really want is the latest commit in a branch so doing a checkout of master works well. Majority of recipes want a specific commit and not the HEAD of a branch so doing it by default can cause problems.


> 
> >+
> >+do_configure() {
> >+    :
> >+}
> >+
> >+do_compile() {
> >+    :
> >+}
> >+
> >diff --git a/meta-arago-distro/recipes-tisdk/board-port-
> >labs/board-port-labs-u-boot_git.bb b/meta-arago-distro/recipes-
> >tisdk/board-port-labs/board-port-labs-u-boot_git.bb
> >new file mode 100644
> >index 0000000..a66eaa4
> >--- /dev/null
> >+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-
> >labs-u-boot_git.bb
> >@@ -0,0 +1,36 @@
> >+DESCRIPTION = "Git repositories containing sample board port
> >code"
> >+HOMEPAGE = "https://gitorious.org/sitara-board-port"
> >+LICENSE = "GPLv2"
> 
> U-Boot license in the base recipes are GPLv2+ so this probably needs to match.
> 
> >+
> >+LIC_FILES_CHKSUM =
> >"file://../LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"
> 
> Why not use the file in the sources at Licenses/gpl-2.0.txt?
> 
> Tom, with all the licenses in that directory would you stay u-boot is still GPLv2+?
> It seems those other licenses are for the stand alone apps, but for source
> distribution should this license be updated to include the other licenses?
> 
> >+
> >+inherit allarch
> >+
> >+CREATE_SRCIPK = "1"
> >+SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-
> >port-u-boot"
> >+SRCIPK_PRESERVE_GIT = "true"
> >+
> >+PR = "r0"
> >+
> >+BRANCH = "master"
> >+SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-
> >port-uboot.git;protocol=git;branch=${BRANCH} \
> >+           file://LICENSE"
> >+
> >+SRCREV = "${AUTOREV}"
> >+
> >+S = "${WORKDIR}/git"
> >+
> >+adjust_git_prepend() {
> >+
> >+    # Checkout a specific branch instead of a commit that is used
> >by default
> >+    git checkout ${BRANCH}
> >+}
> 
> Same comment as the kernel
> 
> >+
> >+do_configure() {
> >+    :
> >+}
> >+
> >+do_compile() {
> >+    :
> >+}
> >+
> >diff --git a/meta-arago-distro/recipes-tisdk/board-port-
> >labs/files/LICENSE b/meta-arago-distro/recipes-tisdk/board-port-
> >labs/files/LICENSE
> >new file mode 100644
> >index 0000000..738cb23
> >--- /dev/null
> >+++ b/meta-arago-distro/recipes-tisdk/board-port-
> >labs/files/LICENSE
> >@@ -0,0 +1,16 @@
> >+The trees found within this directory are git trees for the Linux
> >+kernel and u-boot.  These trees are based on the AM335x part and are
> >+meant to serve as a reference for general tasks involved in a
> >board
> >+port.  These trees go along with the training available at:
> >+
> >+http://processors.wiki.ti.com/index.php/Sitara_Linux_Training
> >+
> >+Inside of each directory is a full git repository.  These
> >repositories
> >+have tags that make isolating the changes for each functionality
> >easier.
> >+You can view the tag using the "git tag" command and use "gitk --
> >all"
> >+to better view the git tree contents.
> >+
> >+The individual trees are licensed under the same license as the
> >Linux
> >+kernel and u-boot sources which is the GPLv2 license. A copy of
> >license
> >+for the kernel and u-boot can be found in a file called COPYING
> >within
> >+each of the respective git repositories.
> 
> U-boot doesn't have COPYING.
> 
> >--
> >1.7.0.4
> >
> >_______________________________________________
> >meta-arago mailing list
> >meta-arago@arago-project.org
> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 3/4] board-port-labs: Use new SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass
  2013-08-23 14:36   ` Maupin, Chase
  2013-08-23 15:04     ` Cooper Jr., Franklin
@ 2013-08-23 15:16     ` Tom Rini
  1 sibling, 0 replies; 11+ messages in thread
From: Tom Rini @ 2013-08-23 15:16 UTC (permalink / raw)
  To: Maupin, Chase; +Cc: meta-arago@arago-project.org, Cooper Jr., Franklin

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/23/2013 10:36 AM, Maupin, Chase wrote:
>> -----Original Message----- From: 
>> meta-arago-bounces@arago-project.org [mailto:meta-arago- 
>> bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin 
>> Sent: Thursday, August 22, 2013 5:11 PM To: 
>> meta-arago@arago-project.org Cc: Cooper Jr., Franklin Subject: 
>> [meta-arago] [PATCH 3/4] board-port-labs: Use new 
>> SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass
[snip]
>> +++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-
>>  labs-u-boot_git.bb @@ -0,0 +1,36 @@ +DESCRIPTION = "Git 
>> repositories containing sample board port code" +HOMEPAGE = 
>> "https://gitorious.org/sitara-board-port" +LICENSE = "GPLv2"
> 
> U-Boot license in the base recipes are GPLv2+ so this probably 
> needs to match.
> 
>> + +LIC_FILES_CHKSUM = 
>> "file://../LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"
> 
> Why not use the file in the sources at Licenses/gpl-2.0.txt?
> 
> Tom, with all the licenses in that directory would you stay u-boot 
> is still GPLv2+?  It seems those other licenses are for the stand 
> alone apps, but for source distribution should this license be 
> updated to include the other licenses?

So, with the change in how we've noted licensing, from boiler plates
in every file and a top-level LICENSE file to having SPDX tags in
every file, we haven't changed the terms (modulo a few cases of
correcting GPLv2+ files to GPLv2) of the project.  We have however
made it clearer where future problems may lie.  We are still GPLv2+,
however all of the kernel code we have that is GPLv2 would make a
future license change harder.

In sum, yes, we're GPLv2+ and Licenses/gpl-2.0.txt is fine to point at
since it says "or later" in it.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSF3zDAAoJENk4IS6UOR1WlbgP/A8j97ylSD93oF/g31CqN9JA
PrtU80fJTpsSiCRt8JyGCAekfeP8/ZeoCnWfrpa4F6ARTPv2q2kgJQ9cqmBKYrIm
HNUOEGC6iMSaEmAP0LDbc9KPGkevvI5eyzSvUwbIMX2OiL87hHnuhCfAnAqPfyDK
sCGDju1PK72R7E1FsZjVdxJylx/Z81FWGas6+KlOL4Cj9QLvVqkKBrzloFquJGDe
g1nqZgv20qOQiWnR8l2CY8H6g7tEUBf6v1oSfOkyU7fKJcl8AL3wAAG00/kqhXfj
/kUmwo+uAGVSd2X0z6vKKgRXDI2iOzzycJ93CfgiTA2enCTkyjRMCQU/mrp47pdD
UD8r97GRipPboxoFGJAbfZOKVV24CWB0mU5aL9bfvDiFyhit6RatZYUajO7edgTK
QNjh2PIRMN2Jx1MXD4qhg47buOU4jY4Drmk5NLo/f4ykippW6Kw5jC4ZUuaQbCqe
aFp1oj/NK6v8swN7SYy+Nq362Xazsit1BJR0g86/Wdn6g91AyEfOIdNQvOpbGrON
1T6MbCFK7Pu3YjsfvgOVfFO2JTEnGsdJzHPPci8FAfDfnJO8+wobH9Gu6AqASTjO
wuVVbaGGQYTDQx2AndNa8usej7WhlPkoyMI0n4OD5EcT2Tz55eGhCzN7VfMo3ByB
vbMoTUYcyPuO53GivSPU
=icLI
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 3/4] board-port-labs: Use new SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass
  2013-08-23 15:04     ` Cooper Jr., Franklin
@ 2013-08-23 15:25       ` Maupin, Chase
  0 siblings, 0 replies; 11+ messages in thread
From: Maupin, Chase @ 2013-08-23 15:25 UTC (permalink / raw)
  To: Cooper Jr., Franklin, meta-arago@arago-project.org, Rini, Tom

>-----Original Message-----
>From: Cooper Jr., Franklin
>Sent: Friday, August 23, 2013 10:05 AM
>To: Maupin, Chase; meta-arago@arago-project.org; Rini, Tom
>Subject: RE: [meta-arago] [PATCH 3/4] board-port-labs: Use new
>SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass
>
>
>
>> -----Original Message-----
>> From: Maupin, Chase
>> Sent: Friday, August 23, 2013 9:36 AM
>> To: Cooper Jr., Franklin; meta-arago@arago-project.org; Rini,
>Tom
>> Subject: RE: [meta-arago] [PATCH 3/4] board-port-labs: Use new
>> SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass
>>
>> >-----Original Message-----
>> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>> >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>> >Sent: Thursday, August 22, 2013 5:11 PM
>> >To: meta-arago@arago-project.org
>> >Cc: Cooper Jr., Franklin
>> >Subject: [meta-arago] [PATCH 3/4] board-port-labs: Use new
>> >SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass
>> >
>> >* Do to the inability to keep the git repository intact the
>board port
>> >labs
>> >  recipe manually ran git clone which took a very long time
>every time
>> >the
>> >  recipe was built.
>> >* Using the new SRCIPK_PRESERVE_GIT feature in
>sourceipk.bbclass the
>> >  repositories can now be treated like any other recipe and
>allow OE to
>> >handle
>> >  the cloning and unpacking.
>> >* This will significantly shorten the amount of time required
>to
>> >rebuild this
>> >  recipe.
>> >* Separate board-port-labs recipes into two.
>> >
>> >Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>> >---
>> > meta-arago-distro/classes/sourceipk.bbclass        |    1 -
>> > .../board-port-labs/board-port-labs-linux_git.bb   |   36
>> >++++++++++++++++++++
>> > .../board-port-labs/board-port-labs-u-boot_git.bb  |   36
>> >++++++++++++++++++++
>> > .../recipes-tisdk/board-port-labs/files/LICENSE    |   16
>> >+++++++++
>> > 4 files changed, 88 insertions(+), 1 deletions(-)  create mode
>100644
>> >meta-arago-distro/recipes-tisdk/board-port-
>> >labs/board-port-labs-linux_git.bb
>> > create mode 100644 meta-arago-distro/recipes-tisdk/board-port-
>> >labs/board-port-labs-u-boot_git.bb
>> > create mode 100644 meta-arago-distro/recipes-tisdk/board-port-
>> >labs/files/LICENSE
>> >
>> >diff --git a/meta-arago-distro/classes/sourceipk.bbclass
>b/meta-
>> >arago-distro/classes/sourceipk.bbclass
>> >index 0f0c633..1ea0577 100644
>> >--- a/meta-arago-distro/classes/sourceipk.bbclass
>> >+++ b/meta-arago-distro/classes/sourceipk.bbclass
>> >@@ -61,7 +61,6 @@ SRCIPK_INCLUDE_EXTRAFILES ?= "1"
>> >
>> > SRCIPK_PRESERVE_GIT ?= "false"
>> >
>> >-# Remove git repositories before packaging up the sources
>> > adjust_git() {
>>
>> This hunk should be part of the previous patch.
>>
>> >
>> >     orig_dir="$PWD"
>> >diff --git a/meta-arago-distro/recipes-tisdk/board-port-
>> >labs/board-port-labs-linux_git.bb b/meta-arago-distro/recipes-
>> >tisdk/board-port-labs/board-port-labs-linux_git.bb
>> >new file mode 100644
>> >index 0000000..a105128
>> >--- /dev/null
>> >+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-
>port-
>> >labs-linux_git.bb
>> >@@ -0,0 +1,36 @@
>> >+DESCRIPTION = "Git repositories containing sample board port
>> >code"
>> >+HOMEPAGE = "https://gitorious.org/sitara-board-port"
>> >+LICENSE = "GPLv2"
>> >+
>> >+LIC_FILES_CHKSUM =
>> >"file://../LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"
>>
>> Why not point to the COPYING file in the kernel sources?
>[Franklin] I don't know why we didn't do it in the first place now
>that you mention it. I can use the license from both the kernel
>and u-boot sources.
>>
>> >+
>> >+inherit allarch
>> >+
>> >+CREATE_SRCIPK = "1"
>> >+SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-
>board-
>> >port-linux"
>> >+SRCIPK_PRESERVE_GIT = "true"
>> >+
>> >+PR = "r0"
>> >+
>> >+BRANCH = "master"
>> >+SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-
>> >port-linux.git;protocol=git;branch=${BRANCH} \
>> >+           file://LICENSE"
>> >+
>> >+SRCREV = "${AUTOREV}"
>> >+
>> >+S = "${WORKDIR}/git"
>> >+
>> >+adjust_git_prepend() {
>> >+
>> >+    # Checkout a specific branch instead of a commit that is
>used
>> >by default
>> >+    git checkout ${BRANCH}
>> >+}
>>
>> Any reason this couldn't actually be part of the adjust_git
>function by default?  If
>> a BRANCH is defined do this?
>[Franklin] So the branch option is weird. Bitbake doesn't checkout
>a branch it does a checkout of a commit id. So I don't understand
>the point of the branch variable since a commit id (SRC_REV) can
>come from multiple branches. I assume that specifying branch is
>only useful if you use AUTOREV.
>
>For board port labs assumptions can be made since what I really
>want is the latest commit in a branch so doing a checkout of
>master works well. Majority of recipes want a specific commit and
>not the HEAD of a branch so doing it by default can cause
>problems.

Good point.  I'm OK with this then.

>
>
>>
>> >+
>> >+do_configure() {
>> >+    :
>> >+}
>> >+
>> >+do_compile() {
>> >+    :
>> >+}
>> >+
>> >diff --git a/meta-arago-distro/recipes-tisdk/board-port-
>> >labs/board-port-labs-u-boot_git.bb b/meta-arago-distro/recipes-
>> >tisdk/board-port-labs/board-port-labs-u-boot_git.bb
>> >new file mode 100644
>> >index 0000000..a66eaa4
>> >--- /dev/null
>> >+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-
>port-
>> >labs-u-boot_git.bb
>> >@@ -0,0 +1,36 @@
>> >+DESCRIPTION = "Git repositories containing sample board port
>> >code"
>> >+HOMEPAGE = "https://gitorious.org/sitara-board-port"
>> >+LICENSE = "GPLv2"
>>
>> U-Boot license in the base recipes are GPLv2+ so this probably
>needs to match.
>>
>> >+
>> >+LIC_FILES_CHKSUM =
>> >"file://../LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"
>>
>> Why not use the file in the sources at Licenses/gpl-2.0.txt?
>>
>> Tom, with all the licenses in that directory would you stay u-
>boot is still GPLv2+?
>> It seems those other licenses are for the stand alone apps, but
>for source
>> distribution should this license be updated to include the other
>licenses?
>>
>> >+
>> >+inherit allarch
>> >+
>> >+CREATE_SRCIPK = "1"
>> >+SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-
>board-
>> >port-u-boot"
>> >+SRCIPK_PRESERVE_GIT = "true"
>> >+
>> >+PR = "r0"
>> >+
>> >+BRANCH = "master"
>> >+SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-
>> >port-uboot.git;protocol=git;branch=${BRANCH} \
>> >+           file://LICENSE"
>> >+
>> >+SRCREV = "${AUTOREV}"
>> >+
>> >+S = "${WORKDIR}/git"
>> >+
>> >+adjust_git_prepend() {
>> >+
>> >+    # Checkout a specific branch instead of a commit that is
>used
>> >by default
>> >+    git checkout ${BRANCH}
>> >+}
>>
>> Same comment as the kernel
>>
>> >+
>> >+do_configure() {
>> >+    :
>> >+}
>> >+
>> >+do_compile() {
>> >+    :
>> >+}
>> >+
>> >diff --git a/meta-arago-distro/recipes-tisdk/board-port-
>> >labs/files/LICENSE b/meta-arago-distro/recipes-tisdk/board-
>port-
>> >labs/files/LICENSE
>> >new file mode 100644
>> >index 0000000..738cb23
>> >--- /dev/null
>> >+++ b/meta-arago-distro/recipes-tisdk/board-port-
>> >labs/files/LICENSE
>> >@@ -0,0 +1,16 @@
>> >+The trees found within this directory are git trees for the
>Linux
>> >+kernel and u-boot.  These trees are based on the AM335x part
>and are
>> >+meant to serve as a reference for general tasks involved in a
>> >board
>> >+port.  These trees go along with the training available at:
>> >+
>> >+http://processors.wiki.ti.com/index.php/Sitara_Linux_Training
>> >+
>> >+Inside of each directory is a full git repository.  These
>> >repositories
>> >+have tags that make isolating the changes for each
>functionality
>> >easier.
>> >+You can view the tag using the "git tag" command and use "gitk
>--
>> >all"
>> >+to better view the git tree contents.
>> >+
>> >+The individual trees are licensed under the same license as
>the
>> >Linux
>> >+kernel and u-boot sources which is the GPLv2 license. A copy
>of
>> >license
>> >+for the kernel and u-boot can be found in a file called
>COPYING
>> >within
>> >+each of the respective git repositories.
>>
>> U-boot doesn't have COPYING.
>>
>> >--
>> >1.7.0.4
>> >
>> >_______________________________________________
>> >meta-arago mailing list
>> >meta-arago@arago-project.org
>> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/4] gst-plugins-bad: Remove with-plugins from configuration
  2013-08-22 22:10 [PATCH 1/4] gst-plugins-bad: Remove with-plugins from configuration Franklin S. Cooper Jr
                   ` (2 preceding siblings ...)
  2013-08-22 22:10 ` [PATCH 4/4] packagegroup-arago-tisdk-amsdk-sdk-host: Use new board-port-labs recipe Franklin S. Cooper Jr
@ 2013-08-23 20:31 ` Denys Dmytriyenko
  3 siblings, 0 replies; 11+ messages in thread
From: Denys Dmytriyenko @ 2013-08-23 20:31 UTC (permalink / raw)
  To: Franklin S. Cooper Jr; +Cc: meta-arago

On Thu, Aug 22, 2013 at 05:10:30PM -0500, Franklin S. Cooper Jr wrote:
> * The with-plugins option restricts gst-plugins-bad from building any plugin
>   beyond those specified.
> * Remove this option to allow as many plugins as possible to be built.

I don't believe the description here is correct for this patch. Looks like 
we've been already removing --with-plugins option before, we just need to 
update it to match the upstream, right?


> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> ---
>  .../gstreamer/gst-plugins-bad_0.10.23.bbappend     |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
> index 8ae8050..a13dd54 100644
> --- a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
> +++ b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
> @@ -1,4 +1,4 @@
> -PR_append = "-arago3"
> +PR_append = "-arago4"
>  
>  # look for files in this layer first
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> @@ -9,7 +9,7 @@ EXTRA_OECONF += "--disable-rsvg"
>  
>  # Remove the restriction of which plugins are built. Previously fbdevsink
>  # was not built which is needed by the gstreamer demos included in the SDK.
> -EXTRA_OECONF := "${@oe_filter_out('--with-plugins=musicbrainz,wavpack,ivorbis,mpegvideoparse','${EXTRA_OECONF}', d)}"
> +EXTRA_OECONF := "${@oe_filter_out('--with-plugins=wavpack,mpegvideoparse','${EXTRA_OECONF}', d)}"
>  
>  SRC_URI += "file://0001-gstfbdevsink-Fix-depth-value-for-GST_VIDEO_CAPS_RGB_.patch"
>  
> -- 
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2013-08-23 20:31 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 22:10 [PATCH 1/4] gst-plugins-bad: Remove with-plugins from configuration Franklin S. Cooper Jr
2013-08-22 22:10 ` [PATCH 2/4] sourceipk: Add ability to preserve Git repository Franklin S. Cooper Jr
2013-08-23 14:25   ` Maupin, Chase
2013-08-22 22:10 ` [PATCH 3/4] board-port-labs: Use new SRCIPK_PRESERVE_GIT git feature in sourceipk.bbclass Franklin S. Cooper Jr
2013-08-23 14:36   ` Maupin, Chase
2013-08-23 15:04     ` Cooper Jr., Franklin
2013-08-23 15:25       ` Maupin, Chase
2013-08-23 15:16     ` Tom Rini
2013-08-22 22:10 ` [PATCH 4/4] packagegroup-arago-tisdk-amsdk-sdk-host: Use new board-port-labs recipe Franklin S. Cooper Jr
2013-08-23 14:39   ` Maupin, Chase
2013-08-23 20:31 ` [PATCH 1/4] gst-plugins-bad: Remove with-plugins from configuration Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.