All of lore.kernel.org
 help / color / mirror / Atom feed
From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] pinctrl: mvebu: add missing iounmap
Date: Sat, 24 Aug 2013 11:55:45 +0800	[thread overview]
Message-ID: <20130824115545.6b4abecb@xhacker> (raw)
In-Reply-To: <20130823201925.GA2417@localhost>

Hi Linus and Ezequiel,

On Fri, 23 Aug 2013 13:19:26 -0700
Ezequiel Garcia <ezequiel.garcia@free-electrons.com> wrote:

> On Fri, Aug 23, 2013 at 08:06:02PM +0200, Linus Walleij wrote:
> > On Thu, Aug 22, 2013 at 3:22 PM, Ezequiel Garcia
> > <ezequiel.garcia@free-electrons.com> wrote:
> > > On Thu, Aug 22, 2013 at 08:46:51PM +0800, Jisheng Zhang wrote:
> > >> Add missing iounmap to prove error path and remove path
> > >>
> > >> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> > >> ---
> > >>  drivers/pinctrl/mvebu/pinctrl-mvebu.c | 24 +++++++++++++++++-------
> > >>  1 file changed, 17 insertions(+), 7 deletions(-)
> > >
> > > How about using devm_ioremap_resource() instead?
> > 
> > Yeah that's the right solution, Jisheng can you fix this?
> > 
> 
> I think he already did that, there's a v2 floating around
> with such change. I plan to give it a test, maybe tomorrow,
> if I can find some spare time.
> 

Yep. Here is the V2

http://lists.infradead.org/pipermail/linux-arm-kernel/2013-August/194072.html

Thank you for your help,
Jisheng

WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@marvell.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Mike Turquette <mturquette@linaro.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] pinctrl: mvebu: add missing iounmap
Date: Sat, 24 Aug 2013 11:55:45 +0800	[thread overview]
Message-ID: <20130824115545.6b4abecb@xhacker> (raw)
In-Reply-To: <20130823201925.GA2417@localhost>

Hi Linus and Ezequiel,

On Fri, 23 Aug 2013 13:19:26 -0700
Ezequiel Garcia <ezequiel.garcia@free-electrons.com> wrote:

> On Fri, Aug 23, 2013 at 08:06:02PM +0200, Linus Walleij wrote:
> > On Thu, Aug 22, 2013 at 3:22 PM, Ezequiel Garcia
> > <ezequiel.garcia@free-electrons.com> wrote:
> > > On Thu, Aug 22, 2013 at 08:46:51PM +0800, Jisheng Zhang wrote:
> > >> Add missing iounmap to prove error path and remove path
> > >>
> > >> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> > >> ---
> > >>  drivers/pinctrl/mvebu/pinctrl-mvebu.c | 24 +++++++++++++++++-------
> > >>  1 file changed, 17 insertions(+), 7 deletions(-)
> > >
> > > How about using devm_ioremap_resource() instead?
> > 
> > Yeah that's the right solution, Jisheng can you fix this?
> > 
> 
> I think he already did that, there's a v2 floating around
> with such change. I plan to give it a test, maybe tomorrow,
> if I can find some spare time.
> 

Yep. Here is the V2

http://lists.infradead.org/pipermail/linux-arm-kernel/2013-August/194072.html

Thank you for your help,
Jisheng


  reply	other threads:[~2013-08-24  3:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22 12:46 [PATCH 0/4] arm: mvebu: add missing of_node_put and iounmap Jisheng Zhang
2013-08-22 12:46 ` Jisheng Zhang
2013-08-22 12:46 ` [PATCH 1/4] arm: mvebu: add missing of_node_put() to fix reference leak Jisheng Zhang
2013-08-22 12:46   ` Jisheng Zhang
2013-08-22 12:46 ` [PATCH 2/4] bus: " Jisheng Zhang
2013-08-22 12:46   ` Jisheng Zhang
2013-08-22 12:46 ` [PATCH 3/4] clk: mvebu: add missing iounmap Jisheng Zhang
2013-08-22 12:46   ` Jisheng Zhang
2013-08-22 22:31   ` Mike Turquette
2013-08-22 22:31     ` Mike Turquette
2013-08-22 12:46 ` [PATCH 4/4] pinctrl: " Jisheng Zhang
2013-08-22 12:46   ` Jisheng Zhang
2013-08-22 13:22   ` Ezequiel Garcia
2013-08-22 13:22     ` Ezequiel Garcia
2013-08-23 18:06     ` Linus Walleij
2013-08-23 18:06       ` Linus Walleij
2013-08-23 20:19       ` Ezequiel Garcia
2013-08-23 20:19         ` Ezequiel Garcia
2013-08-24  3:55         ` Jisheng Zhang [this message]
2013-08-24  3:55           ` Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130824115545.6b4abecb@xhacker \
    --to=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.