From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Simo Sorce <simo@redhat.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-nfs@vger.kernel.org, Jan Stancek <jstancek@redhat.com>
Subject: Re: [PATCH v3] SUNRPC: Ensure that the RPCSEC_GSS daemon uses the correct service names
Date: Sat, 24 Aug 2013 08:42:33 -0400 [thread overview]
Message-ID: <20130824124233.GC18084@fieldses.org> (raw)
In-Reply-To: <20130824065706.7bf780e8@tlielax.poochiereds.net>
On Sat, Aug 24, 2013 at 06:57:06AM -0400, Jeff Layton wrote:
> On Sat, 24 Aug 2013 00:56:02 -0400
> Simo Sorce <simo@redhat.com> wrote:
>
> > On Thu, 2013-08-22 at 16:10 -0400, Jeff Layton wrote:
> > > From: Trond Myklebust <Trond.Myklebust@netapp.com>
> > >
> > > v2: added pipe_dir_name field to nfsacl program to fix v3+krb5
> > > (Should we add pipe_dir_name fields to other programs too?).
> > >
> > > v3: Drop changes to gss_encode_v1_msg. They don't seem to be
> > > needed since gssd scrapes that out of the "info" file.
> > >
> > > Fix the upcalls to use the right service names for gssd. The old
> > > version of the rpc.gssd upcall expects the service name to be either
> > > "nfs" or "nfs4_cb", which it will then concatenate with the server name
> > > to create a target name of nfs@<server> or nfs4_cb@<server>
> >
> > I've never seen anyone deply keytabs with nfs4_cb/fqdn service names,
> > what are you trying to do here exactly ?
> >
> > Afaik the only service names used historically have been host/ and nfs/
> > and in some rare cases root/
> >
> > Also the patch seem to add a bunch of other 'service' names ? If you are
> > going to kerberize those services are you going to expect admins to drop
> > multiple keys down in the keytabs ? What is the exact intent here ?
> >
>
> Mostly, I'm trying to ensure that the nfsacl service uses a nfs/
> principal to fix the immediate pain point that nfsv3+krb5 doesn't work.
> With the rest, I was mainly trusting that Trond knew what he was
> doing. ;)
>
> I agree though...I've never seen a nfs4_cb/ principal in use, and I'm
> not sure that we'd really get a lot of value from using a separate
> principal for callbacks.
It's wrong, in fact: an NFSv4.0 callback is supposed to authenticate to
the principal that performed the setclientid.
--b.
> Perhaps we should just hardcode "nfs" as the
> service= parm in the "info" file for now?
>
> Longer term, I think it's time to start a serious re-think of this
> upcall. Having to have a running daemon for this sucks, particularly
> now that you end up with a 15s delay on the first mount attempt when
> it's not. This sort of use-case was the original idea behind the keys
> API -- maybe it's time to figure out how to make that transition?
>
> > > Finally, make sure that we set the correct service names for lockd,
> > > statd and mountd in case we want to convert those to use rpcsec_gss at
> > > some point in the future.
> > >
> > > Fix the upcalls to use the right service names for gssd. The old
> > > version of the rpc.gssd upcall expects the service name to be either
> > > "nfs" or "nfs4_cb", which it will then concatenate with the server name
> > > to create a target name of nfs@<server> or nfs4_cb@<server>
> > >
> > > Finally, make sure that we set the correct service names for lockd,
> > > statd and mountd in case we want to convert those to use rpcsec_gss at
> > > some point in the future.
> > >
> > > Cc: Jan Stancek <jstancek@redhat.com>
> > > Cc: "J. Bruce Fields" <bfields@fieldses.org>
> > > Signed-off-by: Jeff Layton <jlayton@redhat.com>
> > > Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
> > > ---
> > > fs/lockd/clntxdr.c | 1 +
> > > fs/lockd/mon.c | 1 +
> > > fs/nfs/client.c | 1 +
> > > fs/nfs/mount_clnt.c | 1 +
> > > fs/nfs/nfs3client.c | 2 ++
> > > fs/nfsd/nfs4callback.c | 1 +
> > > include/linux/sunrpc/clnt.h | 1 +
> > > net/sunrpc/rpc_pipe.c | 3 ++-
> > > 8 files changed, 10 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/fs/lockd/clntxdr.c b/fs/lockd/clntxdr.c
> > > index 9a55797..18d0c34 100644
> > > --- a/fs/lockd/clntxdr.c
> > > +++ b/fs/lockd/clntxdr.c
> > > @@ -612,6 +612,7 @@ static struct rpc_stat nlm_rpc_stats;
> > >
> > > const struct rpc_program nlm_program = {
> > > .name = "lockd",
> > > + .service_name = "nlockmgr",
> > > .number = NLM_PROGRAM,
> > > .nrvers = ARRAY_SIZE(nlm_versions),
> > > .version = nlm_versions,
> > > diff --git a/fs/lockd/mon.c b/fs/lockd/mon.c
> > > index 1812f02..1ac10f4 100644
> > > --- a/fs/lockd/mon.c
> > > +++ b/fs/lockd/mon.c
> > > @@ -606,6 +606,7 @@ static struct rpc_stat nsm_stats;
> > >
> > > static const struct rpc_program nsm_program = {
> > > .name = "statd",
> > > + .service_name = "status",
> > > .number = NSM_PROGRAM,
> > > .nrvers = ARRAY_SIZE(nsm_version),
> > > .version = nsm_version,
> > > diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> > > index 340b1ef..9fb1050 100644
> > > --- a/fs/nfs/client.c
> > > +++ b/fs/nfs/client.c
> > > @@ -72,6 +72,7 @@ static const struct rpc_version *nfs_version[5] = {
> > >
> > > const struct rpc_program nfs_program = {
> > > .name = "nfs",
> > > + .service_name = "nfs",
> > > .number = NFS_PROGRAM,
> > > .nrvers = ARRAY_SIZE(nfs_version),
> > > .version = nfs_version,
> > > diff --git a/fs/nfs/mount_clnt.c b/fs/nfs/mount_clnt.c
> > > index 99a4528..5f1a888 100644
> > > --- a/fs/nfs/mount_clnt.c
> > > +++ b/fs/nfs/mount_clnt.c
> > > @@ -528,6 +528,7 @@ static struct rpc_stat mnt_stats;
> > >
> > > static const struct rpc_program mnt_program = {
> > > .name = "mount",
> > > + .service_name = "mountd",
> > > .number = NFS_MNT_PROGRAM,
> > > .nrvers = ARRAY_SIZE(mnt_version),
> > > .version = mnt_version,
> > > diff --git a/fs/nfs/nfs3client.c b/fs/nfs/nfs3client.c
> > > index b3fc65e..b61de6b 100644
> > > --- a/fs/nfs/nfs3client.c
> > > +++ b/fs/nfs/nfs3client.c
> > > @@ -10,10 +10,12 @@ static const struct rpc_version *nfsacl_version[] = {
> > >
> > > const struct rpc_program nfsacl_program = {
> > > .name = "nfsacl",
> > > + .service_name = "nfs",
> > > .number = NFS_ACL_PROGRAM,
> > > .nrvers = ARRAY_SIZE(nfsacl_version),
> > > .version = nfsacl_version,
> > > .stats = &nfsacl_rpcstat,
> > > + .pipe_dir_name = "nfs",
> > > };
> > >
> > > /*
> > > diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
> > > index 7f05cd1..2962890 100644
> > > --- a/fs/nfsd/nfs4callback.c
> > > +++ b/fs/nfsd/nfs4callback.c
> > > @@ -596,6 +596,7 @@ static struct rpc_stat cb_stats = {
> > > #define NFS4_CALLBACK 0x40000000
> > > static const struct rpc_program cb_program = {
> > > .name = "nfs4_cb",
> > > + .service_name = "nfs4_cb",
> > > .number = NFS4_CALLBACK,
> > > .nrvers = ARRAY_SIZE(nfs_cb_version),
> > > .version = nfs_cb_version,
> > > diff --git a/include/linux/sunrpc/clnt.h b/include/linux/sunrpc/clnt.h
> > > index bfe11be..d902c55 100644
> > > --- a/include/linux/sunrpc/clnt.h
> > > +++ b/include/linux/sunrpc/clnt.h
> > > @@ -70,6 +70,7 @@ struct rpc_clnt {
> > > #define RPC_MAXVERSION 4
> > > struct rpc_program {
> > > const char * name; /* protocol name */
> > > + const char * service_name; /* protocol service name */
> > > u32 number; /* program number */
> > > unsigned int nrvers; /* number of versions */
> > > const struct rpc_version ** version; /* version array */
> > > diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c
> > > index 406859c..83b196d 100644
> > > --- a/net/sunrpc/rpc_pipe.c
> > > +++ b/net/sunrpc/rpc_pipe.c
> > > @@ -409,7 +409,8 @@ rpc_show_info(struct seq_file *m, void *v)
> > > rcu_read_lock();
> > > seq_printf(m, "RPC server: %s\n",
> > > rcu_dereference(clnt->cl_xprt)->servername);
> > > - seq_printf(m, "service: %s (%d) version %d\n", clnt->cl_protname,
> > > + seq_printf(m, "service: %s (%d) version %d\n",
> > > + clnt->cl_program->service_name,
> > > clnt->cl_prog, clnt->cl_vers);
> > > seq_printf(m, "address: %s\n", rpc_peeraddr2str(clnt, RPC_DISPLAY_ADDR));
> > > seq_printf(m, "protocol: %s\n", rpc_peeraddr2str(clnt, RPC_DISPLAY_PROTO));
> >
> >
>
>
> --
> Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2013-08-24 12:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 20:10 [PATCH v3] SUNRPC: Ensure that the RPCSEC_GSS daemon uses the correct service names Jeff Layton
2013-08-23 23:18 ` J. Bruce Fields
2013-08-24 12:43 ` J. Bruce Fields
2013-08-24 14:30 ` Jeff Layton
2013-08-26 17:11 ` J. Bruce Fields
2013-08-24 4:56 ` Simo Sorce
2013-08-24 10:57 ` Jeff Layton
2013-08-24 12:42 ` J. Bruce Fields [this message]
2013-08-26 16:50 ` J. Bruce Fields
2013-08-26 21:28 ` J. Bruce Fields
2013-09-04 3:11 ` Simo Sorce
2013-09-04 13:39 ` J. Bruce Fields
2013-09-04 17:21 ` Simo Sorce
2013-09-04 17:49 ` J. Bruce Fields
2013-09-04 18:00 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130824124233.GC18084@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=jlayton@redhat.com \
--cc=jstancek@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=simo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.