From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Simo Sorce <simo@redhat.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-nfs@vger.kernel.org, Jan Stancek <jstancek@redhat.com>
Subject: Re: [PATCH v3] SUNRPC: Ensure that the RPCSEC_GSS daemon uses the correct service names
Date: Mon, 26 Aug 2013 17:28:05 -0400 [thread overview]
Message-ID: <20130826212805.GB14809@fieldses.org> (raw)
In-Reply-To: <20130826165051.GF3121@fieldses.org>
On Mon, Aug 26, 2013 at 12:50:51PM -0400, J. Bruce Fields wrote:
> On Sat, Aug 24, 2013 at 08:42:33AM -0400, J. Bruce Fields wrote:
> > On Sat, Aug 24, 2013 at 06:57:06AM -0400, Jeff Layton wrote:
> > > On Sat, 24 Aug 2013 00:56:02 -0400
> > > Simo Sorce <simo@redhat.com> wrote:
> > >
> > > > On Thu, 2013-08-22 at 16:10 -0400, Jeff Layton wrote:
> > > > > From: Trond Myklebust <Trond.Myklebust@netapp.com>
> > > > >
> > > > > v2: added pipe_dir_name field to nfsacl program to fix v3+krb5
> > > > > (Should we add pipe_dir_name fields to other programs too?).
> > > > >
> > > > > v3: Drop changes to gss_encode_v1_msg. They don't seem to be
> > > > > needed since gssd scrapes that out of the "info" file.
> > > > >
> > > > > Fix the upcalls to use the right service names for gssd. The old
> > > > > version of the rpc.gssd upcall expects the service name to be either
> > > > > "nfs" or "nfs4_cb", which it will then concatenate with the server name
> > > > > to create a target name of nfs@<server> or nfs4_cb@<server>
> > > >
> > > > I've never seen anyone deply keytabs with nfs4_cb/fqdn service names,
> > > > what are you trying to do here exactly ?
> > > >
> > > > Afaik the only service names used historically have been host/ and nfs/
> > > > and in some rare cases root/
> > > >
> > > > Also the patch seem to add a bunch of other 'service' names ? If you are
> > > > going to kerberize those services are you going to expect admins to drop
> > > > multiple keys down in the keytabs ? What is the exact intent here ?
>
> Yeah, that seems wrong to me, if (big if) any of the other services used
> gss I'd expect they'd want to authenticate to the same nfs/ principal.
>
> > > Mostly, I'm trying to ensure that the nfsacl service uses a nfs/
> > > principal to fix the immediate pain point that nfsv3+krb5 doesn't work.
> > > With the rest, I was mainly trusting that Trond knew what he was
> > > doing. ;)
> > >
> > > I agree though...I've never seen a nfs4_cb/ principal in use, and I'm
> > > not sure that we'd really get a lot of value from using a separate
> > > principal for callbacks.
> >
> > It's wrong, in fact: an NFSv4.0 callback is supposed to authenticate to
> > the principal that performed the setclientid.
>
> Well, but: after refamiliarizing myself with the code this morning:
> really, it's irrelevant. The server's setup_callback_client() calls
> rpc_create with client_name set to the principal that performed the
> setclientid. This sets cl_principal, which results in a "target="
> argument in the upcall.
>
> (The way this is set looks hairy:
>
> - svcgssd case: svcgssd passes it down at the end of the
> downcall. It's calculated by
> utils/gssd/svcgssd_proc.c:get_hostbased_client_name by calling
> gss_display_name() and then changing x/y@REALM to x@y in the
> krb5 case. ??
> - gssproxy case: does the same transformation on the returned
> name in gssp_accept_sec_context_upcall.
>
> But Simo'd be the expert on whether this makes sense and what we should
> do instead if not.)
And actually as far as I can tell NFSv4.0 callbacks aren't working at
all right now over krb5. I see gssd open the info file and then never
read any upcalls, so I wonder if it's just balking at something it sees
in the info file.
--b.
next prev parent reply other threads:[~2013-08-26 21:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 20:10 [PATCH v3] SUNRPC: Ensure that the RPCSEC_GSS daemon uses the correct service names Jeff Layton
2013-08-23 23:18 ` J. Bruce Fields
2013-08-24 12:43 ` J. Bruce Fields
2013-08-24 14:30 ` Jeff Layton
2013-08-26 17:11 ` J. Bruce Fields
2013-08-24 4:56 ` Simo Sorce
2013-08-24 10:57 ` Jeff Layton
2013-08-24 12:42 ` J. Bruce Fields
2013-08-26 16:50 ` J. Bruce Fields
2013-08-26 21:28 ` J. Bruce Fields [this message]
2013-09-04 3:11 ` Simo Sorce
2013-09-04 13:39 ` J. Bruce Fields
2013-09-04 17:21 ` Simo Sorce
2013-09-04 17:49 ` J. Bruce Fields
2013-09-04 18:00 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130826212805.GB14809@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=jlayton@redhat.com \
--cc=jstancek@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=simo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.