From: Luiz Capitulino <lcapitulino@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH] monitor: Add missing attributes to local function
Date: Mon, 26 Aug 2013 11:48:59 -0400 [thread overview]
Message-ID: <20130826114859.640f5d87@redhat.com> (raw)
In-Reply-To: <1377199809-12208-1-git-send-email-sw@weilnetz.de>
On Thu, 22 Aug 2013 21:30:09 +0200
Stefan Weil <sw@weilnetz.de> wrote:
> Function expr_error gets a format string and variable arguments like printf.
> It also never returns. Add the necessary attributes.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Applied to the qmp branch, thanks.
> ---
> monitor.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/monitor.c b/monitor.c
> index da9c9a2..6413d44 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3171,7 +3171,8 @@ static const MonitorDef monitor_defs[] = {
> { NULL },
> };
>
> -static void expr_error(Monitor *mon, const char *fmt, ...)
> +static void GCC_FMT_ATTR(2, 3) QEMU_NORETURN
> +expr_error(Monitor *mon, const char *fmt, ...)
> {
> va_list ap;
> va_start(ap, fmt);
WARNING: multiple messages have this Message-ID (diff)
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] monitor: Add missing attributes to local function
Date: Mon, 26 Aug 2013 11:48:59 -0400 [thread overview]
Message-ID: <20130826114859.640f5d87@redhat.com> (raw)
In-Reply-To: <1377199809-12208-1-git-send-email-sw@weilnetz.de>
On Thu, 22 Aug 2013 21:30:09 +0200
Stefan Weil <sw@weilnetz.de> wrote:
> Function expr_error gets a format string and variable arguments like printf.
> It also never returns. Add the necessary attributes.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Applied to the qmp branch, thanks.
> ---
> monitor.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/monitor.c b/monitor.c
> index da9c9a2..6413d44 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3171,7 +3171,8 @@ static const MonitorDef monitor_defs[] = {
> { NULL },
> };
>
> -static void expr_error(Monitor *mon, const char *fmt, ...)
> +static void GCC_FMT_ATTR(2, 3) QEMU_NORETURN
> +expr_error(Monitor *mon, const char *fmt, ...)
> {
> va_list ap;
> va_start(ap, fmt);
next prev parent reply other threads:[~2013-08-26 18:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 19:30 [Qemu-trivial] [PATCH] monitor: Add missing attributes to local function Stefan Weil
2013-08-22 19:30 ` [Qemu-devel] " Stefan Weil
2013-08-26 15:48 ` Luiz Capitulino [this message]
2013-08-26 15:48 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130826114859.640f5d87@redhat.com \
--to=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.