* [patch -next] xen/evtchn: double free on error
@ 2013-08-26 16:18 Dan Carpenter
2013-08-27 18:17 ` David Vrabel
2013-08-27 18:17 ` David Vrabel
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-08-26 16:18 UTC (permalink / raw)
To: kernel-janitors
The call to del_evtchn() frees "evtchn".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c
index f328f12..8b3a69a 100644
--- a/drivers/xen/evtchn.c
+++ b/drivers/xen/evtchn.c
@@ -319,7 +319,6 @@ err:
if (HYPERVISOR_event_channel_op(EVTCHNOP_close, &close) != 0)
BUG();
del_evtchn(u, evtchn);
- kfree(evtchn);
return rc;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch -next] xen/evtchn: double free on error
@ 2013-08-26 16:18 Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-08-26 16:18 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: xen-devel, Boris Ostrovsky, kernel-janitors, David Vrabel
The call to del_evtchn() frees "evtchn".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c
index f328f12..8b3a69a 100644
--- a/drivers/xen/evtchn.c
+++ b/drivers/xen/evtchn.c
@@ -319,7 +319,6 @@ err:
if (HYPERVISOR_event_channel_op(EVTCHNOP_close, &close) != 0)
BUG();
del_evtchn(u, evtchn);
- kfree(evtchn);
return rc;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch -next] xen/evtchn: double free on error
2013-08-26 16:18 [patch -next] xen/evtchn: double free on error Dan Carpenter
@ 2013-08-27 18:17 ` David Vrabel
2013-08-27 18:17 ` David Vrabel
1 sibling, 0 replies; 4+ messages in thread
From: David Vrabel @ 2013-08-27 18:17 UTC (permalink / raw)
To: kernel-janitors
On 26/08/13 17:18, Dan Carpenter wrote:
> The call to del_evtchn() frees "evtchn".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch, thanks.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
This needs to be queued up for 3.12.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch -next] xen/evtchn: double free on error
2013-08-26 16:18 [patch -next] xen/evtchn: double free on error Dan Carpenter
2013-08-27 18:17 ` David Vrabel
@ 2013-08-27 18:17 ` David Vrabel
1 sibling, 0 replies; 4+ messages in thread
From: David Vrabel @ 2013-08-27 18:17 UTC (permalink / raw)
To: Dan Carpenter; +Cc: xen-devel, Boris Ostrovsky, kernel-janitors
On 26/08/13 17:18, Dan Carpenter wrote:
> The call to del_evtchn() frees "evtchn".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch, thanks.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
This needs to be queued up for 3.12.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-27 18:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-26 16:18 [patch -next] xen/evtchn: double free on error Dan Carpenter
2013-08-27 18:17 ` David Vrabel
2013-08-27 18:17 ` David Vrabel
-- strict thread matches above, loose matches on Subject: below --
2013-08-26 16:18 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.