All of lore.kernel.org
 help / color / mirror / Atom feed
From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] arm: mvebu: add missing of_node_put() to fix reference leak
Date: Mon, 26 Aug 2013 18:06:36 +0800	[thread overview]
Message-ID: <20130826180636.3e2bdb20@xhacker> (raw)
In-Reply-To: <20130826120200.2269ba82@skate>

Dear Thomas,

On Mon, 26 Aug 2013 03:02:00 -0700
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Dear Jisheng Zhang,
> 
> On Mon, 26 Aug 2013 17:56:19 +0800, Jisheng Zhang wrote:
> 
> > diff --git a/arch/arm/mach-mvebu/armada-370-xp.c
> > b/arch/arm/mach-mvebu/armada-370-xp.c index 97cbb80..8a1ae83 100644
> > --- a/arch/arm/mach-mvebu/armada-370-xp.c
> > +++ b/arch/arm/mach-mvebu/armada-370-xp.c
> > @@ -64,6 +64,7 @@ static void __init armada_370_xp_mbus_init(void)
> >  			ARMADA_370_XP_MBUS_WINS_SIZE,
> >  			of_translate_address(dn, &sdram_wins_offs),
> >  			ARMADA_370_XP_SDRAM_WINS_SIZE);
> > +	of_node_put(dn);
> >  }
> 
> With the integration of Ezequiel patches that add DT support to the
> mvebu-mbus driver, this chunk of the code is no longer needed, as of
> linux-next.
> 
Got it. Thanks for the information. Will send v4 latter

Thanks,
Jisheng

WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@marvell.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: "jason@lakedaemon.net" <jason@lakedaemon.net>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	"gregory.clement@free-electrons.com" 
	<gregory.clement@free-electrons.com>,
	"ezequiel.garcia@free-electrons.com" 
	<ezequiel.garcia@free-electrons.com>,
	"mturquette@linaro.org" <mturquette@linaro.org>,
	"sebastian.hesselbarth@gmail.com"
	<sebastian.hesselbarth@gmail.com>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] arm: mvebu: add missing of_node_put() to fix reference leak
Date: Mon, 26 Aug 2013 18:06:36 +0800	[thread overview]
Message-ID: <20130826180636.3e2bdb20@xhacker> (raw)
In-Reply-To: <20130826120200.2269ba82@skate>

Dear Thomas,

On Mon, 26 Aug 2013 03:02:00 -0700
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Dear Jisheng Zhang,
> 
> On Mon, 26 Aug 2013 17:56:19 +0800, Jisheng Zhang wrote:
> 
> > diff --git a/arch/arm/mach-mvebu/armada-370-xp.c
> > b/arch/arm/mach-mvebu/armada-370-xp.c index 97cbb80..8a1ae83 100644
> > --- a/arch/arm/mach-mvebu/armada-370-xp.c
> > +++ b/arch/arm/mach-mvebu/armada-370-xp.c
> > @@ -64,6 +64,7 @@ static void __init armada_370_xp_mbus_init(void)
> >  			ARMADA_370_XP_MBUS_WINS_SIZE,
> >  			of_translate_address(dn, &sdram_wins_offs),
> >  			ARMADA_370_XP_SDRAM_WINS_SIZE);
> > +	of_node_put(dn);
> >  }
> 
> With the integration of Ezequiel patches that add DT support to the
> mvebu-mbus driver, this chunk of the code is no longer needed, as of
> linux-next.
> 
Got it. Thanks for the information. Will send v4 latter

Thanks,
Jisheng


  reply	other threads:[~2013-08-26 10:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26  9:56 [PATCH v3 0/3] arm: mvebu: fix resource leak Jisheng Zhang
2013-08-26  9:56 ` Jisheng Zhang
2013-08-26  9:56 ` [PATCH v3 1/3] arm: mvebu: add missing of_node_put() to fix reference leak Jisheng Zhang
2013-08-26  9:56   ` Jisheng Zhang
2013-08-26 10:02   ` Thomas Petazzoni
2013-08-26 10:02     ` Thomas Petazzoni
2013-08-26 10:06     ` Jisheng Zhang [this message]
2013-08-26 10:06       ` Jisheng Zhang
2013-08-26  9:56 ` [PATCH v3 2/3] bus: " Jisheng Zhang
2013-08-26  9:56   ` Jisheng Zhang
2013-08-26  9:56 ` [PATCH v3 3/3] pinctrl: mvebu: Convert to use devm_ioremap_resource Jisheng Zhang
2013-08-26  9:56   ` Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130826180636.3e2bdb20@xhacker \
    --to=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.