Re: bcache-tools: minor change for bcache-register

[Kent Overstreet <kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>]

On Mon, Aug 26, 2013 at 11:14:06AM +0200, Rolf Fokkens wrote:
> Hi!
> 
> bcache-register is called from the provided udev rules in
> bcache-tools. During boot it seams like some devices are registered
> multiple times, which results in messages during boot. To suppress
> these messages I redirect them to /dev/null in the following patch:
> 
> --- bcache-tools-20130820/bcache-register.register      2013-08-20
> 22:03:46.000000000 +0200
> +++ bcache-tools-20130820/bcache-register       2013-08-25
> 21:31:11.707823194 +0200
> @@ -1,4 +1,9 @@
>  #!/bin/sh
> -modprobe -qba bcache
> -test -f /sys/fs/bcache/register && echo "$1" > /sys/fs/bcache/register
> +#
> +# Utility script to be called from udev, so it's not monkey proof
> at all. It's
> +# sole purpose is to load the bcache kernel module whenever a
> bcache device is
> +# detected.
> +#
> +/usr/sbin/modprobe -qba bcache
> +test -f /sys/fs/bcache/register && echo "$1" >
> /sys/fs/bcache/register 2>/dev/null
> 
> I can imagine there's a more elegant solution, suggestions are welcome.

Just use /sys/fs/bcache/register_quiet instead of register.

I'll change it to do that.