All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rolf Fokkens <rolf-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org>
To: Gabriel de Perthuis <g2p.code-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: bcache-tools: minor change for bcache-register
Date: Tue, 27 Aug 2013 14:02:40 +0200	[thread overview]
Message-ID: <521C9560.2020603@rolffokkens.nl> (raw)
In-Reply-To: <kvi3hj$nvo$1@ger.gmane.org>

Gabriel, I might have been unclear about this, but this __IS__ a problem 
on Fedora. Without a full path for modprobe (/sbin/modprobe or 
/usr/sbin/modprobe) in bcache-register, udev does not create the 
/dev/bcache* devices. So at the moment I fix it in the package.

If this is however Fedora specific I'll have the fix it in the package 
of course. But it's hard for me to tell, and /sbin/modprobe seemed like 
a cross-distro solution to me.

On 08/27/2013 01:45 PM, Gabriel de Perthuis wrote:
> On Tue, 27 Aug 2013 13:00:24 +0300, Alex Pyrgiotis wrote:
>> On 08/27/2013 09:58 AM, Rolf Fokkens wrote:
>>> -modprobe -qba bcache
>>> +/sbin/modprobe -qba bcache
>>>    test -f /sys/fs/bcache/register_quiet && echo "$1" >
>>> /sys/fs/bcache/register_quiet
>>>
>>> /sbin is not in the $PATH for utilities started from udev. For Fedora it
>>> isn't anyway, but it won't harm other distro's neither.
>>>
>> Hi all,
>>
>> Pardon the interrupt, but this is not the case for Arch Linux:
>> https://www.archlinux.org/news/binaries-move-to-usrbin-requiring-update-intervention/
>>
>> In my opinion, if modprobe *has* to be called with the exact path name,
>> it would probably be clearer to use `which modprobe` and then call the
>> result.
> IME the exact path name is unnecessary.
> Rolf, your best shot at contributing is to bring up problems that have
> actually been encountered on Fedora.  Changes need to come as a side
> effect of discussions, not the other way around.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-08-27 12:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26  9:14 bcache-tools: minor change for bcache-register Rolf Fokkens
     [not found] ` <521B1C5E.2090007-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org>
2013-08-26 16:17   ` Darrick J. Wong
2013-08-26 16:31     ` Gabriel de Perthuis
2013-08-26 16:54       ` [PATCH] bcache: Downgrade "device already registered" to pr_debug Gabriel de Perthuis
2013-08-26 16:54         ` Gabriel de Perthuis
2013-08-26 21:48       ` bcache-tools: minor change for bcache-register Kent Overstreet
2013-08-26 22:16         ` Gabriel de Perthuis
     [not found]           ` <521BD3C0.9070209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-26 22:31             ` [PATCH] bcache: register_quiet should still report errors Gabriel de Perthuis
2013-08-26 22:31               ` Gabriel de Perthuis
     [not found]               ` <1377556306-29938-1-git-send-email-g2p.code-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-26 22:37                 ` Gabriel de Perthuis
2013-08-26 22:37                   ` Gabriel de Perthuis
2013-08-26 21:41   ` bcache-tools: minor change for bcache-register Kent Overstreet
2013-08-27  6:58     ` Rolf Fokkens
     [not found]       ` <521C4E2B.8090008-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org>
2013-08-27 10:00         ` Alex Pyrgiotis
2013-08-27 11:45           ` Gabriel de Perthuis
2013-08-27 12:02             ` Rolf Fokkens [this message]
     [not found]               ` <521C9560.2020603-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org>
2013-08-27 12:11                 ` Gabriel de Perthuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521C9560.2020603@rolffokkens.nl \
    --to=rolf-6w2rdlbueqtpmfipwq+h6g@public.gmane.org \
    --cc=g2p.code-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.