Re: [PATCH nft] src: allow to specify the base chain type

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Aug 23, 2013 at 10:39:05AM +0300, Tomasz Bursztyka wrote:
[...]
> >	add table mangle
> >	add chain mangle OUTPUT { type route hook NF_INET_LOCAL_OUT 0; }
> 
> Instead of NF_INET_LOCAL_OUT could we get OUT? (not literally ;) )

makes sense.

> IN, OUT, PRE-ROUTING, FORWARD, POST-ROUTING etc...

I prefer: input, output, prerouting, forward, postrouting.

> And depending on chain's family, nft would use the right value there
> (IN: is NF_INET_LOCAL_IN for ipv4, NF_ARP_IN for arp, etc...)
> 
> It would also make command line easier and more readable.
> 
> One more debatable:
> What about adding prio keyword? So it would be { type <string> hook
> <string> prio <num> }
> Or keeping both possibility <num> or prio <num>?

it also makes sense to me, but that should come in a separated patch.

> I can prepare a patch if you want,

Go ahead. Thanks.