From: Stephen Boyd <sboyd@codeaurora.org>
To: Tomasz Figa <t.figa@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Kukjin Kim <kgene.kim@samsung.com>,
Olof Johansson <olof@lixom.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] clocksource: exynos_mct: Set IRQ affinity when the CPU goes online
Date: Mon, 26 Aug 2013 16:09:41 -0700 [thread overview]
Message-ID: <20130826230940.GI23960@codeaurora.org> (raw)
In-Reply-To: <1377534836-21682-1-git-send-email-t.figa@samsung.com>
On 08/26, Tomasz Figa wrote:
> Some variants of Exynos MCT, namely exynos4210-mct at the moment, use
> normal, shared interrupts for local timers. This means that each
> interrupt must have correct affinity set to fire only on CPU
> corresponding to given local timer.
>
> However after recent conversion of clocksource drivers to not use the
> local timer API for local timer initialization any more, the point of
> time when local timers get initialized changed and irq_set_affinity()
> fails because the CPU is not marked as online yet.
>
> This patch fixes this by moving the call to irq_set_affinity() to
> CPU_ONLINE notification, so the affinity is being set when the CPU goes
> online.
>
> This fixes a problem with Exynos4210 failing to boot, present since commit
> ee98d27df6 ARM: EXYNOS4: Divorce mct from local timer API
> due to failing irq_set_affinity().
>
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
Looks good to me if you want to go this route.
Acked-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource: exynos_mct: Set IRQ affinity when the CPU goes online
Date: Mon, 26 Aug 2013 16:09:41 -0700 [thread overview]
Message-ID: <20130826230940.GI23960@codeaurora.org> (raw)
In-Reply-To: <1377534836-21682-1-git-send-email-t.figa@samsung.com>
On 08/26, Tomasz Figa wrote:
> Some variants of Exynos MCT, namely exynos4210-mct at the moment, use
> normal, shared interrupts for local timers. This means that each
> interrupt must have correct affinity set to fire only on CPU
> corresponding to given local timer.
>
> However after recent conversion of clocksource drivers to not use the
> local timer API for local timer initialization any more, the point of
> time when local timers get initialized changed and irq_set_affinity()
> fails because the CPU is not marked as online yet.
>
> This patch fixes this by moving the call to irq_set_affinity() to
> CPU_ONLINE notification, so the affinity is being set when the CPU goes
> online.
>
> This fixes a problem with Exynos4210 failing to boot, present since commit
> ee98d27df6 ARM: EXYNOS4: Divorce mct from local timer API
> due to failing irq_set_affinity().
>
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
Looks good to me if you want to go this route.
Acked-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-08-26 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 16:33 [PATCH] clocksource: exynos_mct: Set IRQ affinity when the CPU goes online Tomasz Figa
2013-08-26 16:33 ` Tomasz Figa
2013-08-26 23:09 ` Stephen Boyd [this message]
2013-08-26 23:09 ` Stephen Boyd
2013-08-26 23:26 ` Tomasz Figa
2013-08-26 23:26 ` Tomasz Figa
2013-09-25 14:05 ` [PATCH RESEND CRITICAL] " Tomasz Figa
2013-09-25 14:05 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130826230940.GI23960@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=t.figa@samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.