Re: [PATCH v2 3/3] mm/hwpoison: fix return value of madvise_hwpoison

[Wanpeng Li <liwanp@linux.vnet.ibm.com>]

Hi Naoya,
On Mon, Aug 26, 2013 at 11:28:16PM -0400, Naoya Horiguchi wrote:
>On Tue, Aug 27, 2013 at 10:39:31AM +0800, Wanpeng Li wrote:
>> The return value outside for loop is always zero which means madvise_hwpoison 
>> return success, however, this is not truth for soft_offline_page w/ failure
>> return value.
>
>I don't understand what you want to do for what reason. Could you clarify
>those?

int ret is defined in two place in madvise_hwpoison. One is out of for
loop and its value is always zero(zero means success for madvise), the 
other one is in for loop. The soft_offline_page function maybe return 
-EBUSY and break, however, the ret out of for loop is return which means 
madvise_hwpoison success. 

Regards,
Wanpeng Li 

>
>> 
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>> ---
>>  mm/madvise.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/mm/madvise.c b/mm/madvise.c
>> index a20764c..19b71e4 100644
>> --- a/mm/madvise.c
>> +++ b/mm/madvise.c
>> @@ -359,7 +359,7 @@ static int madvise_hwpoison(int bhv, unsigned long start, unsigned long end)
>>  				page_to_pfn(p), start);
>>  			ret = soft_offline_page(p, MF_COUNT_INCREASED);
>>  			if (ret)
>> -				break;
>> +				return ret;
>>  			continue;
>>  		}
>>  		pr_info("Injecting memory failure for page %#lx at %#lx\n",
>
>This seems to introduce no behavioral change.
>
>Thanks,
>Naoya Horiguchi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>