From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: dinguyen@altera.com
Cc: dinh.linux@gmail.com, Jaehoon Chung <jh80.chung@samsung.com>,
Seungwon Jeon <tgih.jun@samsung.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
devicetree@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv5 2/3] ARM: socfpga: dts: Add support for SD/MMC
Date: Tue, 27 Aug 2013 17:31:22 +0200 [thread overview]
Message-ID: <20130827153122.GH24795@pengutronix.de> (raw)
In-Reply-To: <1377272686-13253-2-git-send-email-dinguyen@altera.com>
Hi!
On Fri, Aug 23, 2013 at 10:44:45AM -0500, dinguyen@altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> Add bindings for SD/MMC for SOCFPGA.
>
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Seungwon Jeon <tgih.jun@samsung.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> CC: linux-arm-kernel@lists.infradead.org
>
> v5:
> - Add "altr,ciu-clk-offset" that represents the necessary offset
> and shift values in the sysmgr phandle. This is used to set
> the correct CIU clock values.
>
> v4:
> - Add a complete binding example in documentations
> - Add a phandle entry for "altr,sysmgr" which links the system
> manager to the SD/MMC IP block that controls the SDR timings.
> - Split up patches
> 1/3 - Add syscon binding to sys-mgr node
> 2/3 - DTS bindings and documentation for SD/MMC on SOCFPGA
> 3/3 - Driver changes to use the bindings
>
> v3:
> - Explicitly reference synopsis-dw-mshc.txt for base bindings
> - Remove "dw-mshc-ciu-div" as driver can get clock information dts "ciu" entry
> - Fixed indentation issue
>
> v2:
> - Remove bus-width and extra line in documentation
> - Merge bindings example into a single node in documentation
> ---
You should put your changelogs here and not above the ---
AFAIK nobody cares for the development history of a patch once it is applied.
> .../devicetree/bindings/mmc/socfpga-dw-mshc.txt | 63 ++++++++++++++++++++
> arch/arm/boot/dts/socfpga.dtsi | 11 ++++
> arch/arm/boot/dts/socfpga_cyclone5.dts | 14 +++++
> arch/arm/boot/dts/socfpga_vt.dts | 14 +++++
> 4 files changed, 102 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt
>
Regards,
Steffen
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: s.trumtrar@pengutronix.de (Steffen Trumtrar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5 2/3] ARM: socfpga: dts: Add support for SD/MMC
Date: Tue, 27 Aug 2013 17:31:22 +0200 [thread overview]
Message-ID: <20130827153122.GH24795@pengutronix.de> (raw)
In-Reply-To: <1377272686-13253-2-git-send-email-dinguyen@altera.com>
Hi!
On Fri, Aug 23, 2013 at 10:44:45AM -0500, dinguyen at altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> Add bindings for SD/MMC for SOCFPGA.
>
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Seungwon Jeon <tgih.jun@samsung.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: devicetree at vger.kernel.org
> Cc: linux-mmc at vger.kernel.org
> CC: linux-arm-kernel at lists.infradead.org
>
> v5:
> - Add "altr,ciu-clk-offset" that represents the necessary offset
> and shift values in the sysmgr phandle. This is used to set
> the correct CIU clock values.
>
> v4:
> - Add a complete binding example in documentations
> - Add a phandle entry for "altr,sysmgr" which links the system
> manager to the SD/MMC IP block that controls the SDR timings.
> - Split up patches
> 1/3 - Add syscon binding to sys-mgr node
> 2/3 - DTS bindings and documentation for SD/MMC on SOCFPGA
> 3/3 - Driver changes to use the bindings
>
> v3:
> - Explicitly reference synopsis-dw-mshc.txt for base bindings
> - Remove "dw-mshc-ciu-div" as driver can get clock information dts "ciu" entry
> - Fixed indentation issue
>
> v2:
> - Remove bus-width and extra line in documentation
> - Merge bindings example into a single node in documentation
> ---
You should put your changelogs here and not above the ---
AFAIK nobody cares for the development history of a patch once it is applied.
> .../devicetree/bindings/mmc/socfpga-dw-mshc.txt | 63 ++++++++++++++++++++
> arch/arm/boot/dts/socfpga.dtsi | 11 ++++
> arch/arm/boot/dts/socfpga_cyclone5.dts | 14 +++++
> arch/arm/boot/dts/socfpga_vt.dts | 14 +++++
> 4 files changed, 102 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt
>
Regards,
Steffen
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-08-27 15:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 15:44 [PATCHv5 1/3] arm: socfpga: dts: Add a syscon binding for sys-mgr dinguyen at altera.com
2013-08-23 15:44 ` [PATCHv5 2/3] ARM: socfpga: dts: Add support for SD/MMC dinguyen
2013-08-23 15:44 ` dinguyen at altera.com
2013-08-23 22:29 ` Stephen Warren
2013-08-23 22:29 ` Stephen Warren
2013-08-23 23:01 ` Dinh Nguyen
2013-08-23 23:01 ` Dinh Nguyen
2013-08-26 16:44 ` Stephen Warren
2013-08-26 16:44 ` Stephen Warren
2013-08-27 15:31 ` Steffen Trumtrar [this message]
2013-08-27 15:31 ` Steffen Trumtrar
2013-08-23 15:44 ` [PATCHv5 3/3] mmc: dw_mmc: Use phandle to get SDR timing values from sys-mgr dinguyen
2013-08-23 15:44 ` dinguyen at altera.com
2013-08-29 11:56 ` Seungwon Jeon
2013-08-29 11:56 ` Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827153122.GH24795@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=dinh.linux@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.