From: Dave Jones <davej@redhat.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Hugh Dickins <hughd@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Hillf Danton <dhillf@gmail.com>, Linux-MM <linux-mm@kvack.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Emelyanov <xemul@parallels.com>
Subject: Re: unused swap offset / bad page map.
Date: Tue, 27 Aug 2013 12:24:27 -0400 [thread overview]
Message-ID: <20130827162427.GA26717@redhat.com> (raw)
In-Reply-To: <20130827083718.GC7416@moon>
On Tue, Aug 27, 2013 at 12:37:18PM +0400, Cyrill Gorcunov wrote:
> On Mon, Aug 26, 2013 at 06:28:33PM -0400, Dave Jones wrote:
> > >
> > > I've not tried matching up bits with Dave's reports, and just going
> > > into a meeting now, but this patch looks worth a try: probably Cyrill
> > > can improve it meanwhile to what he actually wants there (I'm
> > > surprised anything special is needed for just moving a pte).
> > >
> > > Hugh
> > >
> > > --- 3.11-rc7/mm/mremap.c 2013-07-14 17:10:16.640003652 -0700
> > > +++ linux/mm/mremap.c 2013-08-26 14:46:14.460027627 -0700
> > > @@ -126,7 +126,7 @@ static void move_ptes(struct vm_area_str
> > > continue;
> > > pte = ptep_get_and_clear(mm, old_addr, old_pte);
> > > pte = move_pte(pte, new_vma->vm_page_prot, old_addr, new_addr);
> > > - set_pte_at(mm, new_addr, new_pte, pte_mksoft_dirty(pte));
> > > + set_pte_at(mm, new_addr, new_pte, pte);
> > > }
> >
> > I'll give this a shot once I'm done with the bisect.
>
> I managed to trigger the issue as well. The patch below fixes it.
> Dave, could you please give it a shot once time permit?
Seems to do the trick.
Tested-by: Dave Jones <davej@fedoraproject.org>
Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Hugh Dickins <hughd@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Hillf Danton <dhillf@gmail.com>, Linux-MM <linux-mm@kvack.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Emelyanov <xemul@parallels.com>
Subject: Re: unused swap offset / bad page map.
Date: Tue, 27 Aug 2013 12:24:27 -0400 [thread overview]
Message-ID: <20130827162427.GA26717@redhat.com> (raw)
In-Reply-To: <20130827083718.GC7416@moon>
On Tue, Aug 27, 2013 at 12:37:18PM +0400, Cyrill Gorcunov wrote:
> On Mon, Aug 26, 2013 at 06:28:33PM -0400, Dave Jones wrote:
> > >
> > > I've not tried matching up bits with Dave's reports, and just going
> > > into a meeting now, but this patch looks worth a try: probably Cyrill
> > > can improve it meanwhile to what he actually wants there (I'm
> > > surprised anything special is needed for just moving a pte).
> > >
> > > Hugh
> > >
> > > --- 3.11-rc7/mm/mremap.c 2013-07-14 17:10:16.640003652 -0700
> > > +++ linux/mm/mremap.c 2013-08-26 14:46:14.460027627 -0700
> > > @@ -126,7 +126,7 @@ static void move_ptes(struct vm_area_str
> > > continue;
> > > pte = ptep_get_and_clear(mm, old_addr, old_pte);
> > > pte = move_pte(pte, new_vma->vm_page_prot, old_addr, new_addr);
> > > - set_pte_at(mm, new_addr, new_pte, pte_mksoft_dirty(pte));
> > > + set_pte_at(mm, new_addr, new_pte, pte);
> > > }
> >
> > I'll give this a shot once I'm done with the bisect.
>
> I managed to trigger the issue as well. The patch below fixes it.
> Dave, could you please give it a shot once time permit?
Seems to do the trick.
Tested-by: Dave Jones <davej@fedoraproject.org>
Dave
next prev parent reply other threads:[~2013-08-27 16:24 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 5:51 unused swap offset / bad page map Dave Jones
2013-08-07 5:51 ` Dave Jones
2013-08-07 10:04 ` Hillf Danton
2013-08-07 10:04 ` Hillf Danton
2013-08-07 15:30 ` Dave Jones
2013-08-07 15:30 ` Dave Jones
2013-08-08 15:20 ` Hillf Danton
2013-08-08 15:20 ` Hillf Danton
2013-08-08 15:36 ` Dave Jones
2013-08-08 15:36 ` Dave Jones
2013-08-19 23:18 ` Dave Jones
2013-08-19 23:18 ` Dave Jones
2013-08-20 4:39 ` Hillf Danton
2013-08-20 4:39 ` Hillf Danton
2013-08-21 20:49 ` Dave Jones
2013-08-21 20:49 ` Dave Jones
2013-08-22 0:35 ` Hillf Danton
2013-08-22 0:35 ` Hillf Danton
2013-08-22 3:21 ` Hillf Danton
2013-08-22 3:21 ` Hillf Danton
2013-08-23 3:21 ` Dave Jones
2013-08-23 3:21 ` Dave Jones
2013-08-23 3:27 ` Hillf Danton
2013-08-23 3:53 ` Dave Jones
2013-08-23 3:53 ` Dave Jones
2013-08-26 3:45 ` Hillf Danton
2013-08-26 3:45 ` Hillf Danton
2013-08-26 19:08 ` Dave Jones
2013-08-26 19:08 ` Dave Jones
2013-08-26 20:15 ` Linus Torvalds
2013-08-26 20:15 ` Linus Torvalds
2013-08-26 20:46 ` Linus Torvalds
2013-08-26 20:46 ` Linus Torvalds
2013-08-26 22:08 ` Hugh Dickins
2013-08-26 22:08 ` Hugh Dickins
2013-08-26 22:28 ` Dave Jones
2013-08-26 22:28 ` Dave Jones
2013-08-27 8:37 ` Cyrill Gorcunov
2013-08-27 8:37 ` Cyrill Gorcunov
2013-08-27 16:24 ` Dave Jones [this message]
2013-08-27 16:24 ` Dave Jones
2013-08-27 16:32 ` Cyrill Gorcunov
2013-08-27 16:32 ` Cyrill Gorcunov
2013-08-26 23:15 ` Linus Torvalds
2013-08-26 23:15 ` Linus Torvalds
2013-08-27 5:44 ` Cyrill Gorcunov
2013-08-27 5:44 ` Cyrill Gorcunov
2013-08-26 20:18 ` Cyrill Gorcunov
2013-08-26 20:18 ` Cyrill Gorcunov
2013-08-26 20:37 ` Dave Jones
2013-08-26 20:37 ` Dave Jones
2013-08-26 20:42 ` Cyrill Gorcunov
2013-08-26 20:42 ` Cyrill Gorcunov
2013-08-26 21:37 ` Cyrill Gorcunov
2013-08-26 21:37 ` Cyrill Gorcunov
2013-08-26 21:42 ` Dave Jones
2013-08-26 21:42 ` Dave Jones
2013-08-26 21:49 ` Cyrill Gorcunov
2013-08-26 21:49 ` Cyrill Gorcunov
2013-08-26 21:59 ` Dave Jones
2013-08-26 21:59 ` Dave Jones
2013-08-07 15:54 ` Dave Jones
2013-08-07 15:54 ` Dave Jones
-- strict thread matches above, loose matches on Subject: below --
2013-08-23 9:08 Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827162427.GA26717@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=gorcunov@gmail.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.