[PATCH] debugfs: provide debugfs_create_x64() when disabled

[PATCH] debugfs: provide debugfs_create_x64() when disabled

[Johannes Berg]

From: Johannes Berg <johannes.berg@intel.com>

commit 15b0beaa332b3923cc ("Add x64 support to debugfs") added
debugfs_create_x64(), but forgot to provide it when debugfs is
disabled, causing problems when code tries to use it even then.
Provide the appropriate static inline.

Cc: Huang Ying <ying.huang@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 include/linux/debugfs.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
index d68b4ea..263489d 100644
--- a/include/linux/debugfs.h
+++ b/include/linux/debugfs.h
@@ -192,6 +192,13 @@ static inline struct dentry *debugfs_create_x32(const char *name, umode_t mode,
 	return ERR_PTR(-ENODEV);
 }
 
+static inline struct dentry *debugfs_create_x64(const char *name, umode_t mode,
+						struct dentry *parent,
+						u64 *value)
+{
+	return ERR_PTR(-ENODEV);
+}
+
 static inline struct dentry *debugfs_create_size_t(const char *name, umode_t mode,
 				     struct dentry *parent,
 				     size_t *value)
-- 
1.8.4.rc3

Re: [PATCH] debugfs: provide debugfs_create_x64() when disabled

[Greg Kroah-Hartman]

On Mon, Aug 26, 2013 at 09:58:30AM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> commit 15b0beaa332b3923cc ("Add x64 support to debugfs") added
> debugfs_create_x64(), but forgot to provide it when debugfs is
> disabled, causing problems when code tries to use it even then.
> Provide the appropriate static inline.

That's funny, given that it's been this way for over 3 years without
anyone noticing :)

I'll go apply this, thanks.

greg k-h

Re: [PATCH] debugfs: provide debugfs_create_x64() when disabled

[Johannes Berg]

On Tue, 2013-08-27 at 22:08 -0700, Greg Kroah-Hartman wrote:
> On Mon, Aug 26, 2013 at 09:58:30AM +0200, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> > 
> > commit 15b0beaa332b3923cc ("Add x64 support to debugfs") added
> > debugfs_create_x64(), but forgot to provide it when debugfs is
> > disabled, causing problems when code tries to use it even then.
> > Provide the appropriate static inline.
> 
> That's funny, given that it's been this way for over 3 years without
> anyone noticing :)

Heh. I only noticed because the ath9k driver was broken and selected
mac80211 debugfs without regard for DEBUG_FS configuration, and thus it
failed compile on this. This is a Kconfig bug, so I don't really need
this inline and it will never get used, but I figured debugfs has all
inlines so it should have this one as well.

johannes