All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kumar Gaurav <kumargauravgupta3@gmail.com>
Cc: sarah.a.sharp@linux.intel.com, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call
Date: Wed, 28 Aug 2013 07:13:04 +0000	[thread overview]
Message-ID: <20130828071304.GO6329@mwanda> (raw)
In-Reply-To: <1377482937-7486-1-git-send-email-kumargauravgupta3@gmail.com>

On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote:
> This patch redefine function xhci_readl.xhci_readl function doesn't use xhci_hcd argument.
> Hence there is no need of keeping it in the function arguments. 
> 
> Redefining this function breaks other functions which calls this function.
> This phatch also correct those calls in xhci driver. 
> 
> Signed-off-by: Kumar Gaurav <kumargauravgupta3@gmail.com>
> ---

Could you put a list of changes since v2 here?:

v3:  blah blah changelog mostly.

Also this doesn't apply for me against linux-next.

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kumar Gaurav <kumargauravgupta3@gmail.com>
Cc: sarah.a.sharp@linux.intel.com, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call
Date: Wed, 28 Aug 2013 10:13:04 +0300	[thread overview]
Message-ID: <20130828071304.GO6329@mwanda> (raw)
In-Reply-To: <1377482937-7486-1-git-send-email-kumargauravgupta3@gmail.com>

On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote:
> This patch redefine function xhci_readl.xhci_readl function doesn't use xhci_hcd argument.
> Hence there is no need of keeping it in the function arguments. 
> 
> Redefining this function breaks other functions which calls this function.
> This phatch also correct those calls in xhci driver. 
> 
> Signed-off-by: Kumar Gaurav <kumargauravgupta3@gmail.com>
> ---

Could you put a list of changes since v2 here?:

v3:  blah blah changelog mostly.

Also this doesn't apply for me against linux-next.

regards,
dan carpenter


  reply	other threads:[~2013-08-28  7:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26  2:08 [PATCH v3] xHCI: Fixing xhci_readl definition and function call Kumar Gaurav
2013-08-26  2:20 ` Kumar Gaurav
2013-08-28  7:13 ` Dan Carpenter [this message]
2013-08-28  7:13   ` Dan Carpenter
2013-08-28 15:09   ` Kumar Gaurav
2013-08-28 15:21     ` Kumar Gaurav
2013-08-28 17:01     ` Sarah Sharp
2013-08-28 17:01       ` Sarah Sharp
2013-08-28 17:15       ` Kumar Gaurav
2013-08-28 17:27         ` Kumar Gaurav
2013-08-28 17:35         ` Sarah Sharp
2013-08-28 17:35           ` Sarah Sharp
2013-08-28 19:15     ` Dan Carpenter
2013-08-28 19:15       ` Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2013-08-22  3:04 Kumar Gaurav
2013-08-22  3:16 ` Kumar Gaurav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130828071304.GO6329@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kumargauravgupta3@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sarah.a.sharp@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.