All of lore.kernel.org
 help / color / mirror / Atom feed
From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: integrator: Make sure INTEGRATOR_AP depends on PCI
Date: Wed, 28 Aug 2013 09:55:50 +0200	[thread overview]
Message-ID: <20130828075549.GF20372@8bytes.org> (raw)
In-Reply-To: <CACRpkdZVAG=0zvLbR4E+UEjHUaYOgqUxsfGoZybPtm1DwDAJ1Q@mail.gmail.com>

On Wed, Aug 28, 2013 at 09:26:57AM +0200, Linus Walleij wrote:
> On Wed, Aug 14, 2013 at 10:04 PM, Joerg Roedel <joro@8bytes.org> wrote:
> 
> > So when integrator does not depend on PCI this diff is more appropriate?
> >
> > diff --git a/arch/arm/mach-integrator/pci_v3.h b/arch/arm/mach-integrator/pci_v3.h
> > index 755fd29..51738e0 100644
> > --- a/arch/arm/mach-integrator/pci_v3.h
> > +++ b/arch/arm/mach-integrator/pci_v3.h
> > @@ -1,2 +1,9 @@
> > -/* Simple oneliner include to the PCIv3 early init */
> > +/* Define PCIv3 early init */
> > +#ifdef CONFIG_PCI
> >  extern int pci_v3_early_init(void);
> > +#else
> > +static inline int pci_v3_early_init(void)
> > +{
> > +       return 0;
> > +}
> > +#endif
> 
> Yes.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> And can you please create and send a proper patch with this
> content to arm at kernel.org and the mailing list on CC, with
> a request for the ARM SoC maintainers to apply it directly
> as a fix?
> 
> You might as well add Cc: stable at vger.kernel.org as well.

Will do, thanks for your review.

Cheers,

	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: integrator: Make sure INTEGRATOR_AP depends on PCI
Date: Wed, 28 Aug 2013 09:55:50 +0200	[thread overview]
Message-ID: <20130828075549.GF20372@8bytes.org> (raw)
In-Reply-To: <CACRpkdZVAG=0zvLbR4E+UEjHUaYOgqUxsfGoZybPtm1DwDAJ1Q@mail.gmail.com>

On Wed, Aug 28, 2013 at 09:26:57AM +0200, Linus Walleij wrote:
> On Wed, Aug 14, 2013 at 10:04 PM, Joerg Roedel <joro@8bytes.org> wrote:
> 
> > So when integrator does not depend on PCI this diff is more appropriate?
> >
> > diff --git a/arch/arm/mach-integrator/pci_v3.h b/arch/arm/mach-integrator/pci_v3.h
> > index 755fd29..51738e0 100644
> > --- a/arch/arm/mach-integrator/pci_v3.h
> > +++ b/arch/arm/mach-integrator/pci_v3.h
> > @@ -1,2 +1,9 @@
> > -/* Simple oneliner include to the PCIv3 early init */
> > +/* Define PCIv3 early init */
> > +#ifdef CONFIG_PCI
> >  extern int pci_v3_early_init(void);
> > +#else
> > +static inline int pci_v3_early_init(void)
> > +{
> > +       return 0;
> > +}
> > +#endif
> 
> Yes.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> And can you please create and send a proper patch with this
> content to arm@kernel.org and the mailing list on CC, with
> a request for the ARM SoC maintainers to apply it directly
> as a fix?
> 
> You might as well add Cc: stable@vger.kernel.org as well.

Will do, thanks for your review.

Cheers,

	Joerg



  reply	other threads:[~2013-08-28  7:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14 19:50 [PATCH] ARM: integrator: Make sure INTEGRATOR_AP depends on PCI Joerg Roedel
2013-08-14 19:50 ` Joerg Roedel
2013-08-14 19:57 ` Russell King - ARM Linux
2013-08-14 19:57   ` Russell King - ARM Linux
2013-08-14 20:04   ` Joerg Roedel
2013-08-14 20:04     ` Joerg Roedel
2013-08-28  7:26     ` Linus Walleij
2013-08-28  7:26       ` Linus Walleij
2013-08-28  7:55       ` Joerg Roedel [this message]
2013-08-28  7:55         ` Joerg Roedel
2013-09-25 10:13       ` Joerg Roedel
2013-09-25 10:13         ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130828075549.GF20372@8bytes.org \
    --to=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.