From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mikko Perttunen <mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/5] ARM: tegra: Add hdmi to Tegra114 Dalmore device tree
Date: Wed, 28 Aug 2013 14:30:08 +0200 [thread overview]
Message-ID: <20130828123008.GC32254@ulmo> (raw)
In-Reply-To: <1377686459-16634-6-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
On Wed, Aug 28, 2013 at 01:40:59PM +0300, Mikko Perttunen wrote:
> Add hdmi node to Dalmore device tree to supply Dalmore-specific
s/hdmi/HDMI/
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
[...]
> + host1x {
> + hdmi {
> + status = "okay";
> +
> + vdd-supply = <&vdd_hdmi_reg>;
> + pll-supply = <&palmas_smps3_reg>;
> + nvidia,ddc-i2c-bus = <&hdmi_ddc>;
I prefer to use a blank line to separate "standard" from
"vendor-specific" properties.
> + nvidia,hpd-gpio = <&gpio TEGRA_GPIO(N, 7) GPIO_ACTIVE_HIGH>;
Other .dts files split this so it doesn't exceed 80 characters. I'm not
sure how useful that is as a general rule for DT source files, though.
> i2c@7000d000 {
> status = "okay";
> clock-frequency = <400000>;
> @@ -1169,6 +1184,8 @@
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> enable-active-high;
> + regulator-always-on;
> + regulator-boot-on;
This warrants at least a mention in the commit message.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Mikko Perttunen <mperttunen@nvidia.com>
Cc: tbergstrom@nvidia.com, dri-devel@lists.freedesktop.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] ARM: tegra: Add hdmi to Tegra114 Dalmore device tree
Date: Wed, 28 Aug 2013 14:30:08 +0200 [thread overview]
Message-ID: <20130828123008.GC32254@ulmo> (raw)
In-Reply-To: <1377686459-16634-6-git-send-email-mperttunen@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
On Wed, Aug 28, 2013 at 01:40:59PM +0300, Mikko Perttunen wrote:
> Add hdmi node to Dalmore device tree to supply Dalmore-specific
s/hdmi/HDMI/
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
[...]
> + host1x {
> + hdmi {
> + status = "okay";
> +
> + vdd-supply = <&vdd_hdmi_reg>;
> + pll-supply = <&palmas_smps3_reg>;
> + nvidia,ddc-i2c-bus = <&hdmi_ddc>;
I prefer to use a blank line to separate "standard" from
"vendor-specific" properties.
> + nvidia,hpd-gpio = <&gpio TEGRA_GPIO(N, 7) GPIO_ACTIVE_HIGH>;
Other .dts files split this so it doesn't exceed 80 characters. I'm not
sure how useful that is as a general rule for DT source files, though.
> i2c@7000d000 {
> status = "okay";
> clock-frequency = <400000>;
> @@ -1169,6 +1184,8 @@
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> enable-active-high;
> + regulator-always-on;
> + regulator-boot-on;
This warrants at least a mention in the commit message.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-28 12:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 10:40 [PATCH 0/5] HDMI support for Tegra114 Dalmore Mikko Perttunen
2013-08-28 10:40 ` Mikko Perttunen
2013-08-28 10:40 ` [PATCH 1/5] host1x: hdmi: Add Tegra114 support Mikko Perttunen
2013-08-28 10:40 ` Mikko Perttunen
[not found] ` <1377686459-16634-1-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-28 10:40 ` [PATCH 2/5] host1x: hdmi: Detect whether display is connected with HDMI or DVI Mikko Perttunen
2013-08-28 10:40 ` Mikko Perttunen
2013-08-28 12:07 ` Thierry Reding
2013-08-28 12:34 ` Mikko Perttunen
2013-08-28 12:34 ` Mikko Perttunen
[not found] ` <521DEE6D.4050503-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-28 13:16 ` Thierry Reding
2013-08-28 13:16 ` Thierry Reding
2013-08-28 10:40 ` [PATCH 3/5] clk: tegra114: Initialize clocks needed for HDMI Mikko Perttunen
2013-08-28 10:40 ` Mikko Perttunen
2013-08-28 10:40 ` [PATCH 4/5] ARM: tegra: Add host1x, dc and hdmi to Tegra114 device tree Mikko Perttunen
2013-08-28 10:40 ` Mikko Perttunen
[not found] ` <1377686459-16634-5-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-28 12:25 ` Thierry Reding
2013-08-28 12:25 ` Thierry Reding
2013-08-28 12:41 ` Mikko Perttunen
2013-08-28 12:41 ` Mikko Perttunen
[not found] ` <521DEFFF.90507-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-28 13:18 ` Thierry Reding
2013-08-28 13:18 ` Thierry Reding
2013-08-29 6:52 ` Terje Bergström
2013-08-29 6:52 ` Terje Bergström
2013-08-28 10:40 ` [PATCH 5/5] ARM: tegra: Add hdmi to Tegra114 Dalmore " Mikko Perttunen
2013-08-28 10:40 ` Mikko Perttunen
[not found] ` <1377686459-16634-6-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-28 12:30 ` Thierry Reding [this message]
2013-08-28 12:30 ` Thierry Reding
2013-08-28 12:49 ` Mikko Perttunen
2013-08-28 12:49 ` Mikko Perttunen
[not found] ` <521DF1E9.7050504-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-28 13:25 ` Thierry Reding
2013-08-28 13:25 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828123008.GC32254@ulmo \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.