From: Dave Jones <davej@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Vince Weaver <vince@deater.net>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: FTRACE_WARN_ON((rec->flags & ~FTRACE_FL_MASK) == 0))
Date: Wed, 28 Aug 2013 13:33:04 -0400 [thread overview]
Message-ID: <20130828173304.GA6776@redhat.com> (raw)
In-Reply-To: <20130828125701.1ca6ccd0@gandalf.local.home>
On Wed, Aug 28, 2013 at 12:57:01PM -0400, Steven Rostedt wrote:
> Dave, I'm assuming that trinidy does things as threads, such that it
> may be two threads calling perf with the same descriptor, and if we
> don't have the proper locks, things can get bad, right?
>
close. It does use as many processes as there are cpus (unless you override with -C)
but the fd's created by perf_event_open were only being used within the thread
that created them. I just committed code to make it also reuse some shared ones
created from the parent process.
Dave
next prev parent reply other threads:[~2013-08-28 17:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 3:46 FTRACE_WARN_ON((rec->flags & ~FTRACE_FL_MASK) == 0)) Dave Jones
2013-08-28 13:54 ` Steven Rostedt
2013-08-28 13:58 ` Steven Rostedt
2013-08-28 15:17 ` Steven Rostedt
2013-08-28 18:27 ` Dave Jones
2013-08-28 18:29 ` Dave Jones
2013-08-28 19:27 ` Steven Rostedt
2013-09-30 17:12 ` Dave Jones
2013-10-01 3:56 ` Steven Rostedt
2013-10-01 4:20 ` Dave Jones
2013-10-01 12:28 ` Steven Rostedt
2013-10-02 14:16 ` Dave Jones
2013-10-02 16:43 ` Steven Rostedt
2013-10-02 16:53 ` Dave Jones
2013-08-28 14:31 ` Steven Rostedt
2013-08-28 16:23 ` Dave Jones
2013-08-28 16:50 ` Vince Weaver
2013-08-28 16:57 ` Steven Rostedt
2013-08-28 17:33 ` Dave Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-30 4:16 Dave Jones
2014-01-30 4:50 ` Steven Rostedt
2014-01-30 5:32 ` Dave Jones
2014-01-30 13:55 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828173304.GA6776@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.