All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: FTRACE_WARN_ON((rec->flags & ~FTRACE_FL_MASK) == 0))
Date: Mon, 30 Sep 2013 13:12:01 -0400	[thread overview]
Message-ID: <20130930171201.GA10474@redhat.com> (raw)
In-Reply-To: <20130828152745.18a73c4e@gandalf.local.home>

On Wed, Aug 28, 2013 at 03:27:45PM -0400, Steven Rostedt wrote:

 > > [ 6619.050768] WARNING: CPU: 1 PID: 16351 at kernel/trace/ftrace.c:1640 __ftrace_hash_rec_update.part.37+0x20a/0x240()
 > > [ 6619.053767] Modules linked in: lec snd_seq_dummy bridge stp fuse tun bnep hidp rfcomm nfnetlink ipt_ULOG scsi_transport_iscsi can_bcm can_raw nfc caif_socket caif af_802154 phonet af_rxrpc bluetooth rfkill can llc2 pppoe pppox ppp_generic slhc irda crc_ccitt rds af_key rose x25 atm netrom appletalk ipx p8023 psnap p8022 llc ax25 xfs libcrc32c snd_hda_codec_realtek snd_hda_intel snd_hda_codec snd_hwdep snd_seq snd_seq_device snd_pcm snd_page_alloc e1000e ptp snd_timer pcspkr pps_core snd soundcore usb_debug
 > > [ 6619.060523] CPU: 1 PID: 16351 Comm: trinity-child2 Not tainted 3.11.0-rc7+ #31 
 > > [ 6619.062161]  ffffffff81a21901 ffff8802267b9ce0 ffffffff816f9e4f 0000000000000000
 > > [ 6619.063733]  ffff8802267b9d18 ffffffff81052dcd 0000000000000000 0000000000000001
 > > [ 6619.065309]  ffff8802203a3000 0000000000000000 ffff880225e962d0 ffff8802267b9d28
 > > [ 6619.066895] Call Trace:
 > > [ 6619.068437]  [<ffffffff816f9e4f>] dump_stack+0x54/0x74
 > > [ 6619.070046]  [<ffffffff81052dcd>] warn_slowpath_common+0x7d/0xa0
 > > [ 6619.071642]  [<ffffffff81052eaa>] warn_slowpath_null+0x1a/0x20
 > > [ 6619.073224]  [<ffffffff81115d1a>] __ftrace_hash_rec_update.part.37+0x20a/0x240
 > > [ 6619.074817]  [<ffffffff81117e18>] ftrace_shutdown+0xb8/0x160
 > > [ 6619.076399]  [<ffffffff811182a0>] unregister_ftrace_function+0x30/0x50
 > > [ 6619.077983]  [<ffffffff81135e57>] perf_ftrace_event_register+0x87/0x150
 > > [ 6619.079565]  [<ffffffff81135cdc>] perf_trace_destroy+0x2c/0x50
 > > [ 6619.081180]  [<ffffffff8113df49>] tp_perf_event_destroy+0x9/0x10
 > > [ 6619.082742]  [<ffffffff81140527>] free_event+0xa7/0x300
 > > [ 6619.084264]  [<ffffffff81141620>] __perf_event_exit_task+0xe0/0x130
 > > [ 6619.085792]  [<ffffffff8114a491>] perf_event_exit_task+0x1f1/0x230
 > > [ 6619.087329]  [<ffffffff810546dd>] do_exit+0x30d/0xcd0
 > > [ 6619.088860]  [<ffffffff8170cfc0>] ? ftrace_call+0x5/0x2f
 > > [ 6619.090460]  [<ffffffff8105643c>] do_group_exit+0x4c/0xc0
 > > [ 6619.092036]  [<ffffffff810564c4>] SyS_exit_group+0x14/0x20
 > > [ 6619.093614]  [<ffffffff8170d594>] tracesys+0xdd/0xe2
 >
 > The first failure disables function tracing completely, which is one of
 > the causes to return an error, which triggered the warning I added.
 > 
 > I was hoping that it failed for another reason and then that would
 > cause things to break. But you said the hash corruption happened first
 > (the original bug), so that's not the case.
 > 
 > Back to staring at code.

Steve, any further thoughts on this ? I can't do more than a few hours of fuzz-testing
without eventually running into this.

	Dave
 

  reply	other threads:[~2013-09-30 17:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28  3:46 FTRACE_WARN_ON((rec->flags & ~FTRACE_FL_MASK) == 0)) Dave Jones
2013-08-28 13:54 ` Steven Rostedt
2013-08-28 13:58   ` Steven Rostedt
2013-08-28 15:17     ` Steven Rostedt
2013-08-28 18:27       ` Dave Jones
2013-08-28 18:29         ` Dave Jones
2013-08-28 19:27           ` Steven Rostedt
2013-09-30 17:12             ` Dave Jones [this message]
2013-10-01  3:56               ` Steven Rostedt
2013-10-01  4:20                 ` Dave Jones
2013-10-01 12:28                   ` Steven Rostedt
2013-10-02 14:16                     ` Dave Jones
2013-10-02 16:43                       ` Steven Rostedt
2013-10-02 16:53                         ` Dave Jones
2013-08-28 14:31 ` Steven Rostedt
2013-08-28 16:23   ` Dave Jones
2013-08-28 16:50     ` Vince Weaver
2013-08-28 16:57       ` Steven Rostedt
2013-08-28 17:33         ` Dave Jones
  -- strict thread matches above, loose matches on Subject: below --
2014-01-30  4:16 Dave Jones
2014-01-30  4:50 ` Steven Rostedt
2014-01-30  5:32   ` Dave Jones
2014-01-30 13:55     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130930171201.GA10474@redhat.com \
    --to=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.