Re: [PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support

["Zubair Lutfullah :" <zubair.lutfullah@gmail.com>]

On Wed, Aug 28, 2013 at 08:35:30PM +0200, Sebastian Andrzej Siewior wrote:
> On 08/28/2013 08:19 PM, Zubair Lutfullah : wrote:
> > On Wed, Aug 28, 2013 at 06:43:08PM +0200, Sebastian Andrzej Siewior wrote:
> >> * Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
> >>
> >>> diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
> >>> index a952538..ae2202b 100644
> >>> --- a/drivers/iio/adc/ti_am335x_adc.c
> >>> +++ b/drivers/iio/adc/ti_am335x_adc.c
> >>> @@ -231,28 +406,56 @@ static int tiadc_probe(struct platform_device *pdev)
> >> …
> >>> +err_free_device:
> >>> +	iio_device_free(indio_dev);
> >>
> >> I am not sure about this one.
> > 
> > If I understand correctly, if devm_iio_device_alloc 
> > is successful earlier in the code and subsequent stuff fails. 
> > 
> > Then the code jumps to err_free_device and this is needed.
> 
> Yes, but devm_() helper release the memory on failer _or_ device /
> driver removal.
I see. 

> >>> @@ -262,11 +465,14 @@ static int tiadc_remove(struct platform_device *pdev)
> >>> 	struct tiadc_device *adc_dev = iio_priv(indio_dev);
...
> >>> 	am335x_tsc_se_clr(adc_dev->mfd_tscadc, step_en);
> >>> +	iio_device_free(indio_dev);
...
> Point me one driver please. Do they use devm_iio_device_alloc() like
> you do or iio_device_alloc()? In case of the latter you need to
> manually free the memory.
Aah. So the devm_* stuff makes the difference.
Thanks for pointing it out. Will remove it.

ZubairLK