Re: [PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support

[Sebastian Andrzej Siewior <bigeasy@linutronix.de>]

On 08/28/2013 08:59 PM, Zubair Lutfullah : wrote:
>>>>> 	am335x_tsc_se_clr(adc_dev->mfd_tscadc, step_en);
>>>>> +	iio_device_free(indio_dev);
> ...
>> Point me one driver please. Do they use devm_iio_device_alloc() like
>> you do or iio_device_alloc()? In case of the latter you need to
>> manually free the memory.
> Aah. So the devm_* stuff makes the difference.
> Thanks for pointing it out. Will remove it.

Yes, devm_* stuff. There is also matching kmalloc() version of it for
the very same purpose and a few others…

In future please post a bugfix (adding iio_device_free() to plug a
memory leak) as a separate patch. It has nothing todo with "continuous
sampling support" and it case it is valid it could be applied
independantly and ported back to earlier kernel if necessary. The way
you did here you just "silently" plugged a memory leak.

> 
> ZubairLK
> 

Sebastian