From: Grant Likely <grant.likely@linaro.org>
To: Rob Herring <rob.herring@calxeda.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v2] of_net.h: Make of_get_phy_mode() return int i.s.o. const int
Date: Wed, 28 Aug 2013 20:51:03 +0100 [thread overview]
Message-ID: <20130828195103.1C90E3E0AF4@localhost> (raw)
In-Reply-To: <1376823690-29179-1-git-send-email-geert@linux-m68k.org>
On Sun, 18 Aug 2013 13:01:30 +0200, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> include/linux/of_net.h:16: warning: type qualifiers ignored on function return type
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
Applied, thanks.
g.
> v2: update the actual function in drivers/of/of_net.c.
>
> drivers/of/of_net.c | 2 +-
> include/linux/of_net.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/of/of_net.c b/drivers/of/of_net.c
> index ea174c8..8f9be2e 100644
> --- a/drivers/of/of_net.c
> +++ b/drivers/of/of_net.c
> @@ -39,7 +39,7 @@ static const char *phy_modes[] = {
> * The function gets phy interface string from property 'phy-mode',
> * and return its index in phy_modes table, or errno in error case.
> */
> -const int of_get_phy_mode(struct device_node *np)
> +int of_get_phy_mode(struct device_node *np)
> {
> const char *pm;
> int err, i;
> diff --git a/include/linux/of_net.h b/include/linux/of_net.h
> index 61bf53b..34597c8 100644
> --- a/include/linux/of_net.h
> +++ b/include/linux/of_net.h
> @@ -9,10 +9,10 @@
>
> #ifdef CONFIG_OF_NET
> #include <linux/of.h>
> -extern const int of_get_phy_mode(struct device_node *np);
> +extern int of_get_phy_mode(struct device_node *np);
> extern const void *of_get_mac_address(struct device_node *np);
> #else
> -static inline const int of_get_phy_mode(struct device_node *np)
> +static inline int of_get_phy_mode(struct device_node *np)
> {
> return -ENODEV;
> }
> --
> 1.7.9.5
>
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Rob Herring <rob.herring@calxeda.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v2] of_net.h: Make of_get_phy_mode() return int i.s.o. const int
Date: Wed, 28 Aug 2013 20:51:03 +0100 [thread overview]
Message-ID: <20130828195103.1C90E3E0AF4@localhost> (raw)
In-Reply-To: <1376823690-29179-1-git-send-email-geert@linux-m68k.org>
On Sun, 18 Aug 2013 13:01:30 +0200, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> include/linux/of_net.h:16: warning: type qualifiers ignored on function return type
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
Applied, thanks.
g.
> v2: update the actual function in drivers/of/of_net.c.
>
> drivers/of/of_net.c | 2 +-
> include/linux/of_net.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/of/of_net.c b/drivers/of/of_net.c
> index ea174c8..8f9be2e 100644
> --- a/drivers/of/of_net.c
> +++ b/drivers/of/of_net.c
> @@ -39,7 +39,7 @@ static const char *phy_modes[] = {
> * The function gets phy interface string from property 'phy-mode',
> * and return its index in phy_modes table, or errno in error case.
> */
> -const int of_get_phy_mode(struct device_node *np)
> +int of_get_phy_mode(struct device_node *np)
> {
> const char *pm;
> int err, i;
> diff --git a/include/linux/of_net.h b/include/linux/of_net.h
> index 61bf53b..34597c8 100644
> --- a/include/linux/of_net.h
> +++ b/include/linux/of_net.h
> @@ -9,10 +9,10 @@
>
> #ifdef CONFIG_OF_NET
> #include <linux/of.h>
> -extern const int of_get_phy_mode(struct device_node *np);
> +extern int of_get_phy_mode(struct device_node *np);
> extern const void *of_get_mac_address(struct device_node *np);
> #else
> -static inline const int of_get_phy_mode(struct device_node *np)
> +static inline int of_get_phy_mode(struct device_node *np)
> {
> return -ENODEV;
> }
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-08-28 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-18 11:01 [PATCH v2] of_net.h: Make of_get_phy_mode() return int i.s.o. const int Geert Uytterhoeven
2013-08-28 19:51 ` Grant Likely [this message]
2013-08-28 19:51 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2013-05-16 17:01 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828195103.1C90E3E0AF4@localhost \
--to=grant.likely@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.