All of lore.kernel.org
 help / color / mirror / Atom feed
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 3/4] drivers: of: add initialization code for dma reserved memory
Date: Thu, 29 Aug 2013 22:20:54 +0100	[thread overview]
Message-ID: <20130829212054.568123E1222@localhost> (raw)
In-Reply-To: <2011590.EGDykoeEOS@amdc1227>

On Wed, 21 Aug 2013 17:39:48 +0200, Tomasz Figa <t.figa@samsung.com> wrote:
> On Tuesday 20 of August 2013 10:35:51 Stephen Warren wrote:
> > >> a) Adjust memory.txt to allow multiple entries in memory-regions, and
> > >> add an associated memory-region-names property.
> > >> 
> > I don't believe that's a good approach unless you have at least a
> > partial idea of how the current bindings will be extended to support
> > multiple memory regions.
> 
> I believe that at least three "at least partial" ideas have been brought in 
> this thread. Moreover, I don't think that defining the simple binding now 
> would stop us from extending it according to any of those ideas in any way.

I would plan on extending later with suggestion 'a)' above. Making the
memory-region an array of phandles is a better match with how most of
the core bindings work.  I actually regret the *-gpio properties that
were defined earlier becasue it makes it harder for software to look at
a tree and determine if there are any gpio references.

It of course doesn't need to be done immediately, only when it becomes
required.

g.

WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Tomasz Figa <t.figa@samsung.com>, Stephen Warren <swarren@wwwdotorg.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Laura Abbott <lauraa@codeaurora.org>,
	Pawel Moll <pawel.moll@arm.com>, Arnd Bergmann <arnd@arndb.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	linaro-mm-sig@lists.linaro.org, Marc <marc.ceeeee@gmail.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Kumar Gala <galak@codeaurora.org>,
	Olof Johansson <olof@lixom.net>,
	Ian Campbell <ian.campbell@citrix.com>,
	Nishanth Peethambaran <nishanth.p@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v6 3/4] drivers: of: add initialization code for dma reserved memory
Date: Thu, 29 Aug 2013 22:20:54 +0100	[thread overview]
Message-ID: <20130829212054.568123E1222@localhost> (raw)
In-Reply-To: <2011590.EGDykoeEOS@amdc1227>

On Wed, 21 Aug 2013 17:39:48 +0200, Tomasz Figa <t.figa@samsung.com> wrote:
> On Tuesday 20 of August 2013 10:35:51 Stephen Warren wrote:
> > >> a) Adjust memory.txt to allow multiple entries in memory-regions, and
> > >> add an associated memory-region-names property.
> > >> 
> > I don't believe that's a good approach unless you have at least a
> > partial idea of how the current bindings will be extended to support
> > multiple memory regions.
> 
> I believe that at least three "at least partial" ideas have been brought in 
> this thread. Moreover, I don't think that defining the simple binding now 
> would stop us from extending it according to any of those ideas in any way.

I would plan on extending later with suggestion 'a)' above. Making the
memory-region an array of phandles is a better match with how most of
the core bindings work.  I actually regret the *-gpio properties that
were defined earlier becasue it makes it harder for software to look at
a tree and determine if there are any gpio references.

It of course doesn't need to be done immediately, only when it becomes
required.

g.

  reply	other threads:[~2013-08-29 21:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 15:04 [PATCH v6 0/4] Device Tree support for CMA (Contiguous Memory Allocator) Marek Szyprowski
2013-08-19 15:04 ` [PATCH v6 1/4] drivers: dma-contiguous: clean source code and prepare for device tree Marek Szyprowski
2013-08-19 15:04 ` [PATCH v6 2/4] drivers: of: add function to scan fdt nodes given by path Marek Szyprowski
2013-08-26 12:09   ` Rob Herring
2013-08-26 12:09     ` Rob Herring
2013-08-19 15:04 ` [PATCH v6 3/4] drivers: of: add initialization code for dma reserved memory Marek Szyprowski
2013-08-19 21:49   ` Stephen Warren
2013-08-19 22:02     ` Tomasz Figa
2013-08-19 22:17       ` Stephen Warren
2013-08-19 22:24         ` Tomasz Figa
2013-08-19 22:27           ` Stephen Warren
2013-08-19 22:40             ` Tomasz Figa
2013-08-19 22:54               ` Stephen Warren
2013-08-20 10:57         ` Marek Szyprowski
2013-08-20 16:35           ` Stephen Warren
2013-08-21 14:38             ` Marek Szyprowski
2013-08-22 20:08               ` Stephen Warren
2013-08-21 15:39             ` Tomasz Figa
2013-08-29 21:20               ` Grant Likely [this message]
2013-08-29 21:20                 ` Grant Likely
2013-08-29 21:12       ` Grant Likely
2013-08-29 21:12         ` Grant Likely
2013-08-21 15:56   ` Matt Sealey
     [not found]   ` <1377247141-11284-1-git-send-email-m.szyprowski@samsung.com>
2013-08-23 19:27     ` [PATCH v6 3/4 UPDATED] " Stephen Warren
2013-08-26 12:20   ` [PATCH v6 3/4] " Rob Herring
2013-08-26 12:20     ` Rob Herring
2013-08-19 15:04 ` [PATCH v6 4/4] ARM: init: add support for reserved memory defined by device tree Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130829212054.568123E1222@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.