All of lore.kernel.org
 help / color / mirror / Atom feed
From: konrad.wilk@oracle.com (Konrad Rzeszutek Wilk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 07/13] xen: make xen_create_contiguous_region return the dma address
Date: Fri, 30 Aug 2013 09:45:11 -0400	[thread overview]
Message-ID: <20130830134511.GJ21239@phenom.dumpdata.com> (raw)
In-Reply-To: <1377801154-29215-7-git-send-email-stefano.stabellini@eu.citrix.com>

On Thu, Aug 29, 2013 at 07:32:28PM +0100, Stefano Stabellini wrote:
> Modify xen_create_contiguous_region to return the dma address of the
> newly contiguous buffer.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Reviewed-by: David Vrabel <david.vrabel@citrix.com>

Acked-by or Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> 
> Changes in v4:
> - use virt_to_machine instead of virt_to_bus.
> ---
>  arch/x86/xen/mmu.c        |    4 +++-
>  drivers/xen/swiotlb-xen.c |    6 +++---
>  include/xen/xen-ops.h     |    3 ++-
>  3 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index fdc3ba2..6c34d7c 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -2329,7 +2329,8 @@ static int xen_exchange_memory(unsigned long extents_in, unsigned int order_in,
>  }
>  
>  int xen_create_contiguous_region(unsigned long vstart, unsigned int order,
> -				 unsigned int address_bits)
> +				 unsigned int address_bits,
> +				 dma_addr_t *dma_handle)
>  {
>  	unsigned long *in_frames = discontig_frames, out_frame;
>  	unsigned long  flags;
> @@ -2368,6 +2369,7 @@ int xen_create_contiguous_region(unsigned long vstart, unsigned int order,
>  
>  	spin_unlock_irqrestore(&xen_reservation_lock, flags);
>  
> +	*dma_handle = virt_to_machine(vstart).maddr;
>  	return success ? 0 : -ENOMEM;
>  }
>  EXPORT_SYMBOL_GPL(xen_create_contiguous_region);
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index 1b2277c..b72f31c 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -126,6 +126,7 @@ xen_swiotlb_fixup(void *buf, size_t size, unsigned long nslabs)
>  {
>  	int i, rc;
>  	int dma_bits;
> +	dma_addr_t dma_handle;
>  
>  	dma_bits = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT) + PAGE_SHIFT;
>  
> @@ -137,7 +138,7 @@ xen_swiotlb_fixup(void *buf, size_t size, unsigned long nslabs)
>  			rc = xen_create_contiguous_region(
>  				(unsigned long)buf + (i << IO_TLB_SHIFT),
>  				get_order(slabs << IO_TLB_SHIFT),
> -				dma_bits);
> +				dma_bits, &dma_handle);
>  		} while (rc && dma_bits++ < max_dma_bits);
>  		if (rc)
>  			return rc;
> @@ -294,11 +295,10 @@ xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
>  		*dma_handle = dev_addr;
>  	else {
>  		if (xen_create_contiguous_region(vstart, order,
> -						 fls64(dma_mask)) != 0) {
> +						 fls64(dma_mask), dma_handle) != 0) {
>  			free_pages(vstart, order);
>  			return NULL;
>  		}
> -		*dma_handle = virt_to_machine(ret).maddr;
>  	}
>  	memset(ret, 0, size);
>  	return ret;
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index d6fe062..9ef704d 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -20,7 +20,8 @@ int xen_setup_shutdown_event(void);
>  
>  extern unsigned long *xen_contiguous_bitmap;
>  int xen_create_contiguous_region(unsigned long vstart, unsigned int order,
> -				unsigned int address_bits);
> +				unsigned int address_bits,
> +				dma_addr_t *dma_handle);
>  
>  void xen_destroy_contiguous_region(unsigned long vstart, unsigned int order);
>  
> -- 
> 1.7.2.5
> 

WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Ian.Campbell@citrix.com
Subject: Re: [PATCH v5 07/13] xen: make xen_create_contiguous_region return the dma address
Date: Fri, 30 Aug 2013 09:45:11 -0400	[thread overview]
Message-ID: <20130830134511.GJ21239@phenom.dumpdata.com> (raw)
In-Reply-To: <1377801154-29215-7-git-send-email-stefano.stabellini@eu.citrix.com>

On Thu, Aug 29, 2013 at 07:32:28PM +0100, Stefano Stabellini wrote:
> Modify xen_create_contiguous_region to return the dma address of the
> newly contiguous buffer.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Reviewed-by: David Vrabel <david.vrabel@citrix.com>

Acked-by or Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> 
> Changes in v4:
> - use virt_to_machine instead of virt_to_bus.
> ---
>  arch/x86/xen/mmu.c        |    4 +++-
>  drivers/xen/swiotlb-xen.c |    6 +++---
>  include/xen/xen-ops.h     |    3 ++-
>  3 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index fdc3ba2..6c34d7c 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -2329,7 +2329,8 @@ static int xen_exchange_memory(unsigned long extents_in, unsigned int order_in,
>  }
>  
>  int xen_create_contiguous_region(unsigned long vstart, unsigned int order,
> -				 unsigned int address_bits)
> +				 unsigned int address_bits,
> +				 dma_addr_t *dma_handle)
>  {
>  	unsigned long *in_frames = discontig_frames, out_frame;
>  	unsigned long  flags;
> @@ -2368,6 +2369,7 @@ int xen_create_contiguous_region(unsigned long vstart, unsigned int order,
>  
>  	spin_unlock_irqrestore(&xen_reservation_lock, flags);
>  
> +	*dma_handle = virt_to_machine(vstart).maddr;
>  	return success ? 0 : -ENOMEM;
>  }
>  EXPORT_SYMBOL_GPL(xen_create_contiguous_region);
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index 1b2277c..b72f31c 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -126,6 +126,7 @@ xen_swiotlb_fixup(void *buf, size_t size, unsigned long nslabs)
>  {
>  	int i, rc;
>  	int dma_bits;
> +	dma_addr_t dma_handle;
>  
>  	dma_bits = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT) + PAGE_SHIFT;
>  
> @@ -137,7 +138,7 @@ xen_swiotlb_fixup(void *buf, size_t size, unsigned long nslabs)
>  			rc = xen_create_contiguous_region(
>  				(unsigned long)buf + (i << IO_TLB_SHIFT),
>  				get_order(slabs << IO_TLB_SHIFT),
> -				dma_bits);
> +				dma_bits, &dma_handle);
>  		} while (rc && dma_bits++ < max_dma_bits);
>  		if (rc)
>  			return rc;
> @@ -294,11 +295,10 @@ xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
>  		*dma_handle = dev_addr;
>  	else {
>  		if (xen_create_contiguous_region(vstart, order,
> -						 fls64(dma_mask)) != 0) {
> +						 fls64(dma_mask), dma_handle) != 0) {
>  			free_pages(vstart, order);
>  			return NULL;
>  		}
> -		*dma_handle = virt_to_machine(ret).maddr;
>  	}
>  	memset(ret, 0, size);
>  	return ret;
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index d6fe062..9ef704d 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -20,7 +20,8 @@ int xen_setup_shutdown_event(void);
>  
>  extern unsigned long *xen_contiguous_bitmap;
>  int xen_create_contiguous_region(unsigned long vstart, unsigned int order,
> -				unsigned int address_bits);
> +				unsigned int address_bits,
> +				dma_addr_t *dma_handle);
>  
>  void xen_destroy_contiguous_region(unsigned long vstart, unsigned int order);
>  
> -- 
> 1.7.2.5
> 

  reply	other threads:[~2013-08-30 13:45 UTC|newest]

Thread overview: 118+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-29 18:31 [PATCH v5 0/13] enable swiotlb-xen on arm and arm64 Stefano Stabellini
2013-08-29 18:31 ` Stefano Stabellini
2013-08-29 18:31 ` Stefano Stabellini
2013-08-29 18:32 ` [PATCH v5 01/13] arm: make SWIOTLB available Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32 ` [PATCH v5 02/13] arm: introduce a global dma_ops pointer Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-09-02 14:45   ` [Xen-devel] " Julien Grall
2013-09-02 14:45     ` Julien Grall
2013-09-02 14:45     ` Julien Grall
2013-09-05 16:39     ` Stefano Stabellini
2013-09-05 16:39       ` Stefano Stabellini
2013-09-05 16:39       ` Stefano Stabellini
2013-08-29 18:32 ` [PATCH v5 03/13] arm64: define DMA_ERROR_CODE Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-09-05 16:05   ` Catalin Marinas
2013-09-05 16:05     ` Catalin Marinas
2013-09-05 16:05     ` Catalin Marinas
2013-09-05 16:54     ` Stefano Stabellini
2013-09-05 16:54       ` Stefano Stabellini
2013-08-29 18:32 ` [PATCH v5 04/13] arm64: do not initialize arm64_swiotlb if dma_ops is already set Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32 ` [PATCH v5 05/13] xen/arm,arm64: move Xen initialization earlier Stefano Stabellini
2013-08-29 18:32   ` [PATCH v5 05/13] xen/arm, arm64: " Stefano Stabellini
2013-08-29 18:32   ` [PATCH v5 05/13] xen/arm,arm64: " Stefano Stabellini
2013-09-05 16:20   ` Catalin Marinas
2013-09-05 16:20     ` Catalin Marinas
2013-09-05 16:20     ` Catalin Marinas
2013-09-05 16:59     ` Stefano Stabellini
2013-09-05 16:59       ` Stefano Stabellini
2013-09-06  8:58       ` Ian Campbell
2013-09-06  8:58         ` Ian Campbell
2013-09-06 14:09         ` Catalin Marinas
2013-09-06 14:09           ` Catalin Marinas
2013-09-06 14:09           ` Catalin Marinas
2013-09-06 14:23           ` Konrad Rzeszutek Wilk
2013-09-06 14:23             ` Konrad Rzeszutek Wilk
2013-09-06 14:23             ` Konrad Rzeszutek Wilk
2013-09-06 14:53             ` Stefano Stabellini
2013-09-06 14:53               ` Stefano Stabellini
2013-08-29 18:32 ` [PATCH v5 06/13] xen: introduce XENMEM_exchange_and_pin and XENMEM_unpin Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32 ` [PATCH v5 07/13] xen: make xen_create_contiguous_region return the dma address Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-30 13:45   ` Konrad Rzeszutek Wilk [this message]
2013-08-30 13:45     ` Konrad Rzeszutek Wilk
2013-08-29 18:32 ` [PATCH v5 08/13] swiotlb-xen: support autotranslate guests Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-30 13:46   ` Konrad Rzeszutek Wilk
2013-08-30 13:46     ` Konrad Rzeszutek Wilk
2013-08-29 18:32 ` [PATCH v5 09/13] xen/arm,arm64: enable SWIOTLB_XEN Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32 ` [PATCH v5 10/13] swiotlb-xen: introduce xen_swiotlb_set_dma_mask Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32 ` [PATCH v5 11/13] xen: introduce xen_alloc/free_coherent_pages Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-09-05 16:09   ` Catalin Marinas
2013-09-05 16:09     ` Catalin Marinas
2013-09-05 16:09     ` Catalin Marinas
2013-09-05 16:43     ` Stefano Stabellini
2013-09-05 16:43       ` Stefano Stabellini
2013-09-06 14:14       ` Catalin Marinas
2013-09-06 14:14         ` Catalin Marinas
2013-09-06 14:14         ` Catalin Marinas
2013-09-06 14:59         ` Stefano Stabellini
2013-09-06 14:59           ` Stefano Stabellini
2013-09-06 15:59           ` Catalin Marinas
2013-09-06 15:59             ` Catalin Marinas
2013-09-06 15:59             ` Catalin Marinas
2013-09-06 16:09             ` Stefano Stabellini
2013-09-06 16:09               ` Stefano Stabellini
2013-09-06 16:20               ` Catalin Marinas
2013-09-06 16:20                 ` Catalin Marinas
2013-09-06 16:20                 ` Catalin Marinas
2013-09-06 16:52                 ` Stefano Stabellini
2013-09-06 16:52                   ` Stefano Stabellini
2013-09-09 15:51                   ` Catalin Marinas
2013-09-09 15:51                     ` Catalin Marinas
2013-09-09 16:46                     ` Stefano Stabellini
2013-09-09 16:46                       ` Stefano Stabellini
2013-09-11  9:36                       ` Catalin Marinas
2013-09-11  9:36                         ` Catalin Marinas
2013-09-11  9:36                         ` Catalin Marinas
2013-09-11 17:34                         ` Stefano Stabellini
2013-09-11 17:34                           ` Stefano Stabellini
2013-09-12 13:53                           ` Catalin Marinas
2013-09-12 13:53                             ` Catalin Marinas
2013-09-12 13:53                             ` Catalin Marinas
2013-09-12 14:44                             ` Stefano Stabellini
2013-09-12 14:44                               ` Stefano Stabellini
2013-09-12 15:04                               ` Catalin Marinas
2013-09-12 15:04                                 ` Catalin Marinas
2013-08-29 18:32 ` [PATCH v5 12/13] swiotlb-xen: use xen_alloc/free_coherent_pages Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-30 13:53   ` Konrad Rzeszutek Wilk
2013-08-30 13:53     ` Konrad Rzeszutek Wilk
2013-09-05 16:50     ` Stefano Stabellini
2013-09-05 16:50       ` Stefano Stabellini
2013-09-05 16:50       ` Stefano Stabellini
2013-09-06 14:17       ` Konrad Rzeszutek Wilk
2013-09-06 14:17         ` Konrad Rzeszutek Wilk
2013-09-06 15:04         ` Stefano Stabellini
2013-09-06 15:04           ` Stefano Stabellini
2013-09-06 15:04           ` Stefano Stabellini
2013-08-29 18:32 ` [PATCH v5 13/13] swiotlb: don't assume that io_tlb_start-io_tlb_end is coherent Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini
2013-08-29 18:32   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130830134511.GJ21239@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.