From: Simon Ruderich <simon@ruderich.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Jakub Narębski" <jnareb@gmail.com>
Subject: Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names
Date: Fri, 30 Aug 2013 20:31:08 +0200 [thread overview]
Message-ID: <20130830183108.GA4240@ruderich.org> (raw)
In-Reply-To: <xmqqhae7yrls.fsf@gitster.dls.corp.google.com>
On Fri, Aug 30, 2013 at 11:13:19AM -0700, Junio C Hamano wrote:
> I think in this function the filehandle is called $fd, not $fh. Has
> any of you really tested this???
I did, but I applied the change by hand without applying the
patch directly and didn't notice the difference. Sorry for that.
Regards
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
next prev parent reply other threads:[~2013-08-30 18:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 14:26 The gitweb author initials feature from a36817b doesn't work with i18n names Ævar Arnfjörð Bjarmason
2013-08-29 14:44 ` Jakub Narębski
2013-08-29 16:39 ` Simon Ruderich
2013-08-30 8:37 ` [PATCH] gitweb: Fix the author initials in blame for non-ASCII names Ævar Arnfjörð Bjarmason
2013-08-30 18:05 ` Junio C Hamano
2013-08-30 18:08 ` Jakub Narębski
2013-08-30 18:13 ` Junio C Hamano
2013-08-30 18:31 ` Simon Ruderich [this message]
2013-08-30 21:39 ` Kyle J. McKay
2013-08-31 16:42 ` Jakub Narębski
2013-08-31 16:29 ` Ævar Arnfjörð Bjarmason
-- strict thread matches above, loose matches on Subject: below --
2014-03-17 9:21 Kicer Jiao
2014-03-17 9:34 ` Kicer Jiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830183108.GA4240@ruderich.org \
--to=simon@ruderich.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.