From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Jakub Narębski" <jnareb@gmail.com>,
"Simon Ruderich" <simon@ruderich.org>
Subject: Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names
Date: Fri, 30 Aug 2013 11:05:04 -0700 [thread overview]
Message-ID: <xmqqppsvyrzj.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1377851821-5412-1-git-send-email-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 30 Aug 2013 08:37:01 +0000")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Acked-by: Jakub Narębski <jnareb@gmail.com>
> Tested-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> Tested-by: Simon Ruderich <simon@ruderich.org>
> ---
> gitweb/gitweb.perl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index f429f75..ad48a5a 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -6631,6 +6631,7 @@ sub git_blame_common {
> $hash_base, '--', $file_name
> or die_error(500, "Open git-blame --porcelain failed");
> }
> + binmode $fh, ':utf8';
>
> # incremental blame data returns early
> if ($format eq 'data') {
[Fri Aug 30 17:48:17 2013] gitweb.perl: Global symbol "$fh" requires
explicit package name at /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl line 6634.
[Fri Aug 30 17:48:17 2013] gitweb.perl: Execution of /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl aborted due to compilation errors.
next prev parent reply other threads:[~2013-08-30 18:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 14:26 The gitweb author initials feature from a36817b doesn't work with i18n names Ævar Arnfjörð Bjarmason
2013-08-29 14:44 ` Jakub Narębski
2013-08-29 16:39 ` Simon Ruderich
2013-08-30 8:37 ` [PATCH] gitweb: Fix the author initials in blame for non-ASCII names Ævar Arnfjörð Bjarmason
2013-08-30 18:05 ` Junio C Hamano [this message]
2013-08-30 18:08 ` Jakub Narębski
2013-08-30 18:13 ` Junio C Hamano
2013-08-30 18:31 ` Simon Ruderich
2013-08-30 21:39 ` Kyle J. McKay
2013-08-31 16:42 ` Jakub Narębski
2013-08-31 16:29 ` Ævar Arnfjörð Bjarmason
-- strict thread matches above, loose matches on Subject: below --
2014-03-17 9:21 Kicer Jiao
2014-03-17 9:34 ` Kicer Jiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqppsvyrzj.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=simon@ruderich.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.