From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Jiri Olsa <jolsa@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: [RFC][PATCH 17/18 v2] ftrace/cpuidle/x86: Mark functions that are RCU unsafe
Date: Sat, 31 Aug 2013 01:11:34 -0400 [thread overview]
Message-ID: <20130831051703.241036187@goodmis.org> (raw)
In-Reply-To: 20130831051117.884125230@goodmis.org
[-- Attachment #1: 0017-ftrace-cpuidle-x86-Mark-functions-that-are-RCU-unsaf.patch --]
[-- Type: text/plain, Size: 2254 bytes --]
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
Some callbacks of the function tracer use rcu_read_lock(). This means that
there's places that can not be traced because RCU is not tracking the CPU
for various reasons (like NO_HZ_FULL and coming back from userspace).
Thes functions need to be marked so that callbacks that use RCU do not
trace them.
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
arch/x86/kernel/process.c | 2 ++
drivers/cpuidle/cpuidle.c | 2 ++
kernel/cpu/idle.c | 2 ++
3 files changed, 6 insertions(+)
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 83369e5..18739cd 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -17,6 +17,7 @@
#include <linux/stackprotector.h>
#include <linux/tick.h>
#include <linux/cpuidle.h>
+#include <linux/ftrace.h>
#include <trace/events/power.h>
#include <linux/hw_breakpoint.h>
#include <asm/cpu.h>
@@ -316,6 +317,7 @@ void default_idle(void)
#ifdef CONFIG_APM_MODULE
EXPORT_SYMBOL(default_idle);
#endif
+FTRACE_UNSAFE_RCU(default_idle);
#ifdef CONFIG_XEN
bool xen_set_default_idle(void)
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index fdc432f..9515457 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -19,6 +19,7 @@
#include <linux/ktime.h>
#include <linux/hrtimer.h>
#include <linux/module.h>
+#include <linux/ftrace.h>
#include <trace/events/power.h>
#include "cpuidle.h"
@@ -168,6 +169,7 @@ int cpuidle_idle_call(void)
return 0;
}
+FTRACE_UNSAFE_RCU(cpuidle_idle_call);
/**
* cpuidle_install_idle_handler - installs the cpuidle idle loop handler
diff --git a/kernel/cpu/idle.c b/kernel/cpu/idle.c
index e695c0a..d9d290f 100644
--- a/kernel/cpu/idle.c
+++ b/kernel/cpu/idle.c
@@ -5,6 +5,7 @@
#include <linux/cpu.h>
#include <linux/tick.h>
#include <linux/mm.h>
+#include <linux/ftrace.h>
#include <linux/stackprotector.h>
#include <asm/tlb.h>
@@ -61,6 +62,7 @@ void __weak arch_cpu_idle(void)
cpu_idle_force_poll = 1;
local_irq_enable();
}
+FTRACE_UNSAFE_RCU(arch_cpu_idle);
/*
* Generic idle loop implementation
--
1.7.10.4
next prev parent reply other threads:[~2013-08-31 5:18 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 5:11 [RFC][PATCH 00/18 v2] ftrace/rcu: Handle unsafe RCU functions and ftrace callbacks Steven Rostedt
2013-08-31 5:11 ` [RFC][PATCH 01/18 v2] ftrace: Add hash list to save RCU unsafe functions Steven Rostedt
2013-08-31 19:28 ` Paul E. McKenney
2013-09-03 21:15 ` Steven Rostedt
2013-09-03 22:18 ` Paul E. McKenney
2013-09-03 23:57 ` Steven Rostedt
2013-09-04 0:18 ` Steven Rostedt
2013-09-04 1:11 ` [RFC][PATCH 19/18] ftrace: Print a message when the rcu checker is disabled Steven Rostedt
2013-09-04 1:25 ` Paul E. McKenney
2013-09-04 1:24 ` [RFC][PATCH 01/18 v2] ftrace: Add hash list to save RCU unsafe functions Paul E. McKenney
2013-09-04 1:51 ` Steven Rostedt
2013-09-04 1:56 ` Steven Rostedt
2013-09-04 2:01 ` Steven Rostedt
2013-09-04 2:03 ` Steven Rostedt
2013-09-04 4:18 ` Paul E. McKenney
2013-09-04 11:50 ` Steven Rostedt
2013-09-04 4:12 ` Paul E. McKenney
2013-08-31 5:11 ` [RFC][PATCH 02/18 v2] ftrace: Do not set ftrace records for unsafe RCU when not allowed Steven Rostedt
2013-08-31 19:29 ` Paul E. McKenney
2013-08-31 5:11 ` [RFC][PATCH 03/18 v2] ftrace: Set ftrace internal function tracing RCU safe Steven Rostedt
2013-08-31 19:30 ` Paul E. McKenney
2013-08-31 19:44 ` Paul E. McKenney
2013-09-03 13:22 ` Steven Rostedt
2013-09-03 13:54 ` Paul E. McKenney
2013-08-31 5:11 ` [RFC][PATCH 04/18 v2] ftrace: Add test for ops against unsafe RCU functions in callback Steven Rostedt
2013-08-31 19:45 ` Paul E. McKenney
2013-08-31 5:11 ` [RFC][PATCH 05/18 v2] ftrace: Do not display non safe RCU functions in available_filter_functions Steven Rostedt
2013-08-31 19:46 ` Paul E. McKenney
2013-08-31 20:35 ` Steven Rostedt
2013-08-31 20:54 ` Paul E. McKenney
2013-09-03 13:26 ` Steven Rostedt
2013-09-03 13:54 ` Paul E. McKenney
2013-08-31 5:11 ` [RFC][PATCH 06/18 v2] ftrace: Add rcu_unsafe_filter_functions file Steven Rostedt
2013-08-31 19:46 ` Paul E. McKenney
2013-08-31 5:11 ` [RFC][PATCH 07/18 v2] ftrace: Add selftest to check if RCU unsafe functions are filtered properly Steven Rostedt
2013-08-31 19:47 ` Paul E. McKenney
2013-08-31 5:11 ` [RFC][PATCH 08/18 v2] ftrace/rcu: Do not trace debug_lockdep_rcu_enabled() Steven Rostedt
2013-08-31 19:21 ` Paul E. McKenney
2013-08-31 20:31 ` Steven Rostedt
2013-08-31 5:11 ` [RFC][PATCH 09/18 v2] ftrace: Fix a slight race in modifying what function callback gets traced Steven Rostedt
2013-08-31 5:11 ` [RFC][PATCH 10/18 v2] ftrace: Create a RCU unsafe checker Steven Rostedt
2013-08-31 19:49 ` Paul E. McKenney
2013-08-31 5:11 ` [RFC][PATCH 11/18 v2] ftrace: Adde infrastructure to stop RCU unsafe checker from checking Steven Rostedt
2013-08-31 19:52 ` Paul E. McKenney
2013-08-31 20:40 ` Steven Rostedt
2013-09-03 13:43 ` Steven Rostedt
2013-09-03 15:22 ` Paul E. McKenney
2013-08-31 5:11 ` [RFC][PATCH 12/18 v2] ftrace: Disable RCU unsafe checker when function graph is enabled Steven Rostedt
2013-08-31 19:55 ` Paul E. McKenney
2013-08-31 20:42 ` Steven Rostedt
2013-08-31 20:58 ` Paul E. McKenney
2013-08-31 5:11 ` [RFC][PATCH 13/18 v2] ftrace: Disable the RCU unsafe checker when irqsoff " Steven Rostedt
2013-08-31 19:58 ` Paul E. McKenney
2013-08-31 5:11 ` [RFC][PATCH 14/18 v2] ftrace/lockdep: Have the RCU lockdep splat show what function triggered Steven Rostedt
2013-08-31 19:59 ` Paul E. McKenney
2013-09-05 19:18 ` Peter Zijlstra
2013-09-05 19:52 ` Steven Rostedt
2013-09-06 12:57 ` Ingo Molnar
2013-09-06 13:16 ` Steven Rostedt
2013-09-05 19:35 ` Peter Zijlstra
2013-09-05 20:27 ` Steven Rostedt
2013-08-31 5:11 ` [RFC][PATCH 15/18 v2] ftrace/rcu: Mark functions that are RCU unsafe Steven Rostedt
2013-08-31 20:00 ` Paul E. McKenney
2013-08-31 20:43 ` Steven Rostedt
2013-08-31 20:54 ` Paul E. McKenney
2013-08-31 5:11 ` [RFC][PATCH 16/18 v2] rcu/irq/x86: " Steven Rostedt
2013-08-31 20:01 ` Paul E. McKenney
2013-08-31 5:11 ` Steven Rostedt [this message]
2013-08-31 11:07 ` [RFC][PATCH 17/18 v2] ftrace/cpuidle/x86: " Wysocki, Rafael J
2013-08-31 20:02 ` Paul E. McKenney
2013-09-04 0:16 ` H. Peter Anvin
2013-08-31 5:11 ` [RFC][PATCH 18/18 v2] ftrace/sched: " Steven Rostedt
2013-08-31 20:01 ` Paul E. McKenney
2013-08-31 15:50 ` [RFC][PATCH 00/18 v2] ftrace/rcu: Handle unsafe RCU functions and ftrace callbacks Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130831051703.241036187@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.