All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Pargmann <mpa@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	Liam Girdwood <lgirdwood@gmail.com>, Timur Tabi <timur@tabi.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Sascha Hauer <kernel@pengutronix.de>,
	Shawn Guo <shawn.guo@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v11 3/8] ASoC: generic: simple DT sound card
Date: Sat, 31 Aug 2013 09:17:52 +0200	[thread overview]
Message-ID: <20130831071752.GX20071@s25.your-server.de> (raw)
In-Reply-To: <20130823095816.GF25263@sirena.org.uk>

Hi,

On Fri, Aug 23, 2013 at 10:58:16AM +0100, Mark Brown wrote:
> On Mon, Aug 19, 2013 at 05:05:56PM +0200, Markus Pargmann wrote:
> > Simple sound card initialized using DT. When used with AC97, ac97-codec
> > is used to automatically discover the used codec.
> 
> I've held back a bit on this one.  The reason is that it's adding a
> separate card to the generic card which doesn't seem like the obvious
> thing to do - obviously they have very similar goals, it's just that one
> is for DT usage and the other isn't.  What's the reason for not adding
> DT support to the generic card?

There was no code I could reuse from the existing simple card driver, so
I decided to seperate the DT part.

I will move the DT driver code into simple card and resend the patch.

Thanks,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 3/8] ASoC: generic: simple DT sound card
Date: Sat, 31 Aug 2013 09:17:52 +0200	[thread overview]
Message-ID: <20130831071752.GX20071@s25.your-server.de> (raw)
In-Reply-To: <20130823095816.GF25263@sirena.org.uk>

Hi,

On Fri, Aug 23, 2013 at 10:58:16AM +0100, Mark Brown wrote:
> On Mon, Aug 19, 2013 at 05:05:56PM +0200, Markus Pargmann wrote:
> > Simple sound card initialized using DT. When used with AC97, ac97-codec
> > is used to automatically discover the used codec.
> 
> I've held back a bit on this one.  The reason is that it's adding a
> separate card to the generic card which doesn't seem like the obvious
> thing to do - obviously they have very similar goals, it's just that one
> is for DT usage and the other isn't.  What's the reason for not adding
> DT support to the generic card?

There was no code I could reuse from the existing simple card driver, so
I decided to seperate the DT part.

I will move the DT driver code into simple card and resend the patch.

Thanks,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2013-08-31  7:18 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 15:05 [PATCH v11 0/7] ASoC: fsl-ssi: ac97-slave support Markus Pargmann
2013-08-19 15:05 ` Markus Pargmann
2013-08-19 15:05 ` [PATCH v11 1/8] ASoC: imx-pcm-dma: Add missing include Markus Pargmann
2013-08-19 15:05   ` Markus Pargmann
2013-08-19 16:42   ` Mark Brown
2013-08-19 16:42     ` Mark Brown
2013-08-19 15:05 ` [PATCH v11 2/8] ASoC: core: Generic ac97 link reset functions Markus Pargmann
2013-08-19 15:05   ` Markus Pargmann
2013-08-20 10:22   ` Mark Brown
2013-08-20 10:22     ` Mark Brown
     [not found]   ` <1376924761-4054-3-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-06-18 18:42     ` S. Fricke
2014-06-18 18:42       ` S. Fricke
2014-06-18 21:19       ` Markus Pargmann
2014-06-18 21:19         ` Markus Pargmann
2013-08-19 15:05 ` [PATCH v11 3/8] ASoC: generic: simple DT sound card Markus Pargmann
2013-08-19 15:05   ` Markus Pargmann
2013-08-23  9:58   ` Mark Brown
2013-08-23  9:58     ` Mark Brown
2013-08-31  7:17     ` Markus Pargmann [this message]
2013-08-31  7:17       ` Markus Pargmann
2013-08-19 15:05 ` [PATCH v11 4/8] ASoC: fsl: Kconfig, visible config items for simple card Markus Pargmann
2013-08-19 15:05   ` Markus Pargmann
2013-08-19 15:05 ` [PATCH v11 5/8] ASoC: fsl-ssi: ac97-slave support Markus Pargmann
2013-08-19 15:05   ` Markus Pargmann
2013-08-22 10:09   ` Mark Brown
2013-08-22 10:09     ` Mark Brown
2013-08-19 15:05 ` [PATCH v11 6/8] ASoC: fsl-ssi: add SSIEN errata work around Markus Pargmann
2013-08-19 15:05   ` Markus Pargmann
2013-08-22 10:10   ` Mark Brown
2013-08-22 10:10     ` Mark Brown
2013-08-19 15:06 ` [PATCH v11 7/8] ASoC: fsl-ssi: imx-pcm-fiq bugfix Markus Pargmann
2013-08-19 15:06   ` Markus Pargmann
2013-08-22 10:10   ` Mark Brown
2013-08-22 10:10     ` Mark Brown
2013-08-19 15:06 ` [PATCH v11 8/8] ASoC: fsl: disable ssi irq for imx Markus Pargmann
2013-08-19 15:06   ` Markus Pargmann
2013-08-22 10:11   ` Mark Brown
2013-08-22 10:11     ` Mark Brown
2013-08-19 15:13 ` [PATCH v11 0/7] ASoC: fsl-ssi: ac97-slave support Marc Kleine-Budde
2013-08-19 15:13   ` Marc Kleine-Budde
2013-08-19 15:13   ` Marc Kleine-Budde
2013-08-19 15:13     ` Marc Kleine-Budde
2013-08-19 15:29     ` Markus Pargmann
2013-08-19 15:29       ` Markus Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130831071752.GX20071@s25.your-server.de \
    --to=mpa@pengutronix.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@freescale.com \
    --cc=grant.likely@secretlab.ca \
    --cc=kernel@pengutronix.de \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=shawn.guo@linaro.org \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.