From: Christian Lamparter <chunkeey@googlemail.com>
To: ath10k@lists.infradead.org
Cc: Kalle Valo <kvalo@qca.qualcomm.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ath10k: check chip id from the soc register during probe
Date: Sun, 1 Sep 2013 17:48:59 +0200 [thread overview]
Message-ID: <201309011749.00846.chunkeey@googlemail.com> (raw)
In-Reply-To: <20130901082214.1930.61079.stgit@localhost6.localdomain6>
On Sunday 01 September 2013 10:22:14 Kalle Valo wrote:
> ath10k doesn't support qca988x hw1.0 boards anymore. Unfortunately
> the PCI id is the same in hw1.0 and hw2.0 so ath10k tries to use
> hw1.0 boards anyway. But without hw1.0 workarounds in place
> ath10k just crashes horribly.
>
> To avoid using hw1.0 boards at all add a chip id detection
> and fail the probe if hw1.0 is detected:
>
> [ 5265.786408] ath10k: ERROR: qca988x hw1.0 is not supported
> [ 5265.786497] ath10k: Unsupported chip id 0x043202ff
Wait a second... Isn't "0x043202ff" the id for v2.0?
Shouldn't this have worked?
> [ 5265.786574] ath10k: could not register driver core (-95)
> [ 5265.793191] ath10k_pci: probe of 0000:02:00.0 failed with error -95
>
> Also add a warning if there's an unknown chip id but continue
> the boot process normally anyway.
>
[22217.940000] ath10k_pci 0000:01:00.0: BAR 0: assigned [mem 0x12000000-0x121fffff 64bit]
[22217.950000] PCI: Enabling device 0000:01:00.0 (0000 -> 0002)
[22217.960000] ath10k: ERROR: qca988x hw1.0 is not supported
[22217.960000] ath10k: Unsupported chip id 0x043200ff
[22217.970000] ath10k: could not register driver core (-122)
[22217.970000] ath10k_pci: probe of 0000:01:00.0 failed with error -122
[ Ok. Although I wonder why the error code is -122 (-EDQUOT) and
not -95 (-EOPNOTSUPP)?! Anyway, it still works. However I'm
looking forward to run some more tests, but first I'll need
to get that 2.0 hw ;-) ].
Tested-by: Christian Lamparter <chunkeey@googlemail.com>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Regards,
Chr
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Christian Lamparter <chunkeey@googlemail.com>
To: ath10k@lists.infradead.org
Cc: Kalle Valo <kvalo@qca.qualcomm.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ath10k: check chip id from the soc register during probe
Date: Sun, 1 Sep 2013 17:48:59 +0200 [thread overview]
Message-ID: <201309011749.00846.chunkeey@googlemail.com> (raw)
In-Reply-To: <20130901082214.1930.61079.stgit@localhost6.localdomain6>
On Sunday 01 September 2013 10:22:14 Kalle Valo wrote:
> ath10k doesn't support qca988x hw1.0 boards anymore. Unfortunately
> the PCI id is the same in hw1.0 and hw2.0 so ath10k tries to use
> hw1.0 boards anyway. But without hw1.0 workarounds in place
> ath10k just crashes horribly.
>
> To avoid using hw1.0 boards at all add a chip id detection
> and fail the probe if hw1.0 is detected:
>
> [ 5265.786408] ath10k: ERROR: qca988x hw1.0 is not supported
> [ 5265.786497] ath10k: Unsupported chip id 0x043202ff
Wait a second... Isn't "0x043202ff" the id for v2.0?
Shouldn't this have worked?
> [ 5265.786574] ath10k: could not register driver core (-95)
> [ 5265.793191] ath10k_pci: probe of 0000:02:00.0 failed with error -95
>
> Also add a warning if there's an unknown chip id but continue
> the boot process normally anyway.
>
[22217.940000] ath10k_pci 0000:01:00.0: BAR 0: assigned [mem 0x12000000-0x121fffff 64bit]
[22217.950000] PCI: Enabling device 0000:01:00.0 (0000 -> 0002)
[22217.960000] ath10k: ERROR: qca988x hw1.0 is not supported
[22217.960000] ath10k: Unsupported chip id 0x043200ff
[22217.970000] ath10k: could not register driver core (-122)
[22217.970000] ath10k_pci: probe of 0000:01:00.0 failed with error -122
[ Ok. Although I wonder why the error code is -122 (-EDQUOT) and
not -95 (-EOPNOTSUPP)?! Anyway, it still works. However I'm
looking forward to run some more tests, but first I'll need
to get that 2.0 hw ;-) ].
Tested-by: Christian Lamparter <chunkeey@googlemail.com>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Regards,
Chr
next prev parent reply other threads:[~2013-09-01 15:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 8:22 [PATCH v2 0/2] ath10k: detect hw1.0 boards Kalle Valo
2013-09-01 8:22 ` Kalle Valo
2013-09-01 8:22 ` [PATCH v2 1/2] ath10k: check chip id from the soc register during probe Kalle Valo
2013-09-01 8:22 ` Kalle Valo
2013-09-01 15:48 ` Christian Lamparter [this message]
2013-09-01 15:48 ` Christian Lamparter
2013-09-02 4:38 ` Kalle Valo
2013-09-02 4:38 ` Kalle Valo
2013-09-03 3:55 ` Zaki
2013-09-03 4:35 ` Kalle Valo
2013-09-01 8:22 ` [PATCH v2 2/2] ath10k: add chip_id file to debugfs Kalle Valo
2013-09-01 8:22 ` Kalle Valo
2013-09-03 7:00 ` [PATCH v2 0/2] ath10k: detect hw1.0 boards Kalle Valo
2013-09-03 7:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309011749.00846.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.