All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: Add support for BCM20702A0 [0b05, 17cb]
@ 2013-09-02 11:57 Raphael Kubo da Costa
  2013-09-02 12:41 ` Gustavo Padovan
  2013-09-02 15:53 ` Marcel Holtmann
  0 siblings, 2 replies; 6+ messages in thread
From: Raphael Kubo da Costa @ 2013-09-02 11:57 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: stable

Yet another vendor specific ID for this chipset; this one for the ASUS
USB-BT400 Bluetooth 4.0 adapter.

T:  Bus=03 Lev=02 Prnt=02 Port=01 Cnt=01 Dev#=  6 Spd=12  MxCh= 0
D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=0b05 ProdID=17cb Rev=01.12
S:  Manufacturer=Broadcom Corp
S:  Product=BCM20702A0
S:  SerialNumber=000272C64400
C:  #Ifs= 4 Cfg#= 1 Atr=a0 MxPwr=100mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)

Cc: stable@vger.kernel.org
Signed-off-by: Raphael Kubo da Costa <rakuco@FreeBSD.org>
---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index d3313e6..c0a9df4 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -99,6 +99,7 @@ static struct usb_device_id btusb_table[] = {
 
 	/* Broadcom BCM20702A0 */
 	{ USB_DEVICE(0x0b05, 0x17b5) },
+	{ USB_DEVICE(0x0b05, 0x17cb) },
 	{ USB_DEVICE(0x04ca, 0x2003) },
 	{ USB_DEVICE(0x0489, 0xe042) },
 	{ USB_DEVICE(0x413c, 0x8197) },
-- 
1.8.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] Bluetooth: Add support for BCM20702A0 [0b05, 17cb]
  2013-09-02 11:57 [PATCH] Bluetooth: Add support for BCM20702A0 [0b05, 17cb] Raphael Kubo da Costa
@ 2013-09-02 12:41 ` Gustavo Padovan
  2013-09-02 13:26   ` Tim Aerts
  2013-09-02 15:53 ` Marcel Holtmann
  1 sibling, 1 reply; 6+ messages in thread
From: Gustavo Padovan @ 2013-09-02 12:41 UTC (permalink / raw)
  To: Raphael Kubo da Costa; +Cc: linux-bluetooth, stable

Hi Raphael,

2013-09-02 Raphael Kubo da Costa <rakuco@FreeBSD.org>:

> Yet another vendor specific ID for this chipset; this one for the ASUS
> USB-BT400 Bluetooth 4.0 adapter.
> 
> T:  Bus=03 Lev=02 Prnt=02 Port=01 Cnt=01 Dev#=  6 Spd=12  MxCh= 0
> D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=0b05 ProdID=17cb Rev=01.12
> S:  Manufacturer=Broadcom Corp
> S:  Product=BCM20702A0
> S:  SerialNumber=000272C64400
> C:  #Ifs= 4 Cfg#= 1 Atr=a0 MxPwr=100mA
> I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Raphael Kubo da Costa <rakuco@FreeBSD.org>
> ---
>  drivers/bluetooth/btusb.c | 1 +
>  1 file changed, 1 insertion(+)

Patch has been applied to bluetooth.git. Thanks.

	Gustavo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Bluetooth: Add support for BCM20702A0 [0b05, 17cb]
  2013-09-02 12:41 ` Gustavo Padovan
@ 2013-09-02 13:26   ` Tim Aerts
  2013-09-02 13:52     ` Raphael Kubo da Costa
  0 siblings, 1 reply; 6+ messages in thread
From: Tim Aerts @ 2013-09-02 13:26 UTC (permalink / raw)
  To: Gustavo Padovan, Raphael Kubo da Costa, linux-bluetooth, stable

The Trust Bluetooth 4.0 USB module is also BCM20702A0. The id's are
0x21e8 and 0x0a5c.

Would you please add this one as well?

On Mon, Sep 2, 2013 at 2:41 PM, Gustavo Padovan <gustavo@padovan.org> wrote:
> Hi Raphael,
>
> 2013-09-02 Raphael Kubo da Costa <rakuco@FreeBSD.org>:
>
>> Yet another vendor specific ID for this chipset; this one for the ASUS
>> USB-BT400 Bluetooth 4.0 adapter.
>>
>> T:  Bus=03 Lev=02 Prnt=02 Port=01 Cnt=01 Dev#=  6 Spd=12  MxCh= 0
>> D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
>> P:  Vendor=0b05 ProdID=17cb Rev=01.12
>> S:  Manufacturer=Broadcom Corp
>> S:  Product=BCM20702A0
>> S:  SerialNumber=000272C64400
>> C:  #Ifs= 4 Cfg#= 1 Atr=a0 MxPwr=100mA
>> I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
>> I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
>> I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
>> I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Raphael Kubo da Costa <rakuco@FreeBSD.org>
>> ---
>>  drivers/bluetooth/btusb.c | 1 +
>>  1 file changed, 1 insertion(+)
>
> Patch has been applied to bluetooth.git. Thanks.
>
>         Gustavo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Bluetooth: Add support for BCM20702A0 [0b05, 17cb]
  2013-09-02 13:26   ` Tim Aerts
@ 2013-09-02 13:52     ` Raphael Kubo da Costa
  2013-09-02 15:02       ` Tim Aerts
  0 siblings, 1 reply; 6+ messages in thread
From: Raphael Kubo da Costa @ 2013-09-02 13:52 UTC (permalink / raw)
  To: Tim Aerts; +Cc: Gustavo Padovan, linux-bluetooth, stable

Tim Aerts <tim.koder@gmail.com> writes:

> The Trust Bluetooth 4.0 USB module is also BCM20702A0. The id's are
> 0x21e8 and 0x0a5c.
>
> Would you please add this one as well?

Hi,

I don't have access to this device, so I can't test the patch or provide
the usb-devices output that's generally needed for this kind of commit.

If you do, it would probably be easier for you to send the patch
yourself.

Cheers.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Bluetooth: Add support for BCM20702A0 [0b05, 17cb]
  2013-09-02 13:52     ` Raphael Kubo da Costa
@ 2013-09-02 15:02       ` Tim Aerts
  0 siblings, 0 replies; 6+ messages in thread
From: Tim Aerts @ 2013-09-02 15:02 UTC (permalink / raw)
  To: Raphael Kubo da Costa; +Cc: Gustavo Padovan, linux-bluetooth, stable

Raphael,

I wish I had time to do so. But since we couldn't get bluez to work
and my e-mail to this list remained unanswered (probably even unread),
my employer has already moved on.

I provide these id's in hope to avoid other victims. I may get some
time to come back to this in a some weeks/months from now. But I
didn't want to withhold this information from you guys.

Cheers,
Tim


On Mon, Sep 2, 2013 at 3:52 PM, Raphael Kubo da Costa
<rakuco@freebsd.org> wrote:
> Tim Aerts <tim.koder@gmail.com> writes:
>
>> The Trust Bluetooth 4.0 USB module is also BCM20702A0. The id's are
>> 0x21e8 and 0x0a5c.
>>
>> Would you please add this one as well?
>
> Hi,
>
> I don't have access to this device, so I can't test the patch or provide
> the usb-devices output that's generally needed for this kind of commit.
>
> If you do, it would probably be easier for you to send the patch
> yourself.
>
> Cheers.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Bluetooth: Add support for BCM20702A0 [0b05, 17cb]
  2013-09-02 11:57 [PATCH] Bluetooth: Add support for BCM20702A0 [0b05, 17cb] Raphael Kubo da Costa
  2013-09-02 12:41 ` Gustavo Padovan
@ 2013-09-02 15:53 ` Marcel Holtmann
  1 sibling, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2013-09-02 15:53 UTC (permalink / raw)
  To: Raphael Kubo da Costa; +Cc: linux-bluetooth, stable

Hi Raphael,

> Yet another vendor specific ID for this chipset; this one for the ASUS
> USB-BT400 Bluetooth 4.0 adapter.
> 
> T:  Bus=03 Lev=02 Prnt=02 Port=01 Cnt=01 Dev#=  6 Spd=12  MxCh= 0
> D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=0b05 ProdID=17cb Rev=01.12
> S:  Manufacturer=Broadcom Corp
> S:  Product=BCM20702A0
> S:  SerialNumber=000272C64400
> C:  #Ifs= 4 Cfg#= 1 Atr=a0 MxPwr=100mA
> I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Raphael Kubo da Costa <rakuco@FreeBSD.org>
> ---
> drivers/bluetooth/btusb.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index d3313e6..c0a9df4 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -99,6 +99,7 @@ static struct usb_device_id btusb_table[] = {
> 
> 	/* Broadcom BCM20702A0 */
> 	{ USB_DEVICE(0x0b05, 0x17b5) },
> +	{ USB_DEVICE(0x0b05, 0x17cb) },
> 	{ USB_DEVICE(0x04ca, 0x2003) },
> 	{ USB_DEVICE(0x0489, 0xe042) },
> 	{ USB_DEVICE(0x413c, 0x8197) },

I wonder if we should stop this crazy and just this one line

USB_VENDOR_AND_INTERFACE_INFO(0x0b05, 0xff, 0x01, 0x01)

for all Broadcom originated devices.

Same as we do for all Apple Bluetooth devices that are based on Broadcom chips. It seems that Broadcom decided to use ff:01:01 for their chips instead of the official e0:01:01.

Regards

Marcel


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-09-02 15:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-02 11:57 [PATCH] Bluetooth: Add support for BCM20702A0 [0b05, 17cb] Raphael Kubo da Costa
2013-09-02 12:41 ` Gustavo Padovan
2013-09-02 13:26   ` Tim Aerts
2013-09-02 13:52     ` Raphael Kubo da Costa
2013-09-02 15:02       ` Tim Aerts
2013-09-02 15:53 ` Marcel Holtmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.