From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kumar Gaurav <kumargauravgupta3@gmail.com>
Cc: sarah.a.sharp@linux.intel.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v4:No Change] xHCI:Fixing xhci_readl definition and function call
Date: Tue, 03 Sep 2013 08:17:10 +0000 [thread overview]
Message-ID: <20130903081710.GE6329@mwanda> (raw)
In-Reply-To: <522557B7.8080909@gmail.com>
On Tue, Sep 03, 2013 at 08:59:59AM +0530, Kumar Gaurav wrote:
> I tried applying this patch on linux-next and it applies well.
> i used
> git apply --apply
>
The merge window is open. No one is applying patches until -rc1 comes
out.
This one is not redone in the right way. The subject is wrong:
Bad: [PATCH v4:No Change] xHCI:Fixing xhci_readl definition and function call
Good: [PATCH v4] xHCI: Fixing xhci_readl definition and function call
There should be a note under the --- line to say what changed and why
you are resending. It's not helpful to say "No Change" because actually
there were many changes.
---
v4: Update to apply on linux-next.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kumar Gaurav <kumargauravgupta3@gmail.com>
Cc: sarah.a.sharp@linux.intel.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v4:No Change] xHCI:Fixing xhci_readl definition and function call
Date: Tue, 3 Sep 2013 11:17:10 +0300 [thread overview]
Message-ID: <20130903081710.GE6329@mwanda> (raw)
In-Reply-To: <522557B7.8080909@gmail.com>
On Tue, Sep 03, 2013 at 08:59:59AM +0530, Kumar Gaurav wrote:
> I tried applying this patch on linux-next and it applies well.
> i used
> git apply --apply
>
The merge window is open. No one is applying patches until -rc1 comes
out.
This one is not redone in the right way. The subject is wrong:
Bad: [PATCH v4:No Change] xHCI:Fixing xhci_readl definition and function call
Good: [PATCH v4] xHCI: Fixing xhci_readl definition and function call
There should be a note under the --- line to say what changed and why
you are resending. It's not helpful to say "No Change" because actually
there were many changes.
---
v4: Update to apply on linux-next.
regards,
dan carpenter
next prev parent reply other threads:[~2013-09-03 8:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 17:32 [PATCH v4:No Change] xHCI:Fixing xhci_readl definition and function call Kumar Gaurav
2013-08-31 17:44 ` =?UTF-8?q?=5BPATCH=20v4=3ANo=20Change=5D=20xHCI=3AFixing=20xhci=5Freadl=20definition=20and=20functio Kumar Gaurav
2013-09-03 3:29 ` [PATCH v4:No Change] xHCI:Fixing xhci_readl definition and function call Kumar Gaurav
2013-09-03 3:41 ` Kumar Gaurav
2013-09-03 8:17 ` Dan Carpenter [this message]
2013-09-03 8:17 ` Dan Carpenter
2013-09-03 16:04 ` Sarah Sharp
2013-09-03 16:04 ` Sarah Sharp
2013-09-04 6:12 ` Kumar Gaurav
2013-09-04 6:24 ` Kumar Gaurav
2013-09-11 23:14 ` Sarah Sharp
2013-09-11 23:14 ` Sarah Sharp
2013-09-12 2:45 ` Kumar Gaurav
2013-09-12 2:57 ` Kumar Gaurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903081710.GE6329@mwanda \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kumargauravgupta3@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.