[PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols

[PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols

[Markos Chandras]

Select NEW_LEDS and LEDS_CLASS since they export symbols
needed by leds-sead3.c. Fixes the following build problem:

leds-sead3.c:(.text+0xf0c): undefined
reference to `led_classdev_unregister'
leds-sead3.c:(.text+0xf18): undefined
reference to `led_classdev_unregister'

Also select I2C since it's needed by sead3-pic32-i2c-drv.c
Fixes the following build problem:
arch/mips/mti-sead3/sead3-pic32-i2c-drv.c:350:2: error:
implicit declaration of
function 'i2c_add_numbered_adapter'
[-Werror=implicit-function-declaration]

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
This patch is for the upstream-sfr/mips-for-linux-next tree
---
 arch/mips/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index fdaf628..04bdd82 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -342,9 +342,12 @@ config MIPS_SEAD3
 	select CPU_MIPSR2_IRQ_VI
 	select CPU_MIPSR2_IRQ_EI
 	select DMA_NONCOHERENT
+	select I2C
 	select IRQ_CPU
 	select IRQ_GIC
+	select LEDS_CLASS
 	select MIPS_MSC
+	select NEW_LEDS
 	select SYS_HAS_CPU_MIPS32_R1
 	select SYS_HAS_CPU_MIPS32_R2
 	select SYS_HAS_CPU_MIPS64_R1
-- 
1.8.3.2

[PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols

[Markos Chandras]

Select NEW_LEDS and LEDS_CLASS since they export symbols
needed by leds-sead3.c. Fixes the following build problem:

leds-sead3.c:(.text+0xf0c): undefined
reference to `led_classdev_unregister'
leds-sead3.c:(.text+0xf18): undefined
reference to `led_classdev_unregister'

Also select I2C since it's needed by sead3-pic32-i2c-drv.c
Fixes the following build problem:
arch/mips/mti-sead3/sead3-pic32-i2c-drv.c:350:2: error:
implicit declaration of
function 'i2c_add_numbered_adapter'
[-Werror=implicit-function-declaration]

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
This patch is for the upstream-sfr/mips-for-linux-next tree
---
 arch/mips/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index fdaf628..04bdd82 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -342,9 +342,12 @@ config MIPS_SEAD3
 	select CPU_MIPSR2_IRQ_VI
 	select CPU_MIPSR2_IRQ_EI
 	select DMA_NONCOHERENT
+	select I2C
 	select IRQ_CPU
 	select IRQ_GIC
+	select LEDS_CLASS
 	select MIPS_MSC
+	select NEW_LEDS
 	select SYS_HAS_CPU_MIPS32_R1
 	select SYS_HAS_CPU_MIPS32_R2
 	select SYS_HAS_CPU_MIPS64_R1
-- 
1.8.3.2

Re: [PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols

[Ralf Baechle]

On Tue, Sep 03, 2013 at 03:27:00PM +0100, Markos Chandras wrote:

> Select NEW_LEDS and LEDS_CLASS since they export symbols
> needed by leds-sead3.c. Fixes the following build problem:
> 
> leds-sead3.c:(.text+0xf0c): undefined
> reference to `led_classdev_unregister'
> leds-sead3.c:(.text+0xf18): undefined
> reference to `led_classdev_unregister'
> 
> Also select I2C since it's needed by sead3-pic32-i2c-drv.c
> Fixes the following build problem:
> arch/mips/mti-sead3/sead3-pic32-i2c-drv.c:350:2: error:
> implicit declaration of
> function 'i2c_add_numbered_adapter'

You probably should setup a bus like all the other callers of
i2c_add_numbered_adapter() in drivers/i2c/busses/; similar for the LED
issue.

  Ralf

Re: [PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

On Tue, Sep 03, 2013 at 04:58:39PM +0200, Ralf Baechle wrote:
> On Tue, Sep 03, 2013 at 03:27:00PM +0100, Markos Chandras wrote:
> 
> > Select NEW_LEDS and LEDS_CLASS since they export symbols
> > needed by leds-sead3.c. Fixes the following build problem:
> > 
> > leds-sead3.c:(.text+0xf0c): undefined
> > reference to `led_classdev_unregister'
> > leds-sead3.c:(.text+0xf18): undefined
> > reference to `led_classdev_unregister'
> > 
> > Also select I2C since it's needed by sead3-pic32-i2c-drv.c
> > Fixes the following build problem:
> > arch/mips/mti-sead3/sead3-pic32-i2c-drv.c:350:2: error:
> > implicit declaration of
> > function 'i2c_add_numbered_adapter'
> 
> You probably should setup a bus like all the other callers of
> i2c_add_numbered_adapter() in drivers/i2c/busses/; similar for the LED
> issue.

The I2C driver should really be in the i2c realm AFAICS. Also, it needs
a few cleanups.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]