All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MIPS: Octeon: Move declaration of 'fixup_irqs' to common header.
@ 2013-07-25  5:40 Steven J. Hill
  2013-07-25 17:05 ` David Daney
  2013-09-03 16:24 ` Ralf Baechle
  0 siblings, 2 replies; 3+ messages in thread
From: Steven J. Hill @ 2013-07-25  5:40 UTC (permalink / raw)
  To: linux-mips; +Cc: Steven J. Hill, Ralf Baechle, David Daney

To prepare for CPU hotplug of CM-based platforms.

Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
---
 arch/mips/cavium-octeon/smp.c |    2 --
 arch/mips/include/asm/irq.h   |    1 +
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
index 138cc80..a63dbc0 100644
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -255,8 +255,6 @@ static void octeon_cpus_done(void)
 /* State of each CPU. */
 DEFINE_PER_CPU(int, cpu_state);
 
-extern void fixup_irqs(void);
-
 static int octeon_cpu_disable(void)
 {
 	unsigned int cpu = smp_processor_id();
diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h
index 7bc2cdb..8994ca8 100644
--- a/arch/mips/include/asm/irq.h
+++ b/arch/mips/include/asm/irq.h
@@ -126,6 +126,7 @@ extern void do_IRQ_no_affinity(unsigned int irq);
 
 extern void arch_init_irq(void);
 extern void spurious_interrupt(void);
+extern void fixup_irqs(void);
 
 extern int allocate_irqno(void);
 extern void alloc_legacy_irqno(void);
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: Octeon: Move declaration of 'fixup_irqs' to common header.
  2013-07-25  5:40 [PATCH] MIPS: Octeon: Move declaration of 'fixup_irqs' to common header Steven J. Hill
@ 2013-07-25 17:05 ` David Daney
  2013-09-03 16:24 ` Ralf Baechle
  1 sibling, 0 replies; 3+ messages in thread
From: David Daney @ 2013-07-25 17:05 UTC (permalink / raw)
  To: Steven J. Hill, Ralf Baechle; +Cc: linux-mips, David Daney

On 07/24/2013 10:40 PM, Steven J. Hill wrote:
> To prepare for CPU hotplug of CM-based platforms.
>
> Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>

It still builds after this, so...

Acked-by: David Daney <david.daney@cavium.com>

> ---
>   arch/mips/cavium-octeon/smp.c |    2 --
>   arch/mips/include/asm/irq.h   |    1 +
>   2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
> index 138cc80..a63dbc0 100644
> --- a/arch/mips/cavium-octeon/smp.c
> +++ b/arch/mips/cavium-octeon/smp.c
> @@ -255,8 +255,6 @@ static void octeon_cpus_done(void)
>   /* State of each CPU. */
>   DEFINE_PER_CPU(int, cpu_state);
>
> -extern void fixup_irqs(void);
> -
>   static int octeon_cpu_disable(void)
>   {
>   	unsigned int cpu = smp_processor_id();
> diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h
> index 7bc2cdb..8994ca8 100644
> --- a/arch/mips/include/asm/irq.h
> +++ b/arch/mips/include/asm/irq.h
> @@ -126,6 +126,7 @@ extern void do_IRQ_no_affinity(unsigned int irq);
>
>   extern void arch_init_irq(void);
>   extern void spurious_interrupt(void);
> +extern void fixup_irqs(void);
>
>   extern int allocate_irqno(void);
>   extern void alloc_legacy_irqno(void);
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: Octeon: Move declaration of 'fixup_irqs' to common header.
  2013-07-25  5:40 [PATCH] MIPS: Octeon: Move declaration of 'fixup_irqs' to common header Steven J. Hill
  2013-07-25 17:05 ` David Daney
@ 2013-09-03 16:24 ` Ralf Baechle
  1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2013-09-03 16:24 UTC (permalink / raw)
  To: Steven J. Hill; +Cc: linux-mips, David Daney

On Thu, Jul 25, 2013 at 12:40:17AM -0500, Steven J. Hill wrote:

> To prepare for CPU hotplug of CM-based platforms.

But for the time being this is all Octeon-specific code - and without
seeing the patches for the other CM-based platforms I don't even know
if that fixup_irqs() function really serves the same purpose, so I've
added an octeon_ prefix to the function's name and moved its declaration
to a header file.

  Ralf

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-03 16:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-25  5:40 [PATCH] MIPS: Octeon: Move declaration of 'fixup_irqs' to common header Steven J. Hill
2013-07-25 17:05 ` David Daney
2013-09-03 16:24 ` Ralf Baechle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.